wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only move content pane element to top when sidebar element is clicked

Browse source 
This patch contains a small cleanup that moves the scrollIntoView into onSidebarItemSelected.
Since all other places already have a focus call, scrollIntoView is not needed there.

Bug: T312850
Change-Id: I1a3cb3905faea2bd8a6bf8dc4cfd748813e1c875
This commit is contained in:
Svantje Lilienthal 2022-07-12 16:56:50 +02:00
parent fc70c924e5
commit 36d817dfcd
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/ve-mw/ui/layouts/ve.ui.MWTwoPaneTransclusionDialogLayout.js
View file

@ -157,6 +157,11 @@ ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.onSidebarItemSelected = functi
if ( !soft ) { if ( !soft ) {
this.focus(); this.focus();
} }
var page = this.pages[ pageName ];
if ( page ) {
page.scrollElementIntoView( { alignToTop: true, padding: { top: 20 } } );
}
}; };
/** /**
@ -345,12 +350,8 @@ ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.clearPages = function () {
ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.setPage = function ( name ) { ve.ui.MWTwoPaneTransclusionDialogLayout.prototype.setPage = function ( name ) {
var page = this.pages[ name ]; var page = this.pages[ name ];
if ( page ) { if ( page && name === this.currentPageName ) {
page.scrollElementIntoView( { alignToTop: true, padding: { top: 20 } } ); return;
if ( name === this.currentPageName ) {
return;
}
} }
var previousPage = this.currentPageName ? this.pages[ this.currentPageName ] : null; var previousPage = this.currentPageName ? this.pages[ this.currentPageName ] : null;