wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-25 19:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Followup 54458c8: make newly RTFified icons actually work everywhere

Browse source 
Right now our system is so horrible that we need three separate
CSS rules to make the icons appear in three separate places:

1. Toolbar (with contextual directionality)
2. Context menu
3. Top-left corner of dialogs

Also, the icons in the context menu should use contextual directionality
but are using the document directionality because the context doesn't
compute and set a class for the context directionality. This is only
done by the toolbar. It used to work because the context menu *was*
a toolbar, but that changed recently.

Change-Id: I3ebc1ba7dfcd384a2a62664e55a4a77c8dedd513
This commit is contained in:
Roan Kattouw 2014-07-02 19:54:07 -07:00
parent 8bd8c6c8f5
commit 30b245ff64
1 changed files with 30 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
modules/ve-mw/ui/styles/ve.ui.Icons.css
View file

@ -12,13 +12,17 @@
}
/* @noflip */
.ve-ui-dir-block-rtl .oo-ui-icon-gallery {
.ve-ui-dir-block-rtl .oo-ui-icon-gallery,
/* HACK */ .ve-ui-surface-dir-rtl .oo-ui-icon-gallery,
/* HACK */ .oo-ui-rtl .oo-ui-icon-gallery {
/* @embed */
background-image: url(images/icons/gallery-rtl.svg);
}
/* @noflip */
.ve-ui-dir-block-ltr .oo-ui-icon-gallery {
.ve-ui-dir-block-ltr .oo-ui-icon-gallery,
/* HACK */ .ve-ui-surface-dir-ltr .oo-ui-icon-gallery,
/* HACK */ .oo-ui-ltr .oo-ui-icon-gallery {
/* @embed */
background-image: url(images/icons/gallery-ltr.svg);
}
@ -68,25 +72,33 @@
}
/* @noflip */
.ve-ui-dir-block-rtl .oo-ui-icon-reference {
.ve-ui-dir-block-rtl .oo-ui-icon-reference,
/* HACK */ .ve-ui-surface-dir-rtl .oo-ui-icon-reference,
/* HACK */ .oo-ui-rtl .oo-ui-icon-reference {
/* @embed */
background-image: url(images/icons/reference-rtl.svg);
}
/* @noflip */
.ve-ui-dir-block-ltr .oo-ui-icon-reference {
.ve-ui-dir-block-ltr .oo-ui-icon-reference,
/* HACK */ .ve-ui-surface-dir-ltr .oo-ui-icon-reference,
/* HACK */ .oo-ui-ltr .oo-ui-icon-reference {
/* @embed */
background-image: url(images/icons/reference-ltr.svg);
}
/* @noflip */
.ve-ui-dir-block-rtl .oo-ui-icon-references {
.ve-ui-dir-block-rtl .oo-ui-icon-references,
/* HACK */ .ve-ui-surface-dir-rtl .oo-ui-icon-references,
/* HACK */ .oo-ui-rtl .oo-ui-icon-references {
/* @embed */
background-image: url(images/icons/references-rtl.svg);
}
/* @noflip */
.ve-ui-dir-block-ltr .oo-ui-icon-references {
.ve-ui-dir-block-ltr .oo-ui-icon-references,
/* HACK */ .ve-ui-surface-dir-ltr .oo-ui-icon-references,
/* HACK */ .oo-ui-ltr .oo-ui-icon-references {
/* @embed */
background-image: url(images/icons/references-ltr.svg);
}
@ -97,25 +109,33 @@
}
/* @noflip */
.ve-ui-dir-block-rtl .oo-ui-icon-ref-cite-journal {
.ve-ui-dir-block-rtl .oo-ui-icon-ref-cite-journal,
/* HACK */ .ve-ui-surface-dir-rtl .oo-ui-icon-ref-cite-journal,
/* HACK */ .oo-ui-rtl .oo-ui-icon-ref-cite-journal {
/* @embed */
background-image: url(images/icons/ref-cite-journal-rtl.svg);
}
/* @noflip */
.ve-ui-dir-block-ltr .oo-ui-icon-ref-cite-journal {
.ve-ui-dir-block-ltr .oo-ui-icon-ref-cite-journal,
/* HACK */ .ve-ui-surface-dir-ltr .oo-ui-icon-ref-cite-journal,
/* HACK */ .oo-ui-ltr .oo-ui-icon-ref-cite-journal {
/* @embed */
background-image: url(images/icons/ref-cite-journal-ltr.svg);
}
/* @noflip */
.ve-ui-dir-block-rtl .oo-ui-icon-ref-cite-news {
.ve-ui-dir-block-rtl .oo-ui-icon-ref-cite-news,
/* HACK */ .ve-ui-surface-dir-rtl .oo-ui-icon-ref-cite-news,
/* HACK */ .oo-ui-rtl .oo-ui-icon-ref-cite-news {
/* @embed */
background-image: url(images/icons/ref-cite-news-rtl.svg);
}
/* @noflip */
.ve-ui-dir-block-ltr .oo-ui-icon-ref-cite-news {
.ve-ui-dir-block-ltr .oo-ui-icon-ref-cite-news,
/* HACK */ .ve-ui-surface-dir-ltr .oo-ui-icon-ref-cite-news,
/* HACK */ .oo-ui-ltr .oo-ui-icon-ref-cite-news {
/* @embed */
background-image: url(images/icons/ref-cite-news-ltr.svg);
}