[BrowserTest] more rubocop style fixes

Change-Id: Ibc1cabbdc00f569b10fd6aae0e5bb998211745b1

.rubocop_todo.yml

@@ -1,5 +1,5 @@
 # This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-11-18 16:16:54 -0700 using RuboCop version 0.27.1.
+# on 2014-11-20 12:05:21 -0700 using RuboCop version 0.27.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -9,25 +9,15 @@
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/BlockAlignment:
-  Enabled: false
-
 # Offense count: 4
 Lint/ParenthesesAsGroupedExpression:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/UnusedBlockArgument:
-  Enabled: false
-
 # Offense count: 2
 Metrics/AbcSize:
   Max: 19
 
-# Offense count: 190
+# Offense count: 191
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
   Max: 398
@@ -37,38 +27,24 @@ Metrics/LineLength:
 Metrics/MethodLength:
   Max: 18
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/AndOr:
-  Enabled: false
-
 # Offense count: 4
 Style/Documentation:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/EmptyLines:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/EmptyLinesAroundClassBody:
-  Enabled: false
-
 # Offense count: 3
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
   Enabled: false
 
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/HashSyntax:
+# Offense count: 1
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
   Enabled: false
 
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/LeadingCommentSpace:
+  Enabled: false
 
 # Offense count: 179
 # Cop supports --auto-correct.
@@ -80,4 +56,3 @@ Style/SpaceAfterComma:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/StringLiterals:
   Enabled: false
-

modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb

@@ -35,7 +35,7 @@ Given(/^I am edit language screenshot page with (.+)$/) do |content|
   step "I edit the page with #{content}"
 end
 
-Given(/^I select an image by searching (.+) in Media option$/) do |content|
+Given(/^I select an image by searching (.+) in Media option$/) do |_content|
   step "I click in the editable part"
   step "I click Media"
   step "I enter San Francisco into media Search box"

modules/ve-mw/tests/browser/features/step_definitions/media_interface_steps.rb

@@ -11,7 +11,7 @@ end
 
 When(/^I select an Image$/) do
   on(VisualEditorPage).media_select_element.when_present.click
-  end
+end
 
 Then(/^(.+) should appear in the media diff view$/) do |headings_string|
   on(VisualEditorPage) do |page|

modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb

@@ -1,6 +1,6 @@
 Given(/^I am on the (.+) page$/) do |article|
   article = article.gsub(/ /, '_')
-  visit(ZtargetPage, :using_params => { :article_name => article })
+  visit(ZtargetPage, using_params: { article_name: article })
 end
 
 Given(/^I click in the editable part$/) do

modules/ve-mw/tests/browser/features/step_definitions/verify_production_wikis_steps.rb

@@ -1,5 +1,5 @@
 When(/^I visit a non-existent page at (.+)$/) do |site|
-  visit(DummyPage, :using_params => { :site => site })
+  visit(DummyPage, using_params: { site: site })
 end
 
 Then(/^I should see the Visual Editor editing surface$/) do

modules/ve-mw/tests/browser/features/support/hooks.rb

@@ -4,7 +4,7 @@ end
 
 #This is for the multiedit test
 Before("@edit_user_page_login") do
-  if (!$edit_user_page_login or !(ENV["REUSE_BROWSER"] == "true")) and @browser
+  if (!$edit_user_page_login || !(ENV["REUSE_BROWSER"] == "true")) && @browser
     step "I am logged in"
     step "I go to the browser specific edit page page"
     step "I edit the page with Editing with"

modules/ve-mw/tests/browser/features/support/pages/dummy_page.rb

@@ -4,7 +4,6 @@ class DummyPage
   include URL
   page_url ("http://<%=params[:site]%>/wiki/asdfdgfghlkj?veaction=edit")
 
-  div(:ve_editing_surface, :class => "ve-ui-surface ve-init-mw-viewPageTarget-surface")
-  div(:ve_editing_toolbar, :class => "oo-ui-toolbar-bar")
-
+  div(:ve_editing_surface, class: "ve-ui-surface ve-init-mw-viewPageTarget-surface")
+  div(:ve_editing_toolbar, class: "oo-ui-toolbar-bar")
 end

modules/ve-mw/tests/browser/features/support/pages/user_page.rb

@@ -5,5 +5,4 @@ class UserPage
   page_url URL.url("<%=params[:page_title]%>")
 
   div(:ve_editing_surface, class: "ve-ui-surface ve-init-mw-viewPageTarget-surface")
-
 end