wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-24 10:48:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page

Browse source 
Bug is just about blocked-notice-logextract, but the same EditPage code also deals with
userpage-userdoesnotexist so lets deal with that too while we're here as it's trivial.

Bug: 51454
Change-Id: Ic8a8f135c9f76f645c25a31d9432b5e2786dcfa0
This commit is contained in:
Krenair 2014-03-26 20:39:45 +00:00 committed by Roan Kattouw
parent f774eeb4c8
commit 2dcb2419dd
1 changed files with 52 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
ApiVisualEditor.php
View file

@ -353,23 +353,32 @@ class ApiVisualEditor extends ApiBase {
# Then it must be protected based on static groups (regular) # Then it must be protected based on static groups (regular)
$noticeMsg = 'protectedpagewarning'; $noticeMsg = 'protectedpagewarning';
} }
$lp = new LogPager(
new LogEventsList( $this->getContext() ),
'protect',
'',
$page->getPrefixedDBkey()
);
$lp->mLimit = 1;
$notices[] = wfMessage( $noticeMsg )->parseAsBlock() . $lp->getBody() . Linker::link( $notices[] = $this->msg( $noticeMsg )->parseAsBlock() .
SpecialPage::getTitleFor( 'Log' ), $this->getLastLogEntry( $page, 'protect' );
$this->msg( 'log-fulllog' )->escaped(), }
array(),
array( // Show notice when editing user / user talk page of a user that doesn't exist
'page' => $page->getPrefixedDBkey(), // or who is blocked
'type' => 'protect' // HACK of course this code is partly duplicated from EditPage.php :(
) if ( $page->getNamespace() == NS_USER || $page->getNamespace() == NS_USER_TALK ) {
); $parts = explode( '/', $page->getText(), 2 );
$targetUsername = $parts[0];
$targetUser = User::newFromName( $targetUsername, false /* allow IP users*/ );
if (
!( $targetUser && $targetUser->isLoggedIn() ) &&
!User::isIP( $targetUsername )
) { // User does not exist
$notices[] = "<div class=\"mw-userpage-userdoesnotexist error\">\n" .
$this->msg( 'userpage-userdoesnotexist', wfEscapeWikiText( $targetUsername ) ) .
"\n</div>";
} elseif ( $targetUser->isBlocked() ) { // Show log extract if the user is currently blocked
$notices[] = $this->msg(
'blocked-notice-logextract',
$targetUser->getName() // Support GENDER in notice
)->parseAsBlock() . $this->getLastLogEntry( $targetUser->getUserPage(), 'block' );
}
} }
// HACK: Build a fake EditPage so we can get checkboxes from it // HACK: Build a fake EditPage so we can get checkboxes from it
@ -486,6 +495,33 @@ class ApiVisualEditor extends ApiBase {
$this->getResult()->addValue( null, $this->getModuleName(), $result ); $this->getResult()->addValue( null, $this->getModuleName(), $result );
} }
/**
* Gets the relevant HTML for the latest log entry on a given title, including a full log link.
*
* @param $title Title
* @param $types array|string
* @returns string
*/
private function getLastLogEntry( $title, $types = '' ) {
$lp = new LogPager(
new LogEventsList( $this->getContext() ),
$types,
'',
$title->getPrefixedDbKey()
);
$lp->mLimit = 1;
return $lp->getBody() . Linker::link(
SpecialPage::getTitleFor( 'Log' ),
$this->msg( 'log-fulllog' )->escaped(),
array(),
array(
'page' => $title->getPrefixedDBkey(),
'type' => is_string( $types ) ? $types : null
)
);
}
public function getAllowedParams() { public function getAllowedParams() {
return array( return array(
'page' => array( 'page' => array(