wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-23 14:06:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix exception editing cross-wiki redirects

Browse source 
As described in T326169, when editing a (manually created) cross-wiki redirect,
VisualEditor will throw a null dereference exception causing it to fail to load
in the browser (looking like it is just taking forever to load).

This patch prevents the exception from occurring by not attempting to write to
the null object.

Bug: T326169
Change-Id: I50fa803c7b4ce65dac1fe345431d8b8f9d0b3d61
(cherry picked from commit a9278f654b)
This commit is contained in:
Mahmoud Al-Qudsi 2024-08-25 13:06:29 -05:00 committed by Bartosz Dziewoński
parent fb14b2d3f4
commit 29256f1c37
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js
View file

@ -35,7 +35,9 @@ ve.dm.MWRedirectMetaItem.static.matchRdfaTypes = [ 'mw:PageProp/redirect' ];
ve.dm.MWRedirectMetaItem.static.toDataElement = function ( domElements, converter ) {
// HACK piggy-back on MWInternalLinkAnnotation's ./ stripping logic
var linkData = ve.dm.MWInternalLinkAnnotation.static.toDataElement( domElements, converter );
linkData.type = this.name;
if ( linkData ) {
linkData.type = this.name;
}
return linkData;
};