wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Real cross browser fix for invisible iframe bug.

Browse source 
Change-Id: Ia2d3c83562542aaaddf0b81dfeaef9aa408aaed3
This commit is contained in:
Rob Moen 2012-06-13 13:29:18 -07:00
parent a991cefbe7
commit 26e0f6ed5f
4 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/ve2/ui/styles/ve.ui.Context.css
View file

@ -55,7 +55,7 @@
} }
.es-contextView-inspectors { .es-contextView-inspectors {
position: absolute; position: absolute;
} }
.es-contextView-position-above .es-inspector { .es-contextView-position-above .es-inspector {

1
modules/ve2/ui/styles/ve.ui.Inspector.css
View file

@ -1,6 +1,5 @@
.es-inspector { .es-inspector {
font-family: sans-serif; font-family: sans-serif;
display: none;
position: absolute; position: absolute;
border: solid 1px #cccccc; border: solid 1px #cccccc;
-webkit-border-radius: 0.25em; -webkit-border-radius: 0.25em;

10
modules/ve2/ui/ve.ui.Context.js
View file

@ -90,7 +90,6 @@ ve.ui.Context.prototype.set = function() {
if ( this.position ) { if ( this.position ) {
this.positionOverlay( this.menuView.$ ); this.positionOverlay( this.menuView.$ );
if ( this.inspector ) { if ( this.inspector ) {
//this.positionOverlay( this.inspectors[this.inspector].$ );
this.positionOverlay ( this.$inspectors ); this.positionOverlay ( this.$inspectors );
} }
} }
@ -137,8 +136,8 @@ ve.ui.Context.prototype.positionOverlay = function( $overlay ) {
} }
$overlay.css( 'left', overlayLeft ); $overlay.css( 'left', overlayLeft );
// Position overlay on top or bottom depending on viewport
// Position overlay on top or bottom depending on viewport
if ( this.position.top + overlayHeight + ( overlayMargin * 2 ) < windowHeight + windowScrollTop ) { if ( this.position.top + overlayHeight + ( overlayMargin * 2 ) < windowHeight + windowScrollTop ) {
this.$.addClass( 'es-contextView-position-below' ); this.$.addClass( 'es-contextView-position-below' );
} else { } else {
@ -162,16 +161,13 @@ ve.ui.Context.prototype.openInspector = function( name ) {
this.inspectors[name].open(); this.inspectors[name].open();
this.positionOverlay( this.$inspectors ); this.positionOverlay( this.$inspectors );
this.$inspectors.show(); this.$inspectors.show();
//this.positionOverlay( this.inspectors[name].$ );
this.inspector = name; this.inspector = name;
}; };
ve.ui.Context.prototype.closeInspector = function( accept ) { ve.ui.Context.prototype.closeInspector = function( accept ) {
if ( this.inspector ) { if ( this.inspector ) {
this.$inspectors.hide();
this.inspectors[this.inspector].close( accept ); this.inspectors[this.inspector].close( accept );
this.$inspectors.hide();
this.inspector = null; this.inspector = null;
} }
}; };
@ -217,7 +213,7 @@ ve.ui.Context.prototype.addInspector = function( name, inspector ) {
_this.$inspectors.css( { _this.$inspectors.css( {
'width': inspector.$.outerWidth( true ) + 10, 'width': inspector.$.outerWidth( true ) + 10,
'height': inspector.$.outerHeight( true ) + 10 'height': inspector.$.outerHeight( true ) + 10
} ); } ).hide();
} }
}; };

2
modules/ve2/ui/ve.ui.Inspector.js
View file

@ -1,6 +1,6 @@
/** /**
* Creates an ve.ui.Inspector object. * Creates an ve.ui.Inspector object.
* *
* @class * @class
* @constructor * @constructor
* @param {ve.ui.Toolbar} toolbar * @param {ve.ui.Toolbar} toolbar