From 239e592d15c7cc5482321a45b516f6bbdbfc4cf5 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Sun, 23 Jun 2019 16:58:04 +0100 Subject: [PATCH] MW link inspector: Empty before appending We don't inherit any root DOM structure from the parent, so explicitly clear it. Change-Id: If4c034e8230ccaf721a8e3667f29c6783c94a8bb --- modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js b/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js index 4658435bdf..135ba7633b 100644 --- a/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js +++ b/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js @@ -94,7 +94,7 @@ ve.ui.MWLinkAnnotationInspector.prototype.initialize = function () { this.linkTypeIndex.$content.append( this.$otherActions ); this.linkTypeIndex.getTabPanel( 'internal' ).$element.append( this.internalAnnotationInput.$element ); this.linkTypeIndex.getTabPanel( 'external' ).$element.append( this.externalAnnotationInput.$element ); - this.form.$element.append( this.linkTypeIndex.$element ); + this.form.$element.empty().append( this.linkTypeIndex.$element ); }; /**