From 1e298ffbc01272533db29457410af2e94e05c57f Mon Sep 17 00:00:00 2001 From: Christian Williams Date: Wed, 3 Jul 2013 13:49:11 -0700 Subject: [PATCH] Fix focusable highlights !$element.is( ':visible' ) - jQuery .is() returns boolean based on the parameter. $element.not( ':visible' ) - jQuery .not() returns a filtered jQuery collection with elements matching the parameter removed. Change-Id: Iedf55f3453514ee710bbb6d702bbf9a5570a4a1d --- modules/ve/ce/ve.ce.FocusableNode.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ve/ce/ve.ce.FocusableNode.js b/modules/ve/ce/ve.ce.FocusableNode.js index 328c672c40..6647d3e813 100644 --- a/modules/ve/ce/ve.ce.FocusableNode.js +++ b/modules/ve/ce/ve.ce.FocusableNode.js @@ -152,7 +152,7 @@ ve.ce.FocusableNode.prototype.createHighlight = function () { this.$.find( '*' ).add( this.$ ).each( ve.bind( function( i, element ) { var offset, $element = $( element ); - if ( $element.not( ':visible' ) ) { + if ( !$element.is( ':visible' ) ) { return true; } offset = ve.Element.getRelativePosition(