wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-27 04:06:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use visibility: hidden; for the ui.Context and its popup

Browse source 
They contain iframes and those need to not be display: none;
in order to make Firefox happy.

Bug: 57568
Change-Id: I177877bff3c3b18bfc87ee4e6afa7e60fea26ffc
This commit is contained in:
Roan Kattouw 2013-12-02 13:03:06 -08:00
parent 07671c6b53
commit 1df63b8a63
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/ve/ui/ve.ui.Context.js
View file

@ -396,7 +396,11 @@ ve.ui.Context.prototype.show = function ( transition, repositionOnly ) {
if ( !this.showing && !this.hiding ) {
this.showing = true;
this.$element.show();
// HACK: make the context and popup visibility: hidden; instead of display: none; because
// they contain inspector iframes, and applying display: none; to those causes them to
// not load in Firefox
this.$element.css( 'visibility', '' );
this.popup.$element.css( 'visibility', '' );
this.popup.show();
// Show either inspector or menu
@ -444,8 +448,12 @@ ve.ui.Context.prototype.hide = function () {
if ( inspector ) {
inspector.close( { 'action': 'hide' } );
}
// HACK: make the context and popup visibility: hidden; instead of display: none; because
// they contain inspector iframes, and applying display: none; to those causes them to
// not load in Firefox
this.popup.hide();
this.$element.hide();
this.popup.$element.show().css( 'visibility', 'hidden' );
this.$element.css( 'visibility', 'hidden' );
this.visible = false;
this.hiding = false;
}