wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix exception when deleting all text (Ctrl+A Backspace)"

Browse source
This commit is contained in:
Trevor Parscal 2012-10-17 19:33:48 +00:00 committed by Gerrit Code Review
parent 874adec1ac 0054cd2a57
commit 1c5ac9d502
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
modules/ve/dm/ve.dm.Surface.js
View file

@ -95,6 +95,7 @@ ve.dm.Surface.prototype.getFragment = function ( range, noAutoSelect ) {
* @param {ve.Range|undefined} selection * @param {ve.Range|undefined} selection
*/ */
ve.dm.Surface.prototype.change = function ( transactions, selection ) { ve.dm.Surface.prototype.change = function ( transactions, selection ) {
var leftOffset, contentOffset, annotations;
if ( transactions ) { if ( transactions ) {
if ( transactions instanceof ve.dm.Transaction ) { if ( transactions instanceof ve.dm.Transaction ) {
transactions = [transactions]; transactions = [transactions];
@ -119,9 +120,16 @@ ve.dm.Surface.prototype.change = function ( transactions, selection ) {
} }
// Clear and add annotations to stack if insertingAnnotations isn't happening // Clear and add annotations to stack if insertingAnnotations isn't happening
if (!this.insertingAnnotations) { if ( !this.insertingAnnotations ) {
var contentOffset = this.documentModel.getNearestContentOffset( this.getSelection().start - 1, -1 ), leftOffset = this.getSelection().start - 1;
annotations = this.documentModel.getAnnotationsFromOffset( contentOffset ); if ( leftOffset == -1 ) {
leftOffset = 0;
}
contentOffset = this.documentModel.getNearestContentOffset( leftOffset, -1 );
// contentOffset may be -1 if the document is empty
annotations = contentOffset > - 1 ?
this.documentModel.getAnnotationsFromOffset( contentOffset ) :
new ve.AnnotationSet();
// Reset insertAnnotations // Reset insertAnnotations
this.documentModel.insertAnnotations = new ve.AnnotationSet(); this.documentModel.insertAnnotations = new ve.AnnotationSet();