From a05f9e4bf426ef0f1ba0d291590fde5e7a9b1f78 Mon Sep 17 00:00:00 2001 From: "James D. Forrester" Date: Wed, 4 Sep 2019 17:49:48 -0700 Subject: [PATCH] Update VE core submodule to master (0b17a137b) New changes: d4cb2f03e Update OOUI to v0.34.0 b0b481693 jsduck: Stop listing OOjs in upstream, it's using JSDoc now 0b17a137b Update OOjs to v3.0.0 Change-Id: If29a97ce689523763431face5a13929a461735b4 --- jsduck.json | 1 - lib/ve | 2 +- modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js | 7 ++++++- .../ui/ve.ui.MWWikitextDataTransferHandlerFactory.js | 12 +++++++++++- 4 files changed, 18 insertions(+), 4 deletions(-) diff --git a/jsduck.json b/jsduck.json index c3f118cc34..ba0ab35509 100644 --- a/jsduck.json +++ b/jsduck.json @@ -12,7 +12,6 @@ "--": [ ".jsduck/external.js", "lib/ve/.jsduck/external.js", - "lib/ve/lib/oojs/oojs.jquery.js", "lib/ve/lib/oojs-ui/oojs-ui-core.js", "lib/ve/lib/oojs-ui/oojs-ui-widgets.js", "lib/ve/lib/oojs-ui/oojs-ui-toolbars.js", diff --git a/lib/ve b/lib/ve index f2b6e7db99..0b17a137bc 160000 --- a/lib/ve +++ b/lib/ve @@ -1 +1 @@ -Subproject commit f2b6e7db993cd1c49f2ecd5c2980a5a1820bdefb +Subproject commit 0b17a137bc64458d1b133acc397d05937becb206 diff --git a/modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js b/modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js index dbd930b065..59446b9ace 100644 --- a/modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js +++ b/modules/ve-mw/ui/ve.ui.MWWikitextCommandRegistry.js @@ -26,7 +26,12 @@ OO.inheritClass( ve.ui.MWWikitextCommandRegistry, ve.ui.CommandRegistry ); /* Methods */ /** - * @inheritdoc + * Get data for a given symbolic name. + * + * See https://doc.wikimedia.org/oojs/master/OO.Registry.html + * + * @param {string} name Symbolic name + * @return {Mixed|undefined} Data associated with symbolic name */ ve.ui.MWWikitextCommandRegistry.prototype.lookup = function ( name ) { // Parent method diff --git a/modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js b/modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js index a96905d9f7..f6bc014886 100644 --- a/modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js +++ b/modules/ve-mw/ui/ve.ui.MWWikitextDataTransferHandlerFactory.js @@ -34,7 +34,17 @@ OO.inheritClass( ve.ui.MWWikitextDataTransferHandlerFactory, ve.ui.DataTransferH /* Methods */ /** - * @inheritdoc + * Create an object based on a name. + * + * Name is used to look up the constructor to use, while all additional arguments are passed to the + * constructor directly, so leaving one out will pass an undefined to the constructor. + * + * See https://doc.wikimedia.org/oojs/master/OO.Factory.html + * + * @param {string} name Object name + * @param {...Mixed} [args] Arguments to pass to the constructor + * @return {Object} The new object + * @throws {Error} Unknown object name */ ve.ui.MWWikitextDataTransferHandlerFactory.prototype.create = function () { // Parent method