wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-29 00:30:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove ve.ce.ImageNode.prototype.onUpdate

Browse source 
Was empty.

Bonus: consistently use object style for .attr(), was already
used for .css()

Change-Id: Idd0592d6f30388c9952e110ff6fff008bb465877
This commit is contained in:
Roan Kattouw 2013-10-11 14:36:12 +02:00
parent 0c6dadb605
commit 1999ece918
1 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
modules/ve/ce/nodes/ve.ce.ImageNode.js
View file

@ -31,14 +31,15 @@ ve.ce.ImageNode = function VeCeImageNode( model, config ) {
this.$image = this.$; this.$image = this.$;
// Events // Events
this.model.connect( this, { 'update': 'onUpdate' } );
this.$.on( 'click', ve.bind( this.onClick, this ) ); this.$.on( 'click', ve.bind( this.onClick, this ) );
// Initialization // Initialization
this.$image this.$image
.addClass( 've-ce-imageNode' ) .addClass( 've-ce-imageNode' )
.attr( 'alt', this.model.getAttribute( 'alt' ) ) .attr( {
.attr( 'src', this.model.getAttribute( 'src' ) ) 'alt': this.model.getAttribute( 'alt' ),
'src': this.model.getAttribute( 'src' )
} )
.css( { .css( {
'width': this.model.getAttribute( 'width' ), 'width': this.model.getAttribute( 'width' ),
'height': this.model.getAttribute( 'height' ) 'height': this.model.getAttribute( 'height' )
@ -83,14 +84,6 @@ ve.ce.ImageNode.prototype.onAttributeChange = function ( key, from, to ) {
} }
}; };
/**
* Update method
*
* @method
*/
ve.ce.ImageNode.prototype.onUpdate = function () {
};
/** /**
* Handle the mouse click. * Handle the mouse click.
* *