diff --git a/includes/ApiVisualEditor.php b/includes/ApiVisualEditor.php index 822fc91772..8bd6be53fb 100644 --- a/includes/ApiVisualEditor.php +++ b/includes/ApiVisualEditor.php @@ -134,13 +134,15 @@ class ApiVisualEditor extends ApiBase { ); } else { // error null, code not 200 - $trace = ( new Exception )->getTraceAsString(); $this->logger->warning( - __METHOD__ . ": Received HTTP {$response['code']} from RESTBase for $path." . - " Trace: {$trace}" . - " Response: {$response['body']}" . - /** @phan-suppress-next-line PhanTypeInvalidDimOffset */ - " Request If-Match: {$reqheaders['If-Match']}" + __METHOD__ . ": Received HTTP {code} from RESTBase", + [ + 'code' => $response['code'], + 'trace' => ( new Exception )->getTraceAsString(), + 'response' => $response['body'], + 'requestPath' => $path, + 'requestIfMatch' => $reqheaders['If-Match'] ?? '', + ] ); $this->dieWithError( [ 'apierror-visualeditor-docserver-http', $response['code'] ], @@ -634,7 +636,11 @@ class ApiVisualEditor extends ApiBase { $badetag = $params['badetag']; $goodetag = $result['etag'] ?? ''; $this->logger->info( - __METHOD__ . ": Client reported bad ETag: $badetag, expected: $goodetag" + __METHOD__ . ": Client reported bad ETag: {badetag}, expected: {goodetag}", + [ + 'badetag' => $badetag, + 'goodetag' => $goodetag, + ] ); } if ( $params['paction'] === 'parse' || diff --git a/includes/ApiVisualEditorEdit.php b/includes/ApiVisualEditorEdit.php index 547aceaf29..a9d8503baf 100644 --- a/includes/ApiVisualEditorEdit.php +++ b/includes/ApiVisualEditorEdit.php @@ -288,7 +288,11 @@ class ApiVisualEditorEdit extends ApiVisualEditor { "?$ /x', $etag ) ) { $this->logger->info( - __METHOD__ . ": Received funny ETag from client: $etag for $path" + __METHOD__ . ": Received funny ETag from client: {etag}", + [ + 'etag' => $etag, + 'requestPath' => $path, + ] ); } return $this->requestRestbase(