From 6dd98b5f3ba946598e1761ffd88253d0f6c5f139 Mon Sep 17 00:00:00 2001 From: Brad Jorsch Date: Sat, 9 Aug 2014 14:08:14 +0100 Subject: [PATCH] Update token handling for MediaWiki API change MediaWiki change I2793a3f2 changes API handling in a way that needs updates to extensions for proper operation: * needsToken() now returns a string * Most custom token types are being replaced with a 'csrf' token (the former 'edit' token); any others need a new hook. * All tokens must use a static salt. Compat with web UI using non-static tokens is supported and also serves to handle the now-deprecated token fetching. * Documentation in getParamDescription() should return a string (not array) for 'token', as the signal to core that it should be replaced with a standardized message. When compatibility with earlier versions of MediaWiki is no longer maintained, the entry for 'token' from getAllowedParams() and getParamDescription() may be removed, as may getTokenSalt(). This patch leaves them in place. Note this is intended to be compatible with earlier versions of MediaWiki, and so should be safe to merge before the core change. Change-Id: Ia6e512aae366996de4e73a8d7f4f03fcddd77286 --- ApiVisualEditorEdit.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ApiVisualEditorEdit.php b/ApiVisualEditorEdit.php index bf70a6b2f5..6af584901f 100644 --- a/ApiVisualEditorEdit.php +++ b/ApiVisualEditorEdit.php @@ -165,7 +165,7 @@ class ApiVisualEditorEdit extends ApiVisualEditor { } public function needsToken() { - return true; + return 'csrf'; } public function getTokenSalt() {