Merge "Allow skin developers to set an offset for toolbar floating"

This commit is contained in:
jenkins-bot 2015-07-28 20:01:57 +00:00 committed by Gerrit Code Review
commit 12d22fe48a
3 changed files with 16 additions and 1 deletions

View file

@ -57,6 +57,15 @@ class VisualEditorHooks {
'ext.visualEditor.targetLoader'
) );
$output->addModuleStyles( array( 'ext.visualEditor.viewPageTarget.noscript' ) );
// add scroll offset js variable to output
$veConfig = ConfigFactory::getDefaultInstance()->makeConfig( 'visualeditor' );
$skinsToolbarScrollOffset = $veConfig->get( 'VisualEditorSkinToolbarScrollOffset' );
$toolbarScrollOffset = 0;
$skinName = $skin->getSkinName();
if ( isset( $skinsToolbarScrollOffset[$skinName] ) ) {
$toolbarScrollOffset = $skinsToolbarScrollOffset[$skinName];
}
$output->addJsConfigVars( 'wgVisualEditorToolbarScrollOffset', $toolbarScrollOffset );
return true;
}

View file

@ -98,6 +98,7 @@
"VisualEditorEnableTocWidget": false,
"VisualEditorAutoAccountEnable": false,
"VisualEditorAvailableNamespaces": { "2": true },
"VisualEditorSkinToolbarScrollOffset": [],
"VisualEditorParsoidTimeout": 100
},
"APIModules": {

View file

@ -20,7 +20,12 @@
*/
ve.init.mw.Target = function VeInitMwTarget( pageName, revisionId ) {
// Parent constructor
ve.init.Target.call( this, { shadow: true, actions: true, floatable: true } );
ve.init.Target.call( this, {
shadow: true,
actions: true,
floatable: true,
scrollOffset: mw.config.get( 'wgVisualEditorToolbarScrollOffset', 0 )
} );
// Properties
this.pageName = pageName;