From 11673b21add4bd9a30395199836df6efdd559d02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20Dziewo=C5=84ski?= Date: Tue, 23 Apr 2019 20:27:38 +0200 Subject: [PATCH] ve.ui.MWSaveDialog: Work around save panel disappearing on iOS Safari as well Same thing as Ifb49ede450cabdcd8303b298b62f2ac632809b53, for a slightly different case that we missed. Bug: T221289 Change-Id: I0ca287af87e1058620fbed75a50d40f01513a567 --- modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js index 2a5be5b4ce..814dd842cf 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js @@ -437,6 +437,11 @@ ve.ui.MWSaveDialog.prototype.swapPanel = function ( panel, noFocus ) { action.toggle( dialog.canReview ); } ); + // Support: iOS + // HACK: iOS Safari sometimes makes the entire panel completely disappear (T221289). + // Rebuilding it makes it reappear. + OO.ui.Element.static.reconsiderScrollbars( panelObj.$element[ 0 ] ); + mw.hook( 've.saveDialog.stateChanged' ).fire(); }; @@ -754,6 +759,7 @@ ve.ui.MWSaveDialog.prototype.updateReviewMode = function () { this.report.toggle( false ); } + // Support: iOS // HACK: iOS Safari sometimes makes the entire panel completely disappear (T219680). // Rebuilding it makes it reappear. OO.ui.Element.static.reconsiderScrollbars( this.reviewPanel.$element[ 0 ] );