wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-04 18:58:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Call focusPart() only once in MWTemplateDialog.onReplacePart()"

Browse source
This commit is contained in:
jenkins-bot 2021-08-20 09:56:52 +00:00 committed by Gerrit Code Review
parent cdf7d907a9 301c84bda4
commit 112bd2e5cb
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
View file

@ -126,7 +126,7 @@ ve.ui.MWTemplateDialog.prototype.onReplacePart = function ( removed, added ) {
this.bookletLayout.addPages( [ page ], this.transclusionModel.getIndex( added ) );
if ( reselect ) {
// Use added page instead of closest page
this.transclusions.focusPart( added.getId() );
reselect = added.getId();
}
if ( added instanceof ve.dm.MWTemplateModel ) {
@ -147,7 +147,7 @@ ve.ui.MWTemplateDialog.prototype.onReplacePart = function ( removed, added ) {
if ( names.length ) {
// Focus the first element when parameters are present
this.transclusions.focusPart( added.getParameter( names[ 0 ] ).getId() );
reselect = added.getParameter( names[ 0 ] ).getId();
} else if ( shouldAddPlaceholder && !this.isNewSidebar ) {
page.addPlaceholderParameter();
}
@ -162,7 +162,9 @@ ve.ui.MWTemplateDialog.prototype.onReplacePart = function ( removed, added ) {
}
}
}
} else if ( reselect ) {
}
if ( reselect ) {
this.transclusions.focusPart( reselect );
}