wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-29 00:30:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

get rid of separate undoState function

Browse source
This commit is contained in:
Neil Kandalgaonkar 2011-12-01 19:08:24 +00:00
parent b7cc76acd8
commit 0f12bd9b59
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
modules/es/models/es.SurfaceModel.js
View file

@ -118,12 +118,12 @@ es.SurfaceModel.prototype.transact = function( transaction, combine ) {
* @param {Integer} Number of document-changing states to reverse * @param {Integer} Number of document-changing states to reverse
*/ */
es.SurfaceModel.prototype.undo = function( transactionsToUndo ) { es.SurfaceModel.prototype.undo = function( transactionsToUndo ) {
/**
* Undo a state. while ( transactionsToUndo ) {
* @return {Boolean} whether visible change was undone.
*/
function undoState( state ) {
var hadTransaction = false; var hadTransaction = false;
var state = this.currentState;
var i = state.length - 1; var i = state.length - 1;
while ( i-- ) { while ( i-- ) {
if ( state[i] instanceof es.TransactionModel ) { if ( state[i] instanceof es.TransactionModel ) {
@ -132,11 +132,7 @@ es.SurfaceModel.prototype.undo = function( transactionsToUndo ) {
} }
} }
this.emit( 'undo', state ); this.emit( 'undo', state );
return hadTransaction;
}
while ( transactionsToUndo ) {
var hadTransaction = undoState( this.currentState );
if ( hadTransaction ) { if ( hadTransaction ) {
transactionsToUndo--; transactionsToUndo--;
} }