wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-29 00:30:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ridiculous MetaList test case

Browse source 
Doing retainMetadata followed by a replace (not replaceMetadata)
doesn't make any sense and its behavior is undefined, so don't do that
in the test suite.

Change-Id: Ica032b0a5122d24e40e43e3eb43fea940270aece
This commit is contained in:
Roan Kattouw 2013-09-04 14:04:59 -07:00
parent 27dfe83e6f
commit 0e51375aa9
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/ve/test/dm/ve.dm.MetaList.test.js
View file

@ -106,7 +106,6 @@ QUnit.test( 'onTransact', function ( assert ) {
[ 'pushRetain', 1 ],
[ 'pushReplaceMetadata', [ ve.dm.example.withMetaMetaData[9][0] ], [] ],
[ 'pushRetain', 2 ],
[ 'pushRetainMetadata', 2 ],
// The two operations below have to be in this order because of bug 46138
[ 'pushReplace', doc, 11, 0, [ { 'type': 'paragraph' }, 'a', 'b', 'c', { 'type': '/paragraph' } ] ],
[ 'pushReplaceMetadata', [], [ comment ] ]
@ -123,7 +122,7 @@ QUnit.test( 'onTransact', function ( assert ) {
for ( j = 0; j < cases[i].calls.length; j++ ) {
tx[cases[i].calls[j][0]].apply( tx, cases[i].calls[j].slice( 1 ) );
}
doc = ve.dm.example.createExampleDocument( 'withMeta' ),
doc = ve.dm.example.createExampleDocument( 'withMeta' );
surface = new ve.dm.Surface( doc );
list = new ve.dm.MetaList( surface );
// Test both the transaction-via-surface and transaction-via-document flows