wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Detect collapsed range inside focusable node in ve.ce.Surface#onChange

Browse source 
When the document starts with a focusable node, and we try to initialise
the selection to [1,1], the current logic does not detect that as being
on the focusable node and tries to do a native selection.

Bug: 54446
Change-Id: Ib515c435314c35c4e9b3802da117b963b3ef4169
This commit is contained in:
Ed Sanders 2013-09-24 16:53:55 +01:00
parent 9740d1683e
commit 0c2b6c353e
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve/ce/ve.ce.Surface.js
View file

@ -924,6 +924,12 @@ ve.ce.Surface.prototype.onChange = function ( transaction, selection ) {
next = start;
}
}
} else {
// Check we haven't been programmatically placed inside a focusable node with a collapsed selection
start = this.documentView.getDocumentNode().getNodeFromOffset( selection.start );
if ( ve.isMixedIn( start, ve.ce.FocusableNode ) ) {
next = start;
}
}
// Update nodes if something changed
if ( previous !== next ) {