Kill attribute order preservation

Per the bug report, it's useless because Firefox does not preserve order
in the .attributes array (but sorts it alphabetically instead), and so we
actually get the same exact behavior regardless of whether we use ordering
cleverness or just a straight-up plain object: order is preserved in Chrome,
and alphabetized in Firefox.

Bug: 48980
Change-Id: I1463d06db4900083dd4c565292bbabef09194b43

modules/ve/dm/ve.dm.Converter.js

@@ -119,10 +119,9 @@ ve.dm.Converter.buildHtmlAttributeList = function ( domElements, spec, deep, att
 	attributeList = attributeList || [];
 	for ( i = 0, ilen = domElements.length; i < ilen; i++ ) {
 		domAttributes = domElements[i].attributes || [];
-		attributeList[i] = { 'values': {}, 'keys': [] };
+		attributeList[i] = { 'values': {} };
 		for ( j = 0, jlen = domAttributes.length; j < jlen; j++ ) {
 			if ( ve.dm.Model.matchesAttributeSpec( domAttributes[j].name, spec ) ) {
-				attributeList[i].keys.push( domAttributes[j].name );
 				attributeList[i].values[domAttributes[j].name] = domAttributes[j].value;
 				empty = false;
 			}
@@ -155,7 +154,7 @@ ve.dm.Converter.buildHtmlAttributeList = function ( domElements, spec, deep, att
  * @param {boolean} [overwrite=false] If true, overwrite attributes that are already set
  */
 ve.dm.Converter.renderHtmlAttributeList = function ( attributeList, domElements, spec, overwrite ) {
-	var i, ilen, j, jlen, keys, values;
+	var i, ilen, key, values;
 	if ( spec === undefined ) {
 		spec = true;
 	}
@@ -166,14 +165,13 @@ ve.dm.Converter.renderHtmlAttributeList = function ( attributeList, domElements,
 		if ( !domElements[i] ) {
 			continue;
 		}
-		keys = attributeList[i].keys;
 		values = attributeList[i].values;
-		for ( j = 0, jlen = keys.length; j < jlen; j++ ) {
-			if ( ve.dm.Model.matchesAttributeSpec( keys[j], spec ) ) {
-				if ( values[keys[j]] === undefined ) {
-					domElements[i].removeAttribute( keys[j] );
-				} else if ( overwrite || !domElements[i].hasAttribute( keys[j] ) ) {
-					domElements[i].setAttribute( keys[j], values[keys[j]] );
+		for ( key in values ) {
+			if ( ve.dm.Model.matchesAttributeSpec( key, spec ) ) {
+				if ( values[key] === undefined ) {
+					domElements[i].removeAttribute( key );
+				} else if ( overwrite || !domElements[i].hasAttribute( key ) ) {
+					domElements[i].setAttribute( key, values[key] );
 				}
 			}
 		}

modules/ve/test/dm/ve.dm.Transaction.test.js

@@ -393,12 +393,7 @@ QUnit.test( 'newFromRemoval', function ( assert ) {
 									'width': null,
 									'height': null
 								},
-								'htmlAttributes': [
-									{
-										'keys': [ 'src' ],
-										'values': { 'src': ve.dm.example.imgSrc }
-									}
-								]
+								'htmlAttributes': [ { 'values': { 'src': ve.dm.example.imgSrc } } ]
 							},
 							{ 'type': '/image' },
 							'i'