wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-25 14:56:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix setting of this.loading so it can be cleared

Browse source 
Set this.loading to dataPromise before the done
handler is attached as that can run synchronously
and try to set this.loading back to false.

Change-Id: I4e5208b7bac9968951f30555dc56e054c38a3935
This commit is contained in:
Ed Sanders 2019-05-06 15:09:45 -05:00
parent dd262c5089
commit 0bc3c81978
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/ve-mw/init/ve.init.mw.ArticleTarget.js
View file

@ -1158,7 +1158,8 @@ ve.init.mw.ArticleTarget.prototype.load = function ( dataPromise ) {
targetName: this.constructor.static.trackingName
} );
this.loading = dataPromise
this.loading = dataPromise;
dataPromise
.done( this.loadSuccess.bind( this ) )
.fail( this.loadFail.bind( this ) );