wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Fix spurious MetaList events"

Browse source
This commit is contained in:
jenkins-bot 2013-12-04 11:41:30 +00:00 committed by Gerrit Code Review
parent 32e0850507 39eea83698
commit 0b726589bd
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve/dm/ve.dm.MetaList.js
View file

@ -240,7 +240,7 @@ ve.dm.MetaList.prototype.onTransact = function ( tx ) {
if ( newItems[i].item.isAttached() ) { if ( newItems[i].item.isAttached() ) {
if ( newItems[i].offset !== newItems[i].item.offset || newItems[i].index !== newItems[i].item.index ) { if ( newItems[i].offset !== newItems[i].item.offset || newItems[i].index !== newItems[i].item.index ) {
this.deleteRemovedItem( newItems[i].item.offset, newItems[i].item.index ); this.deleteRemovedItem( newItems[i].item.offset, newItems[i].item.index );
this.addInsertedItem( newItems[i].offset, newItems[i].index, newItems[i].item ); newItems[i].preExisting = true;
} }
} }
} }
@ -249,9 +249,11 @@ ve.dm.MetaList.prototype.onTransact = function ( tx ) {
for ( i = 0, ilen = newItems.length; i < ilen; i++ ) { for ( i = 0, ilen = newItems.length; i < ilen; i++ ) {
if ( !newItems[i].item.isAttached() ) { if ( !newItems[i].item.isAttached() ) {
this.addInsertedItem( newItems[i].offset, newItems[i].index, newItems[i].item ); this.addInsertedItem( newItems[i].offset, newItems[i].index, newItems[i].item );
if ( !newItems[i].preExisting ) {
events.push( [ 'insert', newItems[i].item ] ); events.push( [ 'insert', newItems[i].item ] );
} }
} }
}
// Emit events // Emit events
for ( i = 0, ilen = events.length; i < ilen; i++ ) { for ( i = 0, ilen = events.length; i < ilen; i++ ) {