From 085d2443d2113ac944812eef020889a521835543 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Thu, 25 Jun 2020 16:10:23 +0100 Subject: [PATCH] screenshots: Suppress welcome dialog with query string The code approach appears to suffer from a race condition. Change-Id: I1328907b8fb55265275493b3b0d2a9288afea53c --- build/screenshots-client/utils.js | 3 +-- build/screenshots.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/build/screenshots-client/utils.js b/build/screenshots-client/utils.js index 31a83f67ba..6e89f001ca 100644 --- a/build/screenshots-client/utils.js +++ b/build/screenshots-client/utils.js @@ -100,8 +100,7 @@ module.exports = function () { } }; - // Suppress welcome dialog - mw.storage.set( 've-beta-welcome-dialog', 1 ); + // Welcome dialog suppressed by query string (vehidebetadialog) // Suppress user education indicators mw.storage.set( 've-hideusered', 1 ); mw.hook( 've.activationComplete' ).add( function () { diff --git a/build/screenshots.js b/build/screenshots.js index 293c340b13..8776517967 100644 --- a/build/screenshots.js +++ b/build/screenshots.js @@ -31,7 +31,7 @@ function createScreenshotEnvironment( test, beforeEach ) { driver.manage().timeouts().setScriptTimeout( TIMEOUT ); driver.manage().window().setSize( 1200, 1000 ); - driver.get( 'https://en.wikipedia.org/wiki/Help:Sample_page?veaction=edit&uselang=' + lang ) + driver.get( 'https://en.wikipedia.org/wiki/Help:Sample_page?veaction=edit&vehidebetadialog=1&uselang=' + lang ) .then( null, function ( e ) { console.error( e.message ); } );