wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-14 10:04:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change confusing property name in AddParameterPage

Browse source 
This kept confusing me. This is not an "input field", but a
layout container.

Change-Id: I77d8ddd4635c21512a5800f64e13e76fe08c3091
This commit is contained in:
Thiemo Kreuz 2021-09-14 17:15:55 +02:00
parent 51ad403117
commit 074a295a03
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve-mw/ui/pages/ve.ui.MWAddParameterPage.js
View file

@ -51,7 +51,7 @@ ve.ui.MWAddParameterPage = function VeUiMWAddParameterPage( parameter, name, con
} )
.connect( this, { click: 'onParameterNameSubmitted' } );
this.addParameterInputField = new OO.ui.ActionFieldLayout(
this.actionFieldLayout = new OO.ui.ActionFieldLayout(
this.paramInputField,
this.saveButton,
{ classes: [ 've-ui-mwTransclusionDialog-addParameterFieldset-input' ] }
@ -68,7 +68,7 @@ ve.ui.MWAddParameterPage = function VeUiMWAddParameterPage( parameter, name, con
helpInline: true,
help: $helpText,
classes: [ 've-ui-mwTransclusionDialog-addParameterFieldset' ],
$content: this.addParameterInputField.$element
$content: this.actionFieldLayout.$element
} );
ve.targetLinksToNewWindow( this.addParameterFieldset.$element[ 0 ] );
@ -116,7 +116,7 @@ ve.ui.MWAddParameterPage.prototype.onParameterNameChanged = function ( value ) {
var paramName = value.trim(),
errors = this.getValidationErrors( paramName );
this.addParameterInputField.setErrors( errors );
this.actionFieldLayout.setErrors( errors );
this.saveButton.setDisabled( !paramName || errors.length );
};