wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 10:35:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Convert AnnotationFactory and MetaItemFactory to NamedClassFactories"

Browse source
This commit is contained in:
jenkins-bot 2013-04-09 23:20:20 +00:00 committed by Gerrit Code Review
parent 9cc2d69a27 162f1b4119
commit 05f4579a53
3 changed files with 14 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/ve/dm/ve.dm.AnnotationFactory.js
View file

@ -9,17 +9,17 @@
* DataModel annotation factory.
*
* @class
* @extends ve.Factory
* @extends ve.NamedClassFactory
* @constructor
*/
ve.dm.AnnotationFactory = function VeDmAnnotationFactory() {
// Parent constructor
ve.Factory.call( this );
ve.NamedClassFactory.call( this );
};
/* Inheritance */
ve.inheritClass( ve.dm.AnnotationFactory, ve.Factory );
ve.inheritClass( ve.dm.AnnotationFactory, ve.NamedClassFactory );
/* Initialization */

6
modules/ve/dm/ve.dm.MetaItemFactory.js
View file

@ -9,17 +9,17 @@
* DataModel meta item factory.
*
* @class
* @extends ve.Factory
* @extends ve.NamedClassFactory
* @constructor
*/
ve.dm.MetaItemFactory = function VeDmMetaItemFactory() {
// Parent constructor
ve.Factory.call( this );
ve.NamedClassFactory.call( this );
};
/* Inheritance */
ve.inheritClass( ve.dm.MetaItemFactory, ve.Factory );
ve.inheritClass( ve.dm.MetaItemFactory, ve.NamedClassFactory );
/* Methods */

11
modules/ve/dm/ve.dm.ModelRegistry.js
View file

@ -71,22 +71,27 @@ function addType( obj /*, ...*/ ) {
* Register a model type.
* @param {string} name Symbolic name for the model
* @param {ve.dm.Model} constructor Subclass of ve.dm.Model
* @throws Models must be subclasses of ve.dm.Model
* @throws No factory associated with this ve.dm.Model subclass
*/
ve.dm.ModelRegistry.prototype.register = function ( constructor ) {
var i, j, tags, types, name = constructor.static && constructor.static.name;
if ( typeof name !== 'string' || name === '' ) {
throw new Error( 'Model names must be strings and must not be empty' );
}
if ( !( constructor.prototype instanceof ve.dm.Model ) ) {
throw new Error( 'Models must be subclasses of ve.dm.Model' );
}
// Register the model with the right factory
if ( constructor.prototype instanceof ve.dm.Annotation ) {
ve.dm.annotationFactory.register( name, constructor );
ve.dm.annotationFactory.register( constructor );
} else if ( constructor.prototype instanceof ve.dm.Node ) {
ve.dm.nodeFactory.register( constructor );
} else if ( constructor.prototype instanceof ve.dm.MetaItem ) {
ve.dm.metaItemFactory.register( name, constructor );
ve.dm.metaItemFactory.register( constructor );
} else {
throw new Error( 'Models must be subclasses of ve.dm.Annotation, ve.dm.Node or ve.dm.MetaItem' );
throw new Error( 'No factory associated with this ve.dm.Model subclass' );
}
// Call parent implementation
ve.Registry.prototype.register.call( this, name, constructor );