From 052b039074be03aad508e37b889364374db1eef7 Mon Sep 17 00:00:00 2001 From: Zeljko Filipin Date: Tue, 11 Feb 2014 17:47:17 +0100 Subject: [PATCH] [browser test] Fix failing tests, Watir and page-object API changed Paired with Chris McMahon and Jeff Hall. Watir and page-object API changed so it is now required to specify that a frame is an iframe. Change-Id: Id269ec5bc9dc9c960fdf1f606cbc635a58659fa7 --- .../browser/features/support/pages/visual_editor_page.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb index b3f4062474..69e7346bca 100644 --- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb @@ -51,7 +51,7 @@ class VisualEditorPage div(:visual_editor_toolbar, class: "oo-ui-toolbar-tools") span(:transclusion, class: "oo-ui-iconedElement-icon oo-ui-icon-template") - in_frame(:index => 0) do |frame| + in_iframe(:index => 0) do |frame| a(:beta_warning, title: "Close", frame: frame) div(:content_box, class: "ve-ce-documentNode ve-ce-branchNode", frame: frame) span(:leftarrowclose, class: "oo-ui-iconedElement-icon oo-ui-icon-previous", frame: frame) @@ -61,7 +61,7 @@ class VisualEditorPage div(:ve_link_ui, class: "oo-ui-window-title", frame: frame) end - in_frame(:index => 1) do |frame| + in_iframe(:index => 1) do |frame| span(:add_parameter, class: "oo-ui-iconedElement-icon oo-ui-icon-parameter", frame: frame) span(:add_template, text: "Add template", frame: frame) span(:apply_changes, text: "Apply changes", frame: frame) @@ -85,7 +85,7 @@ class VisualEditorPage text_field(:transclusion_textfield, index: 0, frame: frame) end - in_frame(:index => 2) do |frame| + in_iframe(:index => 2) do |frame| div(:links_diff_view, class: "ve-ui-mwSaveDialog-viewer", frame: frame) span(:links_review_changes, class: "oo-ui-labeledElement-label", text: "Review your changes", frame: frame) div(:media_diff_view, class: "ve-ui-mwSaveDialog-viewer", frame: frame)