wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-24 22:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename stray this.refGroup usage to this.group in MWReferenceModel

Browse source 
this.refGroup is only ever read and never written, so obviously it's
always undefined. And it turns out that creating references with
listGroup='mwReference/undefined' crashes when you try to remove
them again.

Bug: 63085
Change-Id: Id326208bd6b3fe3b602ed6e3b57b7ea06d8ceb2c
This commit is contained in:
Roan Kattouw 2014-03-25 13:47:24 -07:00
parent cf56fbd0c4
commit 04f3296234
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ve-mw/dm/models/ve.dm.MWReferenceModel.js
View file

@ -83,7 +83,7 @@ ve.dm.MWReferenceModel.prototype.insertInternalItem = function ( surfaceModel )
// Fill in data
this.setListKey( 'auto/' + internalList.getNextUniqueNumber() );
this.setListGroup( 'mwReference/' + this.refGroup );
this.setListGroup( 'mwReference/' + this.group );
// Insert internal reference item into document
item = internalList.getItemInsertion( this.listGroup, this.listKey, [] );
@ -172,7 +172,7 @@ ve.dm.MWReferenceModel.prototype.insertReferenceNode = function ( surfaceModel,
'listKey': this.listKey,
'listGroup': this.listGroup,
'listIndex': this.listIndex,
'refGroup': this.refGroup
'refGroup': this.group
}
},
{ 'type': '/mwReference' }