wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-15 02:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "ve.ui.MWMediaDialog: Remove unused widget and messages"

Browse source
This commit is contained in:
jenkins-bot 2018-09-27 20:37:43 +00:00 committed by Gerrit Code Review
parent 349c2f3638 9cf5515ccb
commit 04689a37f9
4 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extension.json
View file

@ -1691,7 +1691,6 @@
"visualeditor-dialog-media-info-readmore",
"visualeditor-dialog-media-info-separator",
"visualeditor-dialog-media-info-uploaded",
"visualeditor-dialog-media-originaldimensions",
"visualeditor-dialog-media-page-advanced",
"visualeditor-dialog-media-page-general",
"visualeditor-dialog-media-position-center",
@ -1706,7 +1705,6 @@
"visualeditor-dialog-media-search-tab-search",
"visualeditor-dialog-media-search-tab-upload",
"visualeditor-dialog-media-searchselect",
"visualeditor-dialog-media-size-originalsize-error",
"visualeditor-dialog-media-size-section",
"visualeditor-dialog-media-size-section-help",
"visualeditor-dialog-media-thumbdimensions",

2
i18n/ve-mw/en.json
View file

@ -75,7 +75,6 @@
"visualeditor-dialog-media-info-separator": "·",
"visualeditor-dialog-media-info-uploaded": "Uploaded: $1",
"visualeditor-dialog-media-noresults": "No results found.",
"visualeditor-dialog-media-originaldimensions": "Original dimensions",
"visualeditor-dialog-media-page-advanced": "Advanced",
"visualeditor-dialog-media-page-general": "General",
"visualeditor-dialog-media-position-center": "Center",
@ -93,7 +92,6 @@
"visualeditor-dialog-media-size-choosecustom": "Set custom size",
"visualeditor-dialog-media-size-choosedefault": "Set to default size",
"visualeditor-dialog-media-size-choosefull": "Set to full size",
"visualeditor-dialog-media-size-originalsize-error": "Could not retrieve original file size.",
"visualeditor-dialog-media-size-section": "Image size",
"visualeditor-dialog-media-size-section-help": "You can set how large the media item appears on the page. This should almost always be the normal size, as a custom size will interfere with the layout of the page for readers and make it inconsistent.",
"visualeditor-dialog-media-thumbdimensions": "Thumbnail dimensions",

2
i18n/ve-mw/qqq.json
View file

@ -89,7 +89,6 @@
"visualeditor-dialog-media-info-separator": "Character separating information in the image info panel in the media dialog.\n{{Optional}}",
"visualeditor-dialog-media-info-uploaded": "Label for the image upload date in the media dialog. $1 - Date of last upload.\n{{Identical|Uploaded}}",
"visualeditor-dialog-media-noresults": "Label notifying the user no results were found for the media search.",
"visualeditor-dialog-media-originaldimensions": "Label for the original dimensions of the image in the media search dialog.",
"visualeditor-dialog-media-page-advanced": "Label for the advanced settings page in the media edit dialog.\n{{Identical|Advanced settings}}",
"visualeditor-dialog-media-page-general": "Label for the general settings page in the media edit dialog.\n{{Identical|General settings}}",
"visualeditor-dialog-media-position-center": "Label for the image position option for aligning to the center.\n{{Related|Visualeditor-dialog-media-position}}\n{{Identical|Center}}",
@ -107,7 +106,6 @@
"visualeditor-dialog-media-size-choosecustom": "Label for setting image size to custom dimensions.\n{{Related|Visualeditor-dialog-media-size}}",
"visualeditor-dialog-media-size-choosedefault": "Label for setting image size to wiki default thumbnail dimensions.\n{{Related|Visualeditor-dialog-media-size}}",
"visualeditor-dialog-media-size-choosefull": "Label for setting image size to full size.\n{{Related|Visualeditor-dialog-media-size}}",
"visualeditor-dialog-media-size-originalsize-error": "Error message for failing to retrieve original file size from the API.",
"visualeditor-dialog-media-size-section": "Label for the image size sub-section.\n{{Identical|Image size}}",
"visualeditor-dialog-media-size-section-help": "Message displayed as contextual help about the controls for display size to editors in the media editing dialog.",
"visualeditor-dialog-media-thumbdimensions": "Label for the original dimensions of the image in the media search dialog.",

8
modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
View file

@ -354,17 +354,12 @@ ve.ui.MWMediaDialog.prototype.initialize = function () {
help: ve.msg( 'visualeditor-dialog-media-size-section-help' )
} );
this.sizeErrorLabel = new OO.ui.LabelWidget( {
label: ve.msg( 'visualeditor-dialog-media-size-originalsize-error' )
} );
this.sizeWidget = new ve.ui.MediaSizeWidget( undefined, {
dimensionsAlign: 'top'
} );
this.$sizeWidgetElements = $( '<div>' ).append(
this.sizeWidget.$element,
this.sizeErrorLabel.$element
this.sizeWidget.$element
);
this.sizeFieldset.$element.append(
this.$sizeWidgetElements
@ -1248,7 +1243,6 @@ ve.ui.MWMediaDialog.prototype.attachImageModel = function () {
this.updateFilenameFieldset();
// Size widget
this.sizeErrorLabel.toggle( false );
this.sizeWidget.setScalable( this.imageModel.getScalable() );
this.sizeWidget.connect( this, {
changeSizeType: 'onChangeSizeType',