From 03a1d04bde66d70daf9c80f62eaaa5cf71095119 Mon Sep 17 00:00:00 2001 From: Alex Monk Date: Thu, 24 Sep 2015 22:57:50 +0100 Subject: [PATCH] Don't error when trying to re-use a reference as itself. Bug: T90476 Change-Id: I0e2cafa885f5606c4f6611529f11de4fa6f7aedf --- modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js index 2dfad31b8a..91c44e3863 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js @@ -273,7 +273,7 @@ ve.ui.MWReferenceDialog.prototype.useReference = function ( ref ) { group = this.getFragment().getDocument().getInternalList() .getNodeGroup( this.referenceModel.getListGroup() ); - if ( group && group.keyedNodes[ this.referenceModel.getListKey() ].length > 1 ) { + if ( ve.getProp( group, 'keyedNodes', this.referenceModel.getListKey(), 'length' ) > 1 ) { this.$reuseWarning.removeClass( 'oo-ui-element-hidden' ); this.$reuseWarningText.text( mw.msg( 'visualeditor-dialog-reference-editing-reused',