wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-19 04:05:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../modules/ve-mw/ui/tools/buttons/ve.ui.MWReferenceListButtonTool.js

41 lines
1.2 KiB
JavaScript
Raw Normal View History

Create ref list insertion tool Fixes (follows-up I1b48ef5240, I6daff5c596): * Invalid html passed to jQuery constructor. * Use prop() instead of attr() for boolean values. * Use append() instead of html() when appending nodes instead of parsing html. * Rename shadowed variable name clash 'mw' to 'mwData'. * Fix odd construction where we parse '{}' to create an empty object. * Have ve.ce.MWReferenceListNode#update perform changes off-document in a detached tree. * Fix deep property access that can fail. mwData is set to either JSON parse of data-mw attr or empty object. Accessing mwData.attrs.group needs to be guarded by whether mw.attrs is indeed set. * Have `mw` and `about` attribtue in references list roundtrip (especially mw which can data we aren't editing/re-creating). * Add missing 'refGroup' property to MWReferenceListNode's data element (similar to what MWReferenceNode already has). Change-Id: I67e4f378ccd04e97361d8e58ae57db5353075756
2013-06-21 02:55:16 +00:00
/*!
* VisualEditor UserInterface MWReferenceListButtonTool class.
*
* @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
* @license The MIT License (MIT); see LICENSE.txt
*/
/**
Consistency in MW*ButtonTool comments and naming Change-Id: Id71c7f862e43125599ecfc6eeb27719e1891489d
2013-07-26 11:04:19 +00:00
* UserInterface MediaWiki reference list button tool.
Create ref list insertion tool Fixes (follows-up I1b48ef5240, I6daff5c596): * Invalid html passed to jQuery constructor. * Use prop() instead of attr() for boolean values. * Use append() instead of html() when appending nodes instead of parsing html. * Rename shadowed variable name clash 'mw' to 'mwData'. * Fix odd construction where we parse '{}' to create an empty object. * Have ve.ce.MWReferenceListNode#update perform changes off-document in a detached tree. * Fix deep property access that can fail. mwData is set to either JSON parse of data-mw attr or empty object. Accessing mwData.attrs.group needs to be guarded by whether mw.attrs is indeed set. * Have `mw` and `about` attribtue in references list roundtrip (especially mw which can data we aren't editing/re-creating). * Add missing 'refGroup' property to MWReferenceListNode's data element (similar to what MWReferenceNode already has). Change-Id: I67e4f378ccd04e97361d8e58ae57db5353075756
2013-06-21 02:55:16 +00:00
*
* @class
* @extends ve.ui.DialogButtonTool
* @constructor
* @param {ve.ui.Toolbar} toolbar
* @param {Object} [config] Config options
*/
ve.ui.MWReferenceListButtonTool = function VeUiMwReferenceListButtonTool( toolbar, config ) {
// Parent constructor
ve.ui.DialogButtonTool.call( this, toolbar, config );
};
/* Inheritance */
ve.inheritClass( ve.ui.MWReferenceListButtonTool, ve.ui.DialogButtonTool );
/* Static Properties */
ve.ui.MWReferenceListButtonTool.static.name = 'mwReferenceList';
ve.ui.MWReferenceListButtonTool.static.icon = 'references';
ve.ui.MWReferenceListButtonTool.static.titleMessage = 'visualeditor-dialogbutton-referencelist-tooltip';
ve.ui.MWReferenceListButtonTool.static.dialog = 'mwReferenceList';
ve.ui.ViewRegistry annihilation Objectives: * Associate models with tools, rather than dialogs and inspectors * Move tool/model association utilities to ve.ui.ToolFactory * Obliterate the view registry Notes: The only special case for leaving modelClasses definitions in place is for the linkInspector. It uses these for selection expansion. Because tools can now override the static canEditModel method, we can dynamically evaluate a model, rather than be restricted to only comparing classes. This will be useful for disabling editors for models that are for some reason incomplete or otherwise broken and cannot be safely edited. Change-Id: I7adf254990112d90f1f808593a9111afc7a116b5
2013-06-26 21:54:51 +00:00
ve.ui.MWReferenceListButtonTool.static.modelClasses = [ ve.dm.MWReferenceListNode ];
Create ref list insertion tool Fixes (follows-up I1b48ef5240, I6daff5c596): * Invalid html passed to jQuery constructor. * Use prop() instead of attr() for boolean values. * Use append() instead of html() when appending nodes instead of parsing html. * Rename shadowed variable name clash 'mw' to 'mwData'. * Fix odd construction where we parse '{}' to create an empty object. * Have ve.ce.MWReferenceListNode#update perform changes off-document in a detached tree. * Fix deep property access that can fail. mwData is set to either JSON parse of data-mw attr or empty object. Accessing mwData.attrs.group needs to be guarded by whether mw.attrs is indeed set. * Have `mw` and `about` attribtue in references list roundtrip (especially mw which can data we aren't editing/re-creating). * Add missing 'refGroup' property to MWReferenceListNode's data element (similar to what MWReferenceNode already has). Change-Id: I67e4f378ccd04e97361d8e58ae57db5353075756
2013-06-21 02:55:16 +00:00
/* Registration */
ve.ui.toolFactory.register( 'mwReferenceList', ve.ui.MWReferenceListButtonTool );
Reference in a new issue Copy permalink