mediawiki-extensions-Visual.../modules/ve-mw/preinit/.eslintrc.json

{
	"globals": {
		"ve": "off"
	},
	"rules": {
		"no-jquery/no-deferred": "off",
		"no-jquery/no-when": "off"
	}
}
Enforce that some files must not use the `ve` global Previously, the ve-mw/init/ directory contained two kinds of files: those that were used when initializing VE, and those that may be loaded even if VE is not going to be initialized at all. The latter kind must not use the `ve` global variable. After moving those files to ve-mw/preinit/ we can enforce this with .eslintrc.json in that directory. This would have prevented T228684. (Technically they merely must not use `ve.init`, and may use `ve`, but that's harder to enforce. We should instead move the few non-init methods out of `ve`: now, track, trackSubscribe, trackSubscribeAll). Also, group some files under ve-mw/init/: targets/ now (only) contains ve.init.mw.Target and its subclasses, apiresponsecache/ now contains ve.init.mw.ApiResponseCache and its subclasses. Bug: T228684 Change-Id: I945249a27f6a0fa10a432d5c5dc57bc7e0461fd8 2019-07-22 20:33:15 +00:00			`{`
			`"globals": {`
			`"ve": "off"`
Replace $.when with ve.promiseAll Add linting guards, except in preinit Change-Id: I999641eddb0e0f5b112ec2259dbafc1e816e3437 2019-11-02 16:29:11 +00:00			`},`
			`"rules": {`
			`"no-jquery/no-deferred": "off",`
			`"no-jquery/no-when": "off"`
Enforce that some files must not use the `ve` global Previously, the ve-mw/init/ directory contained two kinds of files: those that were used when initializing VE, and those that may be loaded even if VE is not going to be initialized at all. The latter kind must not use the `ve` global variable. After moving those files to ve-mw/preinit/ we can enforce this with .eslintrc.json in that directory. This would have prevented T228684. (Technically they merely must not use `ve.init`, and may use `ve`, but that's harder to enforce. We should instead move the few non-init methods out of `ve`: now, track, trackSubscribe, trackSubscribeAll). Also, group some files under ve-mw/init/: targets/ now (only) contains ve.init.mw.Target and its subclasses, apiresponsecache/ now contains ve.init.mw.ApiResponseCache and its subclasses. Bug: T228684 Change-Id: I945249a27f6a0fa10a432d5c5dc57bc7e0461fd8 2019-07-22 20:33:15 +00:00			`}`
			`}`