mediawiki-extensions-Visual.../.jscsrc

{
	"preset": "wikimedia",

	"jsDoc": {
		"checkAnnotations": {
			"preset": "jsduck5",
			"extra": {
				"this": true,
				"source": true,
				"see": true
			}
		},
		"checkTypes": "strictNativeCase",
		"checkParamNames": true,
		"checkRedundantAccess": true,
		"checkRedundantReturns": true,
		"requireNewlineAfterDescription": true,
		"requireParamTypes": true,
		"requireReturnTypes": true
	}
}
Set up node-jscs, pass it, and configure in local Gruntfile Let's experiment with this via our local Gruntfile. If it works fine we can install it in Jenkins (similar to node-csslint). Verify through $ npm install && npm test; Fixed all outstanding violations. Also: * Added syntaxhighight to ignore. * Added imetests (which contain unformatted JSON) to ignore. * In ve.dm.ModelRegistry#matchTypeRegExps, removed redundant !! cast from the [+!!withFunc] statement which was hitting a bug in node-jscs. All callers to this local private function pass a literal boolean true/false so no need to cast it. * Removed "/* key .. , value /" from ve.setProp, though this wasn't caught by node-jscs, found it when searching for " , ". Made npm.devDependencies fixed instead of using tilde-ranges. This too often leads to strange bugs or sudden changes. Fixed them at the version they were currently ranging to. Bug: 54218 Change-Id: Ib2630806f3946874c8b01e58cf171df83a28da29 2013-12-06 02:34:44 +00:00			`{`
build: Bump jscs devDependency from 1.8.0 to 2.1.0 Change-Id: I75a99990c61d7f1f0a963f003c0e8bdb9c5215b6 2015-08-19 17:25:11 +00:00			`"preset": "wikimedia",`

build: Enable jscs jsDoc rule 'checkAnnotations' and make pass Change-Id: I76abb1eb1f3e1a2e8a4c03f577a080f4889b3a6d 2015-08-19 18:09:34 +00:00			`"jsDoc": {`
			`"checkAnnotations": {`
			`"preset": "jsduck5",`
			`"extra": {`
			`"this": true,`
			`"source": true,`
			`"see": true`
			`}`
build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass Change-Id: I7c0fabc93834d19198caea8f5dd1834e9e473d0a 2015-08-19 18:21:01 +00:00			`},`
build: Enable jscs jsDoc rule 'checkTypes' and make pass Change-Id: Idbf6e698ba7015ee5e4f1cf78234ad3f187f1c06 2015-08-19 18:37:13 +00:00			`"checkTypes": "strictNativeCase",`
build: Enable jscs jsDoc rule 'checkParamNames' and make pass Change-Id: Ifcd3f67524c32148ff3591263d6374b31ee57d3b 2015-08-19 18:33:59 +00:00			`"checkParamNames": true,`
build: Enable jscs jsDoc rules 'checkRedundant*' and make pass Change-Id: I36262ee1fe6116749586014fd30df3e00733fa6c 2015-08-19 18:35:43 +00:00			`"checkRedundantAccess": true,`
			`"checkRedundantReturns": true,`
build: Enable jscs jsDoc rules 'require*Types' and make pass Change-Id: I60c769f1cb028e4f4da7aeb04ed2383b689ddbc8 2015-08-19 18:38:35 +00:00			`"requireNewlineAfterDescription": true,`
			`"requireParamTypes": true,`
			`"requireReturnTypes": true`
build: Enable jscs jsDoc rule 'checkAnnotations' and make pass Change-Id: I76abb1eb1f3e1a2e8a4c03f577a080f4889b3a6d 2015-08-19 18:09:34 +00:00			`}`
Set up node-jscs, pass it, and configure in local Gruntfile Let's experiment with this via our local Gruntfile. If it works fine we can install it in Jenkins (similar to node-csslint). Verify through $ npm install && npm test; Fixed all outstanding violations. Also: * Added syntaxhighight to ignore. * Added imetests (which contain unformatted JSON) to ignore. * In ve.dm.ModelRegistry#matchTypeRegExps, removed redundant !! cast from the [+!!withFunc] statement which was hitting a bug in node-jscs. All callers to this local private function pass a literal boolean true/false so no need to cast it. * Removed "/* key .. , value /" from ve.setProp, though this wasn't caught by node-jscs, found it when searching for " , ". Made npm.devDependencies fixed instead of using tilde-ranges. This too often leads to strange bugs or sudden changes. Fixed them at the version they were currently ranging to. Bug: 54218 Change-Id: Ib2630806f3946874c8b01e58cf171df83a28da29 2013-12-06 02:34:44 +00:00			`}`