wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-11 22:16:15 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../modules/ve-mw/ui/widgets/ve.ui.MWTransclusionOutlineButtonWidget.js

99 lines
3.1 KiB
JavaScript
Raw Normal View History

Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
/**
Document some classes touched in the sidebar rewrite Depends-On: I385dca1d95033961d3844e888521750443e49c95 Change-Id: Ic515b41863bcf2ac4daa0272f67e1d30238a4b85
2022-07-12 09:55:54 +00:00
* Generic button-like widget for top-level parts in the template dialog
* sidebar. See {@see OO.ui.ButtonWidget} for inspiration.
Make new template editor sidebar items actual ButtonElements Actually reusing this OOUI mixin gives us a lot of well developed functionality we need anyway. Most notably proper event management, e.g. click events. The number of CSS properties we need to override is managable, I would argue. Let's see: * Our buttons are not inline-elements, but should use the full width. * No focus-border left and right for the same reason. * We want much more inner padding. * We want a stronger hover effect. * We need to fine-tune the position of the icon. This is because of the inner padding. * Need to get rid of a negative margin that's only relevant for inline-buttons. I currently feel like the benefits are worth living with slightly more brittle code. Note that we can undo this change any time because all this is well encapsulated in this new class. Bug: T274544 Change-Id: I33f275a958964d49e803e56bf74a6fa961093da1
2021-07-13 10:15:47 +00:00
*
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
* @class
Allow selecting top-level parts in the new sidebar This is mostly, if not exclusively visual, at the moment. The actual state is still managed by the old sidebar. I made the element OptionWidgets for convenience. This gives us all the functionality we need (primarily setSelected and isSelected), without to much clutter. However, I didn't made the container a SelectWidget. This comes with to much stuff we don't need at this level, e.g. cursor key navigation. Bug: T285323 Bug: T289043 Change-Id: I20dbd2ba23ceaa9125947b25e037c0bb3c91a471
2021-08-27 16:22:37 +00:00
* @extends OO.ui.OptionWidget
JSDoc: @mixins -> @mixes Change-Id: Ic06b8e058b387f8d683db6273f689694cf416ce6
2024-04-29 17:51:41 +00:00
* @mixes OO.ui.mixin.ButtonElement
* @mixes OO.ui.mixin.IconElement
* @mixes OO.ui.mixin.TabIndexedElement
* @mixes ve.ui.MWAriaDescribe
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
*
* @constructor
* @param {Object} config
Update and fix all `@param config` and `@cfg` documentation I tried to review all of them. Some of the changes I did: * Make sure the `config` parameter is not marked as optional when it is not. * Make sure default values are mentioned. * List individual `@cfg` options when it makes sense. Note I don't list all options a class could accept (e.g. via all its parent classes and mixins). That's too much. Instead I checked how a class is actually used and list only these options. Even then I don't list everything, e.g. unspecific options like "classes" that can be used pretty much everywhere. Change-Id: Idf4fbe1dc3608ace277df9e385f2f140df3a2f50
2021-09-11 08:05:31 +00:00
* @cfg {string} [icon=''] Symbolic name of an icon, e.g. "puzzle" or "wikiText"
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
* @cfg {string} label
*/
ve.ui.MWTransclusionOutlineButtonWidget = function VeUiMWTransclusionOutlineButtonWidget( config ) {
// Parent constructor
Use OOUI 'classes' property instead of .addClass() The 'classes' property is a OOUI interface. Personally, I like this code style better. However. It appears like the code style in this codebase is somewhat mixed. It looks like the top-level .$element always uses .addClass(), while other code uses the 'classes' property. Should we unify this? Change-Id: I9ecd75e22d00f06ffd707f766dc9e8d748ff9a37
2021-09-10 19:18:59 +00:00
ve.ui.MWTransclusionOutlineButtonWidget.super.call( this, ve.extendObject( config, {
classes: [ 've-ui-mwTransclusionOutlineButtonWidget' ]
} ) );
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
// Mixin constructors
Make new template editor sidebar items actual ButtonElements Actually reusing this OOUI mixin gives us a lot of well developed functionality we need anyway. Most notably proper event management, e.g. click events. The number of CSS properties we need to override is managable, I would argue. Let's see: * Our buttons are not inline-elements, but should use the full width. * No focus-border left and right for the same reason. * We want much more inner padding. * We want a stronger hover effect. * We need to fine-tune the position of the icon. This is because of the inner padding. * Need to get rid of a negative margin that's only relevant for inline-buttons. I currently feel like the benefits are worth living with slightly more brittle code. Note that we can undo this change any time because all this is well encapsulated in this new class. Bug: T274544 Change-Id: I33f275a958964d49e803e56bf74a6fa961093da1
2021-07-13 10:15:47 +00:00
OO.ui.mixin.ButtonElement.call( this, {
Use <span> for the outline part headers We're mainly interested in the layout of a button here. From a semantic perspective this is just a header to an editable area and not a button. Bug: T291284 Change-Id: I683cca2e7d6549e652bd03ae1e46f4eff8c07d0a
2021-10-22 14:00:19 +00:00
// FIXME semantically this could be a <legend> and the surrounding OutlinePartWidget a <fieldset>
$button: $( '<span>' ),
Make new template editor sidebar items actual ButtonElements Actually reusing this OOUI mixin gives us a lot of well developed functionality we need anyway. Most notably proper event management, e.g. click events. The number of CSS properties we need to override is managable, I would argue. Let's see: * Our buttons are not inline-elements, but should use the full width. * No focus-border left and right for the same reason. * We want much more inner padding. * We want a stronger hover effect. * We need to fine-tune the position of the icon. This is because of the inner padding. * Need to get rid of a negative margin that's only relevant for inline-buttons. I currently feel like the benefits are worth living with slightly more brittle code. Note that we can undo this change any time because all this is well encapsulated in this new class. Bug: T274544 Change-Id: I33f275a958964d49e803e56bf74a6fa961093da1
2021-07-13 10:15:47 +00:00
framed: false
} );
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
OO.ui.mixin.IconElement.call( this, config );
Finishing touches to new template editor sidebar In detail: * Allow clicks on all elements in the new sidebar. This should focus the corresponding element on the right. * Make all elements in the new sidebar tabbable. * Fix MWTransclusionOutlineTemplateWidget.createCheckbox() to not need a temporary param object any more. * Rewrite more code in MWTransclusionOutlineTemplateWidget to be shorter and easier to read. * Fix MWTemplateModel.addParameter() to not do way to much stuff when a parameter already exists. * Update code documentation. * Use more specific, less ambiguous variable and method names. Bug: T274544 Change-Id: Iaf6f7d1b0f7bf0e9b03eb86d01f3eceadece6fe4
2021-07-13 19:01:30 +00:00
OO.ui.mixin.TabIndexedElement.call( this, ve.extendObject( {
$tabIndexed: this.$button
}, config ) );
Make better use of the ARIA mixin Bug: T295353 Change-Id: I7ccb1e771516df8198c6e07cbf37e9739bc0ed71
2021-11-16 11:00:12 +00:00
ve.ui.MWAriaDescribe.call( this, {
ariaLabel: config.label,
$describedElement: this.$button
} );
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
Set selected status to sidebar elements ARIA-selected only works on specific elements/roles. I tried several combinations here, the most fitting seemed to be the option role, but that role did not work very well in FF with NVDA. It also should only be used as direct child to a listbox e.g. with several children. The next role that's working with ARIA-selected that seemed fitting is the gridcell. It's still a bit hacky but works well in IE and FF with NVDA. I suspect that that's pretty good coverage already then. Bug: T291284 Change-Id: I85c865b0ab12d3923e472e5f36b5c07b7c722180
2021-10-27 09:58:51 +00:00
// FIXME hack for screen readers to understand the selection state
this.$button.attr( {
role: 'gridcell',
'aria-selected': 'false'
} );
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
this.$element
Make new template editor sidebar items actual ButtonElements Actually reusing this OOUI mixin gives us a lot of well developed functionality we need anyway. Most notably proper event management, e.g. click events. The number of CSS properties we need to override is managable, I would argue. Let's see: * Our buttons are not inline-elements, but should use the full width. * No focus-border left and right for the same reason. * We want much more inner padding. * We want a stronger hover effect. * We need to fine-tune the position of the icon. This is because of the inner padding. * Need to get rid of a negative margin that's only relevant for inline-buttons. I currently feel like the benefits are worth living with slightly more brittle code. Note that we can undo this change any time because all this is well encapsulated in this new class. Bug: T274544 Change-Id: I33f275a958964d49e803e56bf74a6fa961093da1
2021-07-13 10:15:47 +00:00
.append( this.$button.append( this.$icon, this.$label ) );
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
};
/* Inheritance */
Allow selecting top-level parts in the new sidebar This is mostly, if not exclusively visual, at the moment. The actual state is still managed by the old sidebar. I made the element OptionWidgets for convenience. This gives us all the functionality we need (primarily setSelected and isSelected), without to much clutter. However, I didn't made the container a SelectWidget. This comes with to much stuff we don't need at this level, e.g. cursor key navigation. Bug: T285323 Bug: T289043 Change-Id: I20dbd2ba23ceaa9125947b25e037c0bb3c91a471
2021-08-27 16:22:37 +00:00
OO.inheritClass( ve.ui.MWTransclusionOutlineButtonWidget, OO.ui.OptionWidget );
Make new template editor sidebar items actual ButtonElements Actually reusing this OOUI mixin gives us a lot of well developed functionality we need anyway. Most notably proper event management, e.g. click events. The number of CSS properties we need to override is managable, I would argue. Let's see: * Our buttons are not inline-elements, but should use the full width. * No focus-border left and right for the same reason. * We want much more inner padding. * We want a stronger hover effect. * We need to fine-tune the position of the icon. This is because of the inner padding. * Need to get rid of a negative margin that's only relevant for inline-buttons. I currently feel like the benefits are worth living with slightly more brittle code. Note that we can undo this change any time because all this is well encapsulated in this new class. Bug: T274544 Change-Id: I33f275a958964d49e803e56bf74a6fa961093da1
2021-07-13 10:15:47 +00:00
OO.mixinClass( ve.ui.MWTransclusionOutlineButtonWidget, OO.ui.mixin.ButtonElement );
Reuse generic button widget for elements in the new sidebar This introduces another generic "button-like" class that can be reused in multiple places in the new sidebar. The main change in this patch is the "add more information" button which is now an instance of this new class as well. This patch also simplifies over-complicated setup code in related widgets. Bug: T274544 Change-Id: I0cfe7675d02fdd5c5dc8d9198bb3f4aec9abf397
2021-07-13 09:00:57 +00:00
OO.mixinClass( ve.ui.MWTransclusionOutlineButtonWidget, OO.ui.mixin.IconElement );
Finishing touches to new template editor sidebar In detail: * Allow clicks on all elements in the new sidebar. This should focus the corresponding element on the right. * Make all elements in the new sidebar tabbable. * Fix MWTransclusionOutlineTemplateWidget.createCheckbox() to not need a temporary param object any more. * Rewrite more code in MWTransclusionOutlineTemplateWidget to be shorter and easier to read. * Fix MWTemplateModel.addParameter() to not do way to much stuff when a parameter already exists. * Update code documentation. * Use more specific, less ambiguous variable and method names. Bug: T274544 Change-Id: Iaf6f7d1b0f7bf0e9b03eb86d01f3eceadece6fe4
2021-07-13 19:01:30 +00:00
OO.mixinClass( ve.ui.MWTransclusionOutlineButtonWidget, OO.ui.mixin.TabIndexedElement );
Make better use of the ARIA mixin Bug: T295353 Change-Id: I7ccb1e771516df8198c6e07cbf37e9739bc0ed71
2021-11-16 11:00:12 +00:00
OO.mixinClass( ve.ui.MWTransclusionOutlineButtonWidget, ve.ui.MWAriaDescribe );
Allow selecting top-level parts in the new sidebar This is mostly, if not exclusively visual, at the moment. The actual state is still managed by the old sidebar. I made the element OptionWidgets for convenience. This gives us all the functionality we need (primarily setSelected and isSelected), without to much clutter. However, I didn't made the container a SelectWidget. This comes with to much stuff we don't need at this level, e.g. cursor key navigation. Bug: T285323 Bug: T289043 Change-Id: I20dbd2ba23ceaa9125947b25e037c0bb3c91a471
2021-08-27 16:22:37 +00:00
ve.ui.MWTransclusionOutlineButtonWidget.static.highlightable = false;
ve.ui.MWTransclusionOutlineButtonWidget.static.pressable = false;
Fix space bar on top-level template parts loosing focus As a reminder (not part of this patch): Pressing enter on the name of a template should select it, and jump to the content area on the right. Pressing space (that's what this patch is about) should select as well, but not move the focus. The best way to test the behavior is with a multi-part template. Bug: T285323 Bug: T289043 Change-Id: I97d77f43b231696f92ba6758a6b8feac34e02e6d
2021-09-02 16:09:30 +00:00
/* Events */
/**
docs: Replace JSDuck with JSDoc (and pull-through VE with said change) This is not great, but it's a start (and unblocks other pull-throughs). New changes: c401efc98 build: Replace jsduck with jsdoc for documentation 16ba162a0 JSDoc: @mixins -> @mixes 9e0a1f53b JSDoc: Fix complex return types 449b6cc0f Prefer arrow function callbacks 1539af2c8 Remove 'this' bindings in arrow functions b760f3b14 Use arrow functions in OO.ui.Process steps 57c24109e Use arrow functions in jQuery callbacks 9622ccef9 Convert some remaining functions callbacks to arrow functions f6c885021 Remove useless local variable 1cd800020 Clear branch node cache when rebuilding tree Bug: T250843 Bug: T363329 Change-Id: I0f4878ca84b95e3f388b358b943f105637e455f9
2024-04-29 11:52:40 +00:00
* @event ve.ui.MWTransclusionOutlineButtonWidget#keyPressed
Implement basic Ctrl+Shift+Up/Down/Del support in new sidebar Note this patch is somewhat incomplete. The feature fully works and I would like to see this patch merged as it is. But whenever you press one of the keys the focus is stolen by some element on the right side of the dialog. This makes it impossible to e.g. press Ctrl+Shift+Down multiple times. The idea is to work on this in the next patch. Bug: T290262 Change-Id: Ic67f2a696c94f1e5c71134d681161221aecbfdf6
2021-09-22 09:49:44 +00:00
* @param {number} key Typically one of the {@see OO.ui.Keys} constants
Fix space bar on top-level template parts loosing focus As a reminder (not part of this patch): Pressing enter on the name of a template should select it, and jump to the content area on the right. Pressing space (that's what this patch is about) should select as well, but not move the focus. The best way to test the behavior is with a multi-part template. Bug: T285323 Bug: T289043 Change-Id: I97d77f43b231696f92ba6758a6b8feac34e02e6d
2021-09-02 16:09:30 +00:00
*/
/**
* @inheritDoc OO.ui.mixin.ButtonElement
Implement basic Ctrl+Shift+Up/Down/Del support in new sidebar Note this patch is somewhat incomplete. The feature fully works and I would like to see this patch merged as it is. But whenever you press one of the keys the focus is stolen by some element on the right side of the dialog. This makes it impossible to e.g. press Ctrl+Shift+Down multiple times. The idea is to work on this in the next patch. Bug: T290262 Change-Id: Ic67f2a696c94f1e5c71134d681161221aecbfdf6
2021-09-22 09:49:44 +00:00
* @param {jQuery.Event} e
JSDoc: Fix event documentation and complex return types Change-Id: I5dbce39294a34a999303ccfec88261d8c92b17ca
2024-04-29 18:14:26 +00:00
* @fires ve.ui.MWTransclusionOutlineButtonWidget#keyPressed
Fix space bar on top-level template parts loosing focus As a reminder (not part of this patch): Pressing enter on the name of a template should select it, and jump to the content area on the right. Pressing space (that's what this patch is about) should select as well, but not move the focus. The best way to test the behavior is with a multi-part template. Bug: T285323 Bug: T289043 Change-Id: I97d77f43b231696f92ba6758a6b8feac34e02e6d
2021-09-02 16:09:30 +00:00
*/
Implement basic Ctrl+Shift+Up/Down/Del support in new sidebar Note this patch is somewhat incomplete. The feature fully works and I would like to see this patch merged as it is. But whenever you press one of the keys the focus is stolen by some element on the right side of the dialog. This makes it impossible to e.g. press Ctrl+Shift+Down multiple times. The idea is to work on this in the next patch. Bug: T290262 Change-Id: Ic67f2a696c94f1e5c71134d681161221aecbfdf6
2021-09-22 09:49:44 +00:00
ve.ui.MWTransclusionOutlineButtonWidget.prototype.onKeyDown = function ( e ) {
Exclusively use CMD instead of CTRL for shortcuts on MacOS Bug: T294519 Change-Id: I8bd803b4a81ed5195ff0bb1b99b14f764d588eca
2021-10-28 09:51:18 +00:00
var isMac = ve.getSystemPlatform() === 'mac';
var withMetaKey = isMac ? e.metaKey : e.ctrlKey;
Implement basic Ctrl+Shift+Up/Down/Del support in new sidebar Note this patch is somewhat incomplete. The feature fully works and I would like to see this patch merged as it is. But whenever you press one of the keys the focus is stolen by some element on the right side of the dialog. This makes it impossible to e.g. press Ctrl+Shift+Down multiple times. The idea is to work on this in the next patch. Bug: T290262 Change-Id: Ic67f2a696c94f1e5c71134d681161221aecbfdf6
2021-09-22 09:49:44 +00:00
if ( e.which === OO.ui.Keys.SPACE &&
!withMetaKey && !e.shiftKey && !e.altKey
) {
Fix space bar on top-level template parts loosing focus As a reminder (not part of this patch): Pressing enter on the name of a template should select it, and jump to the content area on the right. Pressing space (that's what this patch is about) should select as well, but not move the focus. The best way to test the behavior is with a multi-part template. Bug: T285323 Bug: T289043 Change-Id: I97d77f43b231696f92ba6758a6b8feac34e02e6d
2021-09-02 16:09:30 +00:00
// We know we can only select another part, so don't even try to unselect this one
if ( !this.isSelected() ) {
Implement basic Ctrl+Shift+Up/Down/Del support in new sidebar Note this patch is somewhat incomplete. The feature fully works and I would like to see this patch merged as it is. But whenever you press one of the keys the focus is stolen by some element on the right side of the dialog. This makes it impossible to e.g. press Ctrl+Shift+Down multiple times. The idea is to work on this in the next patch. Bug: T290262 Change-Id: Ic67f2a696c94f1e5c71134d681161221aecbfdf6
2021-09-22 09:49:44 +00:00
this.emit( 'keyPressed', e.which );
Fix space bar on top-level template parts loosing focus As a reminder (not part of this patch): Pressing enter on the name of a template should select it, and jump to the content area on the right. Pressing space (that's what this patch is about) should select as well, but not move the focus. The best way to test the behavior is with a multi-part template. Bug: T285323 Bug: T289043 Change-Id: I97d77f43b231696f92ba6758a6b8feac34e02e6d
2021-09-02 16:09:30 +00:00
}
Implement basic Ctrl+Shift+Up/Down/Del support in new sidebar Note this patch is somewhat incomplete. The feature fully works and I would like to see this patch merged as it is. But whenever you press one of the keys the focus is stolen by some element on the right side of the dialog. This makes it impossible to e.g. press Ctrl+Shift+Down multiple times. The idea is to work on this in the next patch. Bug: T290262 Change-Id: Ic67f2a696c94f1e5c71134d681161221aecbfdf6
2021-09-22 09:49:44 +00:00
// The default behavior of pressing space is to scroll down
e.preventDefault();
return;
Fix space bar on top-level template parts loosing focus As a reminder (not part of this patch): Pressing enter on the name of a template should select it, and jump to the content area on the right. Pressing space (that's what this patch is about) should select as well, but not move the focus. The best way to test the behavior is with a multi-part template. Bug: T285323 Bug: T289043 Change-Id: I97d77f43b231696f92ba6758a6b8feac34e02e6d
2021-09-02 16:09:30 +00:00
}
Implement basic Ctrl+Shift+Up/Down/Del support in new sidebar Note this patch is somewhat incomplete. The feature fully works and I would like to see this patch merged as it is. But whenever you press one of the keys the focus is stolen by some element on the right side of the dialog. This makes it impossible to e.g. press Ctrl+Shift+Down multiple times. The idea is to work on this in the next patch. Bug: T290262 Change-Id: Ic67f2a696c94f1e5c71134d681161221aecbfdf6
2021-09-22 09:49:44 +00:00
return OO.ui.mixin.ButtonElement.prototype.onKeyDown.call( this, e );
Fix space bar on top-level template parts loosing focus As a reminder (not part of this patch): Pressing enter on the name of a template should select it, and jump to the content area on the right. Pressing space (that's what this patch is about) should select as well, but not move the focus. The best way to test the behavior is with a multi-part template. Bug: T285323 Bug: T289043 Change-Id: I97d77f43b231696f92ba6758a6b8feac34e02e6d
2021-09-02 16:09:30 +00:00
};
Set selected status to sidebar elements ARIA-selected only works on specific elements/roles. I tried several combinations here, the most fitting seemed to be the option role, but that role did not work very well in FF with NVDA. It also should only be used as direct child to a listbox e.g. with several children. The next role that's working with ARIA-selected that seemed fitting is the gridcell. It's still a bit hacky but works well in IE and FF with NVDA. I suspect that that's pretty good coverage already then. Bug: T291284 Change-Id: I85c865b0ab12d3923e472e5f36b5c07b7c722180
2021-10-27 09:58:51 +00:00
/**
* @inheritDoc
*/
ve.ui.MWTransclusionOutlineButtonWidget.prototype.setSelected = function ( state ) {
if ( this.$button ) {
this.$button.attr( 'aria-selected', state.toString() );
}
return ve.ui.MWTransclusionOutlineButtonWidget.super.prototype.setSelected.call( this, state );
};
Reference in a new issue Copy permalink