mediawiki-extensions-Visual.../modules/ve/ui/ve.ui.Tool.js

44 lines
979 B
JavaScript
Raw Normal View History

/**
* VisualEditor user interface Tool class.
*
* @copyright 2011-2012 VisualEditor Team and others; see AUTHORS.txt
* @license The MIT License (MIT); see LICENSE.txt
*/
2011-12-05 21:10:19 +00:00
/**
* Creates an ve.ui.Tool object.
*
2011-12-05 21:10:19 +00:00
* @class
Object management: Object create/inherit/clone utilities * For the most common case: - replace ve.extendClass with ve.inheritClass (chose slightly different names to detect usage of the old/new one, and I like 'inherit' better). - move it up to below the constructor, see doc block for why. * Cases where more than 2 arguments were passed to ve.extendClass are handled differently depending on the case. In case of a longer inheritance tree, the other arguments could be omitted (like in "ve.ce.FooBar, ve.FooBar, ve.Bar". ve.ce.FooBar only needs to inherit from ve.FooBar, because ve.ce.FooBar inherits from ve.Bar). In the case of where it previously had two mixins with ve.extendClass(), either one becomes inheritClass and one a mixin, both to mixinClass(). No visible changes should come from this commit as the instances still all have the same visible properties in the end. No more or less than before. * Misc.: - Be consistent in calling parent constructors in the same order as the inheritance. - Add missing @extends and @param documentation. - Replace invalid {Integer} type hint with {Number}. - Consistent doc comments order: @class, @abstract, @constructor, @extends, @params. - Fix indentation errors A fairly common mistake was a superfluous space before the identifier on the assignment line directly below the documentation comment. $ ack "^ [^*]" --js modules/ve - Typo "Inhertiance" -> "Inheritance". - Replacing the other confusing comment "Inheritance" (inside the constructor) with "Parent constructor". - Add missing @abstract for ve.ui.Tool. - Corrected ve.FormatDropdownTool to ve.ui.FormatDropdownTool.js - Add function names to all @constructor functions. Now that we have inheritance it is important and useful to have these functions not be anonymous. Example of debug shot: http://cl.ly/image/1j3c160w3D45 Makes the difference between < documentNode; > ve_dm_DocumentNode ... : ve_dm_BranchNode ... : ve_dm_Node ... : ve_dm_Node ... : Object ... without names (current situation): < documentNode; > Object ... : Object ... : Object ... : Object ... : Object ... though before this commit, it really looks like this (flattened since ve.extendClass really did a mixin): < documentNode; > Object ... ... ... Pattern in Sublime (case-sensitive) to find nameless constructor functions: "^ve\..*\.([A-Z])([^\.]+) = function \(" Change-Id: Iab763954fb8cf375900d7a9a92dec1c755d5407e
2012-09-05 06:07:47 +00:00
* @abstract
2011-12-05 21:10:19 +00:00
* @constructor
* @param {ve.ui.Toolbar} toolbar
2011-12-05 21:10:19 +00:00
* @param {String} name
*/
ve.ui.Tool = function VeUiTool( toolbar, name, title ) {
// Properties
2011-12-04 02:59:53 +00:00
this.toolbar = toolbar;
this.name = name;
this.title = title;
this.$ = $( '<div class="ve-ui-tool"></div>' ).attr( 'title', this.title );
// Events
this.toolbar.addListenerMethods( this, {
'updateState': 'onUpdateState',
'clearState': 'onClearState'
} );
2011-12-04 02:59:53 +00:00
};
2011-12-05 21:10:19 +00:00
/* Static Members */
ve.ui.Tool.tools = {};
2011-12-05 21:10:19 +00:00
/* Methods */
ve.ui.Tool.prototype.onUpdateState = function () {
throw new Error( 'Tool.onUpdateState not implemented in this subclass:' + this.constructor );
2011-12-04 02:59:53 +00:00
};
ve.ui.Tool.prototype.onClearState = function () {
this.$.removeClass( 've-ui-toolbarButtonTool-down' );
};