This website requires JavaScript.
Explore
Help
Register
Sign In
wikimedia
/
mediawiki-extensions-VisualEditor
Watch
1
Star
0
Fork
You've already forked mediawiki-extensions-VisualEditor
0
mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor
synced
2024-11-14 10:04:52 +00:00
Code
Issues
Packages
Projects
Releases
Wiki
Activity
96aa5c9145
mediawiki-extensions-Visual...
/
.jscsrc
6 lines
71 B
Plaintext
Raw
Normal View
History
Unescape
Escape
Set up node-jscs, pass it, and configure in local Gruntfile Let's experiment with this via our local Gruntfile. If it works fine we can install it in Jenkins (similar to node-csslint). Verify through $ npm install && npm test; Fixed all outstanding violations. Also: * Added syntaxhighight to ignore. * Added imetests (which contain unformatted JSON) to ignore. * In ve.dm.ModelRegistry#matchTypeRegExps, removed redundant !! cast from the [+!!withFunc] statement which was hitting a bug in node-jscs. All callers to this local private function pass a literal boolean true/false so no need to cast it. * Removed "/* key .. , value */" from ve.setProp, though this wasn't caught by node-jscs, found it when searching for " , ". * Made npm.devDependencies fixed instead of using tilde-ranges. This too often leads to strange bugs or sudden changes. Fixed them at the version they were currently ranging to. Bug: 54218 Change-Id: Ib2630806f3946874c8b01e58cf171df83a28da29
2013-12-06 02:34:44 +00:00
{
build: Update jscs and use new "wikimedia" preset Our coding style has been upstreamed and first released in node-jscs v1.5.0 (grunt-jscs-checker v0.6.0). Change-Id: Ifc0cfc7177946b9d11407f60e38b0177883724c5
2014-06-26 10:41:18 +00:00
"preset": "wikimedia",
build: Enforce disallowMixedSpacesAndTabs jscs rule Also, fix @returns comments (should be @return) and remove unnecessary @method comments from the documentation. Change-Id: Icd303626ac745c7ab5bff164f9b8cac276de1523
2015-03-07 04:43:53 +00:00
"requireSpacesInsideArrayBrackets": null
Set up node-jscs, pass it, and configure in local Gruntfile Let's experiment with this via our local Gruntfile. If it works fine we can install it in Jenkins (similar to node-csslint). Verify through $ npm install && npm test; Fixed all outstanding violations. Also: * Added syntaxhighight to ignore. * Added imetests (which contain unformatted JSON) to ignore. * In ve.dm.ModelRegistry#matchTypeRegExps, removed redundant !! cast from the [+!!withFunc] statement which was hitting a bug in node-jscs. All callers to this local private function pass a literal boolean true/false so no need to cast it. * Removed "/* key .. , value */" from ve.setProp, though this wasn't caught by node-jscs, found it when searching for " , ". * Made npm.devDependencies fixed instead of using tilde-ranges. This too often leads to strange bugs or sudden changes. Fixed them at the version they were currently ranging to. Bug: 54218 Change-Id: Ib2630806f3946874c8b01e58cf171df83a28da29
2013-12-06 02:34:44 +00:00
}
Reference in a new issue
Copy permalink