wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-12-01 17:36:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../modules/ve/test/ce/nodes/ve.ce.TextNode.test.js

288 lines
6.4 KiB
JavaScript
Raw Normal View History

Changed to use MIT license per agreement with the VisualEditor team This license change is aimed at maximizing the reusability of this code in other projects. VisualEditor is more than just an awesome editor for MediaWiki, it's the new editor for the entire internet. Added license and author files, plus mentions of the license to all VisualEditor PHP, JavaScript and CSS files. Parser files have not been modified but are effectively re-licensed since there's no overriding license information. 3rd party libraries are not changed, but are all already MIT licensed. Change-Id: I895b256325db7c8689756edab34523de4418b0f2
2012-07-19 00:11:26 +00:00
/**
* VisualEditor content editable TextNode tests.
Removed some whitespace And added a license to some files that didn't have it yet Change-Id: I3a7e60374d1198d369a0475b8f65f7415012a337
2012-07-19 21:25:16 +00:00
*
Changed to use MIT license per agreement with the VisualEditor team This license change is aimed at maximizing the reusability of this code in other projects. VisualEditor is more than just an awesome editor for MediaWiki, it's the new editor for the entire internet. Added license and author files, plus mentions of the license to all VisualEditor PHP, JavaScript and CSS files. Parser files have not been modified but are effectively re-licensed since there's no overriding license information. 3rd party libraries are not changed, but are all already MIT licensed. Change-Id: I895b256325db7c8689756edab34523de4418b0f2
2012-07-19 00:11:26 +00:00
* @copyright 2011-2012 VisualEditor Team and others; see AUTHORS.txt
* @license The MIT License (MIT); see LICENSE.txt
*/
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
Kranitor #1: On-boarding '''Kranitor commits''' are commits by Krinkle with his janitor hat on. Must never contain functional changes mixed with miscellaneous changes. .gitignore: * Add .DS_Store to the ignore list so that browsing the directories on Mac OS X, will not add these files to the list of untracked files. * Fix missing newline at end of file .jshintrc * raises -> throws * +module (QUnit.module) * remove 'Node' (as of node-jshint 1.7.2 this is now part of 'browser:true', as it should be) Authors: * Adding myself MWExtension/VisualEditor.php * Fix default value of wgVisualEditorParsoidURL to not point to the experimental instance in WMF Labs. Issues: * ve.ce.TextNode: - Fix TODO: Don't perform a useless clone of an already-jQuerified object. - Use .html() to set html content instead of encapsulating between two strings. This is slightly faster but more importantly safer, and prevents situations where the resulting jQuery collection actually contains 2 elements instead of 1, thus messing up what .contents() is iterating over. * ve.ce.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Transaction.test.js - Fix: ReferenceError: assert is not defined * ve.dm.TransactionProcessor.test.js - Fix: ReferenceError: assert is not defined * ext.visualEditor.viewPageTarget - Missing dependency on 'mediawiki.Title' Code conventions / Misc cleanup * Various JSHint warnings. * Whitespace * jQuery(): Use '<tag>' for element creation, use '<valid><xml/></valid>' for parsing * Use the default operator instead of ternary when the condition and first value are the same. x = foo ? foo : bar; -> x = foo || bar; Because contrary to some programming language (PHP...), in JS the default operator does not enforce a boolean result but returns the original value, hence it being called the 'default' operator, as opposed to the 'or' operator. * No need to call addClass() twice, it takes a space-separated list (jQuery splits by space and adds if needed) * Use .on( event[, selector], fn ) instead of the deprecated routers to it such as .bind(), .delegate() and .live(). All these three are now built-in and fully compatible with .on() * Add 'XXX:' comments for suspicious code that I don't want to change as part of a clean up commit. * Remove unused variables (several var x = this; where x was not used anywhere, possibly from boilerplate copy/paste) * Follows-up Trevor's commit that converts test suites to the new QUnit format. Also removed the globals since we no longer use those any more. Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f
2012-07-27 08:43:33 +00:00
QUnit.module( 've.ce.TextNode' );
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
/* Tests */
Kranitor #1: On-boarding '''Kranitor commits''' are commits by Krinkle with his janitor hat on. Must never contain functional changes mixed with miscellaneous changes. .gitignore: * Add .DS_Store to the ignore list so that browsing the directories on Mac OS X, will not add these files to the list of untracked files. * Fix missing newline at end of file .jshintrc * raises -> throws * +module (QUnit.module) * remove 'Node' (as of node-jshint 1.7.2 this is now part of 'browser:true', as it should be) Authors: * Adding myself MWExtension/VisualEditor.php * Fix default value of wgVisualEditorParsoidURL to not point to the experimental instance in WMF Labs. Issues: * ve.ce.TextNode: - Fix TODO: Don't perform a useless clone of an already-jQuerified object. - Use .html() to set html content instead of encapsulating between two strings. This is slightly faster but more importantly safer, and prevents situations where the resulting jQuery collection actually contains 2 elements instead of 1, thus messing up what .contents() is iterating over. * ve.ce.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Transaction.test.js - Fix: ReferenceError: assert is not defined * ve.dm.TransactionProcessor.test.js - Fix: ReferenceError: assert is not defined * ext.visualEditor.viewPageTarget - Missing dependency on 'mediawiki.Title' Code conventions / Misc cleanup * Various JSHint warnings. * Whitespace * jQuery(): Use '<tag>' for element creation, use '<valid><xml/></valid>' for parsing * Use the default operator instead of ternary when the condition and first value are the same. x = foo ? foo : bar; -> x = foo || bar; Because contrary to some programming language (PHP...), in JS the default operator does not enforce a boolean result but returns the original value, hence it being called the 'default' operator, as opposed to the 'or' operator. * No need to call addClass() twice, it takes a space-separated list (jQuery splits by space and adds if needed) * Use .on( event[, selector], fn ) instead of the deprecated routers to it such as .bind(), .delegate() and .live(). All these three are now built-in and fully compatible with .on() * Add 'XXX:' comments for suspicious code that I don't want to change as part of a clean up commit. * Remove unused variables (several var x = this; where x was not used anywhere, possibly from boilerplate copy/paste) * Follows-up Trevor's commit that converts test suites to the new QUnit format. Also removed the globals since we no longer use those any more. Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f
2012-07-27 08:43:33 +00:00
QUnit.test( 'getHtml', 22, function ( assert ) {
var i, len, cases;
cases = [
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
{
'data': [
{ 'type': 'paragraph' },
'a',
'b',
'c',
{ 'type': '/paragraph' }
],
'html': 'abc'
},
{
'data': [
{ 'type': 'paragraph' },
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['a', [ { 'type': 'textStyle/bold' } ]],
['b', [ { 'type': 'textStyle/bold' } ]],
['c', [ { 'type': 'textStyle/bold' } ]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
{ 'type': '/paragraph' }
],
'html': '<b>abc</b>'
},
{
'data': [
{ 'type': 'paragraph' },
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['a', [ { 'type': 'textStyle/bold' } ]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
'b',
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['c', [ { 'type': 'textStyle/italic' } ]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
{ 'type': '/paragraph' }
],
'html': '<b>a</b>b<i>c</i>'
},
{
'data': [
{ 'type': 'paragraph' },
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['a', [
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
['b', [
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
['c', [
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
{ 'type': '/paragraph' }
],
'html': '<b><i><u>abc</u></i></b>'
},
{
'data': [
{ 'type': 'paragraph' },
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['a', [
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
['b', [
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' }
]],
['c', [
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' }
]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
{ 'type': '/paragraph' }
],
'html': '<b><i><u>abc</u></i></b>'
},
{
'data': [
{ 'type': 'paragraph' },
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['a', [
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
'b',
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['c', [
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' }
]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
{ 'type': '/paragraph' }
],
'html': '<b><i><u>a</u></i></b>b<u><b><i>c</i></b></u>'
},
{
'data': [
{ 'type': 'paragraph' },
'a',
'b',
'c',
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['d', [
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
['e', [
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' }
]],
['f', [
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' }
]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
'g',
'h',
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
'i',
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
{ 'type': '/paragraph' }
],
'html': 'abc<b><i><u>def</u></i></b>ghi'
},
{
'data': [
{ 'type': 'paragraph' },
'a',
'b',
'c',
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['d', [
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
['e', [
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
['f', [
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' }
]],
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
'g',
'h',
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
'i',
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
{ 'type': '/paragraph' }
],
'html': 'abc<b><i><u>d</u></i></b><i><u>e<b>f</b></u></i>ghi'
},
Big refactoring to TextNode to make it work with new format of storing annotations. Change-Id: If84fcfdd04ff42e9b2449e1c8186d64fec4fb1ac
2012-05-03 05:28:57 +00:00
{
'data': [
{ 'type': 'paragraph' },
'a',
'b',
'c',
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['d', [
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' }
]],
['e', [
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' }
]],
['f', [
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/italic' }
]],
Big refactoring to TextNode to make it work with new format of storing annotations. Change-Id: If84fcfdd04ff42e9b2449e1c8186d64fec4fb1ac
2012-05-03 05:28:57 +00:00
'g',
'h',
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
'i',
Big refactoring to TextNode to make it work with new format of storing annotations. Change-Id: If84fcfdd04ff42e9b2449e1c8186d64fec4fb1ac
2012-05-03 05:28:57 +00:00
{ 'type': '/paragraph' }
],
'html': 'abc<i><u><b>d</b>e<b>f</b></u></i>ghi'
},
{
'data': [
{ 'type': 'paragraph' },
'a',
'b',
'c',
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
['d', [
{ 'type': 'textStyle/italic' },
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' }
]],
['e', [
{ 'type': 'textStyle/bold' },
{ 'type': 'textStyle/underline' }
]],
['f', [
{ 'type': 'textStyle/underline' },
{ 'type': 'textStyle/bold' }
]],
Big refactoring to TextNode to make it work with new format of storing annotations. Change-Id: If84fcfdd04ff42e9b2449e1c8186d64fec4fb1ac
2012-05-03 05:28:57 +00:00
'g',
'h',
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
'i',
Big refactoring to TextNode to make it work with new format of storing annotations. Change-Id: If84fcfdd04ff42e9b2449e1c8186d64fec4fb1ac
2012-05-03 05:28:57 +00:00
{ 'type': '/paragraph' }
],
'html': 'abc<i><u><b>d</b></u></i><u><b>ef</b></u>ghi'
* Replace spaces at the beginning and at the end of text node with &nbsp; * Alternate double spaces with &nbsp, " " -> " &nbsp;" Change-Id: Ib4351ed6263e69f0d98957c2d0d8411e040fece7
2012-06-20 22:31:50 +00:00
},
{
// [ ]
'data': [{ 'type': 'paragraph' },{ 'type': '/paragraph' }],
'html': ''
},
{
// [ ]
'data': [{ 'type': 'paragraph' },' ',{ 'type': '/paragraph' }],
'html': '&nbsp;'
},
{
// [ ][ ]
'data': [{ 'type': 'paragraph' },' ', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp;&nbsp;'
},
{
// [ ][ ][ ]
'data': [{ 'type': 'paragraph' },' ', ' ', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp; &nbsp;'
},
{
// [ ][ ][ ][ ]
'data': [{ 'type': 'paragraph' },' ', ' ', ' ', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp; &nbsp;&nbsp;'
},
{
// [ ][ ][ ][ ][ ]
'data': [{ 'type': 'paragraph' },' ', ' ', ' ', ' ', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp; &nbsp; &nbsp;'
},
{
// [ ][ ][ ][ ][ ][ ]
'data': [{ 'type': 'paragraph' },' ', ' ', ' ', ' ', ' ', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp; &nbsp; &nbsp;&nbsp;'
},
{
// [ ][A][ ][ ][ ][ ]
'data': [{ 'type': 'paragraph' },' ', 'A', ' ', ' ', ' ', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp;A &nbsp; &nbsp;'
},
{
// [ ][ ][A][ ][ ][ ]
'data': [{ 'type': 'paragraph' },' ', ' ', 'A', ' ', ' ', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp; A &nbsp;&nbsp;'
},
{
// [ ][ ][ ][A][ ][ ]
'data': [{ 'type': 'paragraph' },' ', ' ', ' ', 'A', ' ', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp; &nbsp;A &nbsp;'
},
{
// [ ][ ][ ][ ][A][ ]
'data': [{ 'type': 'paragraph' },' ', ' ', ' ', ' ', 'A', ' ',{ 'type': '/paragraph' }],
'html': '&nbsp; &nbsp; A&nbsp;'
},
{
// [ ][ ][ ][ ][ ][A]
'data': [{ 'type': 'paragraph' },' ', ' ', ' ', ' ', ' ', 'A',{ 'type': '/paragraph' }],
'html': '&nbsp; &nbsp; &nbsp;A'
Whitespace and syntax fixes Change-Id: I5a553272c1faf1e83a5e8be8ecf7911a11ec27a8
2012-05-07 18:58:02 +00:00
}
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
];
Kranitor #1: On-boarding '''Kranitor commits''' are commits by Krinkle with his janitor hat on. Must never contain functional changes mixed with miscellaneous changes. .gitignore: * Add .DS_Store to the ignore list so that browsing the directories on Mac OS X, will not add these files to the list of untracked files. * Fix missing newline at end of file .jshintrc * raises -> throws * +module (QUnit.module) * remove 'Node' (as of node-jshint 1.7.2 this is now part of 'browser:true', as it should be) Authors: * Adding myself MWExtension/VisualEditor.php * Fix default value of wgVisualEditorParsoidURL to not point to the experimental instance in WMF Labs. Issues: * ve.ce.TextNode: - Fix TODO: Don't perform a useless clone of an already-jQuerified object. - Use .html() to set html content instead of encapsulating between two strings. This is slightly faster but more importantly safer, and prevents situations where the resulting jQuery collection actually contains 2 elements instead of 1, thus messing up what .contents() is iterating over. * ve.ce.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Document.test.js - Fix: ReferenceError: assert is not defined * ve.dm.Transaction.test.js - Fix: ReferenceError: assert is not defined * ve.dm.TransactionProcessor.test.js - Fix: ReferenceError: assert is not defined * ext.visualEditor.viewPageTarget - Missing dependency on 'mediawiki.Title' Code conventions / Misc cleanup * Various JSHint warnings. * Whitespace * jQuery(): Use '<tag>' for element creation, use '<valid><xml/></valid>' for parsing * Use the default operator instead of ternary when the condition and first value are the same. x = foo ? foo : bar; -> x = foo || bar; Because contrary to some programming language (PHP...), in JS the default operator does not enforce a boolean result but returns the original value, hence it being called the 'default' operator, as opposed to the 'or' operator. * No need to call addClass() twice, it takes a space-separated list (jQuery splits by space and adds if needed) * Use .on( event[, selector], fn ) instead of the deprecated routers to it such as .bind(), .delegate() and .live(). All these three are now built-in and fully compatible with .on() * Add 'XXX:' comments for suspicious code that I don't want to change as part of a clean up commit. * Remove unused variables (several var x = this; where x was not used anywhere, possibly from boilerplate copy/paste) * Follows-up Trevor's commit that converts test suites to the new QUnit format. Also removed the globals since we no longer use those any more. Change-Id: I7e37c9bff812e371c7f65a6fd85d9e2af3e0a22f
2012-07-27 08:43:33 +00:00
for ( i = 0, len = cases.length; i < len; i++ ) {
Manage annotations in ve.AnnotationSet object Introduced the ve.AnnotationSet class to manage sets of annotations. This is a generalization of ve.OrderedHashSet, a class that manages a set using an array and an object keyed by hash. Converted everything that stores, tracks or passes around annotations to use ve.AnnotationSet. In particular, this means the linear model now contains AnnotationSets instead of hash-keyed objects. This allows us to maintain the order of annotations in the linear model, and will help fix bugs with annotation ordering and splitting. Change-Id: I50975b0a95f4cc33017a0b59fdede9ed1eff0124
2012-08-24 02:06:36 +00:00
ve.dm.example.preprocessAnnotations( cases[i].data );
Moved summary functions into custom assertions Also updated tests to use the new assert as an argument style Change-Id: I3c82b4b068134bba755ae4a5c26f5bb98d400c43
2012-07-10 19:46:08 +00:00
assert.equal(
Whitespace and syntax fixes Change-Id: I5a553272c1faf1e83a5e8be8ecf7911a11ec27a8
2012-05-07 18:58:02 +00:00
( new ve.ce.TextNode(
( new ve.dm.Document( cases[i].data ) )
.documentNode.getChildren()[0].getChildren()[0] )
).getHtml(),
cases[i].html
);
Very dirty but working version of getHtml method for TextNode (with bunch of tests that are passing now). Change-Id: Ie76bd59bc0a5e10e2a3b3e014b2d0e4701fcc368
2012-05-03 02:29:03 +00:00
}
Whitespace and syntax fixes Change-Id: I5a553272c1faf1e83a5e8be8ecf7911a11ec27a8
2012-05-07 18:58:02 +00:00
} );
Reference in a new issue Copy permalink