wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-12 09:09:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../.jshintrc

30 lines
405 B
Plaintext
Raw Normal View History

JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
{
JSHint: Re-order jshintrc options to split common from project settings Per I43ace21208 and https://www.mediawiki.org/wiki/CC/JS#Linting Change-Id: I280d377071ca1244130cd976aeba11d2152ef923
2013-04-13 06:53:11 +00:00
// Enforcing
build: Update jscs and jshint jshint: * Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0). * Remove coding style options covered by jscs. * Enable new option "freeze" (prohibits changing native prototypes). http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze * Re-order to match http://www.jshint.com/docs/options/ jscs: * Update to grunt-jscs-checker v0.4.4 (jscs v1.4.5). * Format .jscsrc file in a more spacious way and order the properties less arbitrarily (using the jscs's readme order). * Enforce more details of our coding style * Get rid of the unsable "sticky" operator rules which have been deprecated in favour of using other rules instead that are able to enforce this more accurately. - disallowLeftStickedOperators: Remove deprecated rule. * Ternary covered by requireSpacesInConditionalExpression. * Rest covered by requireSpace{Before,After}BinaryOperators. - requireLeftStickedOperators: Remove deprecated rule. * Comma covered by disallowSpaceBeforeBinaryOperators. - requireRightStickedOperators: Remove deprecated rule. * Logical not (!) covered by disallowSpaceAfterPrefixUnaryOperators. See also If46b94ce1, Ib731f11b1 and I0b0cadbc5 in oojs/core. Also: * Update grunt-contrib-watch to latest upstream version. Change log at https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG#L1-L17 Change-Id: I6c5a34afea8b05a3dca617897c192594df06ca90
2014-05-15 16:12:43 +00:00
"bitwise": true,
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
"eqeqeq": true,
build: Update jscs and jshint jshint: * Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0). * Remove coding style options covered by jscs. * Enable new option "freeze" (prohibits changing native prototypes). http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze * Re-order to match http://www.jshint.com/docs/options/ jscs: * Update to grunt-jscs-checker v0.4.4 (jscs v1.4.5). * Format .jscsrc file in a more spacious way and order the properties less arbitrarily (using the jscs's readme order). * Enforce more details of our coding style * Get rid of the unsable "sticky" operator rules which have been deprecated in favour of using other rules instead that are able to enforce this more accurately. - disallowLeftStickedOperators: Remove deprecated rule. * Ternary covered by requireSpacesInConditionalExpression. * Rest covered by requireSpace{Before,After}BinaryOperators. - requireLeftStickedOperators: Remove deprecated rule. * Comma covered by disallowSpaceBeforeBinaryOperators. - requireRightStickedOperators: Remove deprecated rule. * Logical not (!) covered by disallowSpaceAfterPrefixUnaryOperators. See also If46b94ce1, Ib731f11b1 and I0b0cadbc5 in oojs/core. Also: * Update grunt-contrib-watch to latest upstream version. Change log at https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG#L1-L17 Change-Id: I6c5a34afea8b05a3dca617897c192594df06ca90
2014-05-15 16:12:43 +00:00
"freeze": true,
build: Bump various devDeps to latest and make pass * grunt-contrib-jshint: 0.11.3 -> 0.12.0 This version of the linter cleans up a number of options. 'es5' is now assumed to be true by default, and replaced as 'esversion'; 'latedef' is extended to also cover functions' defintions, disabled for us for now; 'futurehostile' is introduced to aid future-incompatible names for ES6+ support. I adjusted ve.init.mw.DesktopArticleTarget.init.js based on this, as this file is meant to be loaded by all JS-capable clients to determine if it is (amongst other things) capable of ES5, so now we assert ES3 compatibility via jshint. * grunt-jscs: 2.5.0 -> 2.7.0 Minor version bump that doesn't affect us. * grunt-jsonlint: 1.0.6 -> 1.0.7 Trivial version bump that doesn't affect us. Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
2016-02-08 03:37:51 +00:00
"latedef": "nofunc",
"futurehostile": true,
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
"noarg": true,
"nonew": true,
"undef": true,
Documentation & clean up * Commands for Sublime: Find*: "(\* @[a-z]+) ([^{].*) \{(.*)\}" Replace: "$1 {$3} $2" Save all && Close all Find: " function(" Replace: " function (" Save all && Close all Find: "Intialization" Replace: "Initialization" Save all && Close all * Consistent use of types (documented in CODING.rm): - Merged {Integer} into {Number}. - Merged {DOM Node} into {DOMElement}. * Remove work-around /*jshint newcap: false */ from ve.js Calling Object() as a function to to use the internal toObject no longer throws a newcap warning in JSHint. It only does that normal functions now . (e.g. var a = Cap(); or var a = new uncap();) * Add missing annotations (@static, @method, ..). * Remove unused variables * Remove null-assignments to variables that should just be undefined. There's a few variables explicitly set to null whereas they are set a few lines under and not used otherwise (e.g. 'tx' in ve.ce.Surface.prototype.onPaste) Change-Id: I0721a08f8ecd93c25595aedaa1aadb0e08b83799
2012-09-17 13:30:50 +00:00
"unused": true,
build: Bump various devDeps to latest and make pass * grunt-contrib-jshint: 0.11.3 -> 0.12.0 This version of the linter cleans up a number of options. 'es5' is now assumed to be true by default, and replaced as 'esversion'; 'latedef' is extended to also cover functions' defintions, disabled for us for now; 'futurehostile' is introduced to aid future-incompatible names for ES6+ support. I adjusted ve.init.mw.DesktopArticleTarget.init.js based on this, as this file is meant to be loaded by all JS-capable clients to determine if it is (amongst other things) capable of ES5, so now we assert ES3 compatibility via jshint. * grunt-jscs: 2.5.0 -> 2.7.0 Minor version bump that doesn't affect us. * grunt-jsonlint: 1.0.6 -> 1.0.7 Trivial version bump that doesn't affect us. Change-Id: Ieb7b6748b0cecf275cfc284fc66617189372461f
2016-02-08 03:37:51 +00:00
JSHint: Re-order jshintrc options to split common from project settings Per I43ace21208 and https://www.mediawiki.org/wiki/CC/JS#Linting Change-Id: I280d377071ca1244130cd976aeba11d2152ef923
2013-04-13 06:53:11 +00:00
"strict": false,
build: Update jscs and jshint jshint: * Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0). * Remove coding style options covered by jscs. * Enable new option "freeze" (prohibits changing native prototypes). http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze * Re-order to match http://www.jshint.com/docs/options/ jscs: * Update to grunt-jscs-checker v0.4.4 (jscs v1.4.5). * Format .jscsrc file in a more spacious way and order the properties less arbitrarily (using the jscs's readme order). * Enforce more details of our coding style * Get rid of the unsable "sticky" operator rules which have been deprecated in favour of using other rules instead that are able to enforce this more accurately. - disallowLeftStickedOperators: Remove deprecated rule. * Ternary covered by requireSpacesInConditionalExpression. * Rest covered by requireSpace{Before,After}BinaryOperators. - requireLeftStickedOperators: Remove deprecated rule. * Comma covered by disallowSpaceBeforeBinaryOperators. - requireRightStickedOperators: Remove deprecated rule. * Logical not (!) covered by disallowSpaceAfterPrefixUnaryOperators. See also If46b94ce1, Ib731f11b1 and I0b0cadbc5 in oojs/core. Also: * Update grunt-contrib-watch to latest upstream version. Change log at https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG#L1-L17 Change-Id: I6c5a34afea8b05a3dca617897c192594df06ca90
2014-05-15 16:12:43 +00:00
JSHint: Re-order jshintrc options to split common from project settings Per I43ace21208 and https://www.mediawiki.org/wiki/CC/JS#Linting Change-Id: I280d377071ca1244130cd976aeba11d2152ef923
2013-04-13 06:53:11 +00:00
// Relaxing
build: Update jscs and jshint jshint: * Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0). * Remove coding style options covered by jscs. * Enable new option "freeze" (prohibits changing native prototypes). http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze * Re-order to match http://www.jshint.com/docs/options/ jscs: * Update to grunt-jscs-checker v0.4.4 (jscs v1.4.5). * Format .jscsrc file in a more spacious way and order the properties less arbitrarily (using the jscs's readme order). * Enforce more details of our coding style * Get rid of the unsable "sticky" operator rules which have been deprecated in favour of using other rules instead that are able to enforce this more accurately. - disallowLeftStickedOperators: Remove deprecated rule. * Ternary covered by requireSpacesInConditionalExpression. * Rest covered by requireSpace{Before,After}BinaryOperators. - requireLeftStickedOperators: Remove deprecated rule. * Comma covered by disallowSpaceBeforeBinaryOperators. - requireRightStickedOperators: Remove deprecated rule. * Logical not (!) covered by disallowSpaceAfterPrefixUnaryOperators. See also If46b94ce1, Ib731f11b1 and I0b0cadbc5 in oojs/core. Also: * Update grunt-contrib-watch to latest upstream version. Change log at https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG#L1-L17 Change-Id: I6c5a34afea8b05a3dca617897c192594df06ca90
2014-05-15 16:12:43 +00:00
JSHint: Re-order jshintrc options to split common from project settings Per I43ace21208 and https://www.mediawiki.org/wiki/CC/JS#Linting Change-Id: I280d377071ca1244130cd976aeba11d2152ef923
2013-04-13 06:53:11 +00:00
// Environment
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
"browser": true,
"jquery": true,
JSHint: Re-order jshintrc options to split common from project settings Per I43ace21208 and https://www.mediawiki.org/wiki/CC/JS#Linting Change-Id: I280d377071ca1244130cd976aeba11d2152ef923
2013-04-13 06:53:11 +00:00
build: Update jscs and jshint jshint: * Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0). * Remove coding style options covered by jscs. * Enable new option "freeze" (prohibits changing native prototypes). http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze * Re-order to match http://www.jshint.com/docs/options/ jscs: * Update to grunt-jscs-checker v0.4.4 (jscs v1.4.5). * Format .jscsrc file in a more spacious way and order the properties less arbitrarily (using the jscs's readme order). * Enforce more details of our coding style * Get rid of the unsable "sticky" operator rules which have been deprecated in favour of using other rules instead that are able to enforce this more accurately. - disallowLeftStickedOperators: Remove deprecated rule. * Ternary covered by requireSpacesInConditionalExpression. * Rest covered by requireSpace{Before,After}BinaryOperators. - requireLeftStickedOperators: Remove deprecated rule. * Comma covered by disallowSpaceBeforeBinaryOperators. - requireRightStickedOperators: Remove deprecated rule. * Logical not (!) covered by disallowSpaceAfterPrefixUnaryOperators. See also If46b94ce1, Ib731f11b1 and I0b0cadbc5 in oojs/core. Also: * Update grunt-contrib-watch to latest upstream version. Change log at https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG#L1-L17 Change-Id: I6c5a34afea8b05a3dca617897c192594df06ca90
2014-05-15 16:12:43 +00:00
"globals": {
test: Move mw into the global list of globals for VE-MW Silly to have 38 MW-specific files needing to declare that they're using mw. Change-Id: I97891ed922fe0c37d8c96425a4d23bd15098438b
2014-07-19 17:41:06 +00:00
"mw": false,
build: Update jscs and jshint jshint: * Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0). * Remove coding style options covered by jscs. * Enable new option "freeze" (prohibits changing native prototypes). http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze * Re-order to match http://www.jshint.com/docs/options/ jscs: * Update to grunt-jscs-checker v0.4.4 (jscs v1.4.5). * Format .jscsrc file in a more spacious way and order the properties less arbitrarily (using the jscs's readme order). * Enforce more details of our coding style * Get rid of the unsable "sticky" operator rules which have been deprecated in favour of using other rules instead that are able to enforce this more accurately. - disallowLeftStickedOperators: Remove deprecated rule. * Ternary covered by requireSpacesInConditionalExpression. * Rest covered by requireSpace{Before,After}BinaryOperators. - requireLeftStickedOperators: Remove deprecated rule. * Comma covered by disallowSpaceBeforeBinaryOperators. - requireRightStickedOperators: Remove deprecated rule. * Logical not (!) covered by disallowSpaceAfterPrefixUnaryOperators. See also If46b94ce1, Ib731f11b1 and I0b0cadbc5 in oojs/core. Also: * Update grunt-contrib-watch to latest upstream version. Change log at https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG#L1-L17 Change-Id: I6c5a34afea8b05a3dca617897c192594df06ca90
2014-05-15 16:12:43 +00:00
"OO": false,
"QUnit": false,
"unicodeJS": false,
Update VE core submodule to master (0371bbe) New changes: 0371bbe [BREAKING CHANGE] Refine VisualEditorSupportCheck call and document pattern Local changes: Use new VisualEditorSupportCheck pattern Change-Id: I7dc0c360b54a93397180b18d88d72532e439da5c
2016-02-26 20:16:25 +00:00
"ve": false,
"VisualEditorSupportCheck": false
build: Update jscs and jshint jshint: * Update to grunt-contrib-jshint v0.10.0 (jshint v2.5.0). * Remove coding style options covered by jscs. * Enable new option "freeze" (prohibits changing native prototypes). http://www.jshint.com/blog/new-in-jshint-oct-2013/#option-freeze * Re-order to match http://www.jshint.com/docs/options/ jscs: * Update to grunt-jscs-checker v0.4.4 (jscs v1.4.5). * Format .jscsrc file in a more spacious way and order the properties less arbitrarily (using the jscs's readme order). * Enforce more details of our coding style * Get rid of the unsable "sticky" operator rules which have been deprecated in favour of using other rules instead that are able to enforce this more accurately. - disallowLeftStickedOperators: Remove deprecated rule. * Ternary covered by requireSpacesInConditionalExpression. * Rest covered by requireSpace{Before,After}BinaryOperators. - requireLeftStickedOperators: Remove deprecated rule. * Comma covered by disallowSpaceBeforeBinaryOperators. - requireRightStickedOperators: Remove deprecated rule. * Logical not (!) covered by disallowSpaceAfterPrefixUnaryOperators. See also If46b94ce1, Ib731f11b1 and I0b0cadbc5 in oojs/core. Also: * Update grunt-contrib-watch to latest upstream version. Change log at https://github.com/gruntjs/grunt-contrib-watch/blob/v0.6.1/CHANGELOG#L1-L17 Change-Id: I6c5a34afea8b05a3dca617897c192594df06ca90
2014-05-15 16:12:43 +00:00
}
JSHint: Added dotfiles and fixed tons of linting warnings. * "onevar" warning sometimes solved by just merging var statements other times solved by making it a function declaration instead of a function expression. * Also fixed several '_this' variable names in ve.es.Surface to more descriptive names, and enabled warnings for dangling _ in identifiers. Change-Id: I7d411881e3e06cf9a7fe56d689c29375881a81de
2012-07-19 03:40:49 +00:00
}
Reference in a new issue Copy permalink