wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-09-27 20:26:46 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../tests/ve2/dm/ve.dm.LeafNode.test.js

31 lines
639 B
JavaScript
Raw Normal View History

Setup tests, which are still empty Had to fix a few namespace typos too Change-Id: I3ebdc418f374bd3e151c516e1c0cfe85398772f0
2012-04-19 21:17:59 +00:00
module( 've.dm.LeafNode' );
Improved test coverage for ve.dm.BranchNode.splice and ve.dm.TwigNode.splice * Changed splice to check all elements about to be inserted are allowed before inserting any of them so that catching an exception leaves you in a sane state * Fixed the order of execution of parent class constructors in ve.dm.LeafNode and ve.dm.TwigNode so that canHaveChildren and canHaveGrandchildren produce correct values and added tests to ensure these methods are correctly inherited in subclasses * Added tests that check for exceptions when adding nodes that can have children to nodes that can not have grandchildren * Added test that check for events being emitted before and after splicing, including that beforeSplice should be emitted even in cases where a splice fails and throws an exception because the nodes are incompatible (but afterSplice is not called in this case) since beforeSplice might modify the nodes in some way before the compatibility tests are run Change-Id: Id12aea995a42c26ff63a74ae3d31f2bf455759e3
2012-04-20 00:45:58 +00:00
/* Stubs */
ve.dm.LeafNodeStub = function() {
// Inheritance
Added test for replaceDomWrapper and onSplice in ve.ce.BranchNode * Also fixed calls to addListenerMethod * Also routed adding children in the constructor of ve.dm.BranchNode to the splice method * Renamed types of ve.dm stub nodes to avoid collisions (since we have to register ce nodes by the same names for them to be generated by onSplice) Change-Id: Ia2e75cf0a62186cc0e214683feb25c619590318a
2012-05-02 20:58:50 +00:00
ve.dm.LeafNode.call( this, 'leaf-stub' );
Improved test coverage for ve.dm.BranchNode.splice and ve.dm.TwigNode.splice * Changed splice to check all elements about to be inserted are allowed before inserting any of them so that catching an exception leaves you in a sane state * Fixed the order of execution of parent class constructors in ve.dm.LeafNode and ve.dm.TwigNode so that canHaveChildren and canHaveGrandchildren produce correct values and added tests to ensure these methods are correctly inherited in subclasses * Added tests that check for exceptions when adding nodes that can have children to nodes that can not have grandchildren * Added test that check for events being emitted before and after splicing, including that beforeSplice should be emitted even in cases where a splice fails and throws an exception because the nodes are incompatible (but afterSplice is not called in this case) since beforeSplice might modify the nodes in some way before the compatibility tests are run Change-Id: Id12aea995a42c26ff63a74ae3d31f2bf455759e3
2012-04-20 00:45:58 +00:00
};
Added tests for getOffsetFromNode Change-Id: I4dc06e9ea3b634fbd5034df721162098441ea368
2012-05-03 18:52:17 +00:00
ve.dm.LeafNodeStub.rules = {
'canHaveChildren': false,
Add an isWrapped property and make getOuterLength use it This gets rid of the length == outerLength-2 hack in getDataFromNode() and will make it easier to implement similar logic in selectNodes() Change-Id: I1294350b67ca3eefde2b7fe9fea0bc6d8b90f772
2012-05-07 19:00:07 +00:00
'canHaveGrandchildren': false,
'isWrapped': true
Added tests for getOffsetFromNode Change-Id: I4dc06e9ea3b634fbd5034df721162098441ea368
2012-05-03 18:52:17 +00:00
};
Improved test coverage for ve.dm.BranchNode.splice and ve.dm.TwigNode.splice * Changed splice to check all elements about to be inserted are allowed before inserting any of them so that catching an exception leaves you in a sane state * Fixed the order of execution of parent class constructors in ve.dm.LeafNode and ve.dm.TwigNode so that canHaveChildren and canHaveGrandchildren produce correct values and added tests to ensure these methods are correctly inherited in subclasses * Added tests that check for exceptions when adding nodes that can have children to nodes that can not have grandchildren * Added test that check for events being emitted before and after splicing, including that beforeSplice should be emitted even in cases where a splice fails and throws an exception because the nodes are incompatible (but afterSplice is not called in this case) since beforeSplice might modify the nodes in some way before the compatibility tests are run Change-Id: Id12aea995a42c26ff63a74ae3d31f2bf455759e3
2012-04-20 00:45:58 +00:00
ve.extendClass( ve.dm.LeafNodeStub, ve.dm.LeafNode );
Added tests for getOffsetFromNode Change-Id: I4dc06e9ea3b634fbd5034df721162098441ea368
2012-05-03 18:52:17 +00:00
ve.dm.factory.register( 'leaf-stub', ve.dm.LeafNodeStub );
Improved test coverage for ve.dm.BranchNode.splice and ve.dm.TwigNode.splice * Changed splice to check all elements about to be inserted are allowed before inserting any of them so that catching an exception leaves you in a sane state * Fixed the order of execution of parent class constructors in ve.dm.LeafNode and ve.dm.TwigNode so that canHaveChildren and canHaveGrandchildren produce correct values and added tests to ensure these methods are correctly inherited in subclasses * Added tests that check for exceptions when adding nodes that can have children to nodes that can not have grandchildren * Added test that check for events being emitted before and after splicing, including that beforeSplice should be emitted even in cases where a splice fails and throws an exception because the nodes are incompatible (but afterSplice is not called in this case) since beforeSplice might modify the nodes in some way before the compatibility tests are run Change-Id: Id12aea995a42c26ff63a74ae3d31f2bf455759e3
2012-04-20 00:45:58 +00:00
/* Tests */
Added canHaveChildren and canHaveGrandchildren to all nodes Change-Id: Ibe53292f7269736750e03da49e5bb5913c0124ab
2012-05-05 00:50:54 +00:00
test( 'canHaveChildren', 1, function() {
var node = new ve.dm.LeafNodeStub();
equal( node.canHaveChildren(), false );
} );
test( 'canHaveGrandchildren', 1, function() {
var node = new ve.dm.LeafNodeStub();
equal( node.canHaveGrandchildren(), false );
} );
Reference in a new issue Copy permalink