mediawiki-extensions-Visual.../modules/ve-mw/ui/tools/ve.ui.MWInspectorTool.js

/*!
 * VisualEditor UserInterface MediaWiki InspectorTool classes.
 *
 * @copyright 2011-2014 VisualEditor Team and others; see AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
 */

/**
 * UserInterface link tool.
 *
 * @class
 * @extends ve.ui.LinkInspectorTool
 * @constructor
 * @param {OO.ui.ToolGroup} toolGroup
 * @param {Object} [config] Configuration options
 */
ve.ui.MWLinkInspectorTool = function VeUiMWLinkInspectorTool( toolGroup, config ) {
	ve.ui.LinkInspectorTool.call( this, toolGroup, config );
};

OO.inheritClass( ve.ui.MWLinkInspectorTool, ve.ui.LinkInspectorTool );

ve.ui.MWLinkInspectorTool.static.modelClasses =
	ve.ui.MWLinkInspectorTool.static.modelClasses.concat(
		[ ve.dm.MWNumberedExternalLinkNode ]
	);

ve.ui.toolFactory.register( ve.ui.MWLinkInspectorTool );
Make autonumbered external links inspectable When the target of an autonumbered link is changed to a URL, it's kept as an autonumbered link and its target is updated. When the target is changed to a MediaWiki page, the autonumbered link is removed and replaced with an internal link with the text set to the target. So for instance, if you inspect [http://www.example.com] and change its target to "Foo", the result will be [[Foo]]. The core of this commit adds support for inspecting nodes to ve.ui.LinkInspector. This support should probably move into a class in between AnnotationInspector and LinkInspector, perhaps called HybridInspector or something, but I'm deferring that for now. LinkInspector allows changes to inspected nodes to be reflected either as attribute changes on the node, or by replacing the node with something else. MWLinkInspector uses this feature to replace the autonumbered external link node with an internal link annotation when the target is set to an external link. Bug: 53505 Change-Id: Icb404af84c24574438e4de3ef05bbd1993b593f7 2013-11-27 19:16:45 +00:00			`/*!`
			`* VisualEditor UserInterface MediaWiki InspectorTool classes.`
			`*`
Bump copyright like it's 2014 Change-Id: Ic469ebda2c061dc7da0b4c1625f43a7be55da4fa 2014-01-05 12:05:05 +00:00			`* @copyright 2011-2014 VisualEditor Team and others; see AUTHORS.txt`
Make autonumbered external links inspectable When the target of an autonumbered link is changed to a URL, it's kept as an autonumbered link and its target is updated. When the target is changed to a MediaWiki page, the autonumbered link is removed and replaced with an internal link with the text set to the target. So for instance, if you inspect [http://www.example.com] and change its target to "Foo", the result will be [[Foo]]. The core of this commit adds support for inspecting nodes to ve.ui.LinkInspector. This support should probably move into a class in between AnnotationInspector and LinkInspector, perhaps called HybridInspector or something, but I'm deferring that for now. LinkInspector allows changes to inspected nodes to be reflected either as attribute changes on the node, or by replacing the node with something else. MWLinkInspector uses this feature to replace the autonumbered external link node with an internal link annotation when the target is set to an external link. Bug: 53505 Change-Id: Icb404af84c24574438e4de3ef05bbd1993b593f7 2013-11-27 19:16:45 +00:00			`* @license The MIT License (MIT); see LICENSE.txt`
			`*/`

			`/**`
			`* UserInterface link tool.`
			`*`
			`* @class`
			`* @extends ve.ui.LinkInspectorTool`
			`* @constructor`
			`* @param {OO.ui.ToolGroup} toolGroup`
			`* @param {Object} [config] Configuration options`
			`*/`
			`ve.ui.MWLinkInspectorTool = function VeUiMWLinkInspectorTool( toolGroup, config ) {`
			`ve.ui.LinkInspectorTool.call( this, toolGroup, config );`
			`};`

			`OO.inheritClass( ve.ui.MWLinkInspectorTool, ve.ui.LinkInspectorTool );`

			`ve.ui.MWLinkInspectorTool.static.modelClasses =`
			`ve.ui.MWLinkInspectorTool.static.modelClasses.concat(`
			`[ ve.dm.MWNumberedExternalLinkNode ]`
			`);`

Set up node-jscs, pass it, and configure in local Gruntfile Let's experiment with this via our local Gruntfile. If it works fine we can install it in Jenkins (similar to node-csslint). Verify through $ npm install && npm test; Fixed all outstanding violations. Also: * Added syntaxhighight to ignore. * Added imetests (which contain unformatted JSON) to ignore. * In ve.dm.ModelRegistry#matchTypeRegExps, removed redundant !! cast from the [+!!withFunc] statement which was hitting a bug in node-jscs. All callers to this local private function pass a literal boolean true/false so no need to cast it. * Removed "/* key .. , value /" from ve.setProp, though this wasn't caught by node-jscs, found it when searching for " , ". Made npm.devDependencies fixed instead of using tilde-ranges. This too often leads to strange bugs or sudden changes. Fixed them at the version they were currently ranging to. Bug: 54218 Change-Id: Ib2630806f3946874c8b01e58cf171df83a28da29 2013-12-06 02:34:44 +00:00			`ve.ui.toolFactory.register( ve.ui.MWLinkInspectorTool );`