wikimedia/mediawiki-extensions-VisualEditor
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor synced 2024-11-28 00:00:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Visual.../VisualEditor.hooks.php

629 lines
22 KiB
PHP
Raw Normal View History

Create base integration core module Works on VisualEditor Namespace Created VE api wrapper for parsoid service to roundtrip pages Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
2012-05-25 19:50:48 +00:00
<?php
Changed to use MIT license per agreement with the VisualEditor team This license change is aimed at maximizing the reusability of this code in other projects. VisualEditor is more than just an awesome editor for MediaWiki, it's the new editor for the entire internet. Added license and author files, plus mentions of the license to all VisualEditor PHP, JavaScript and CSS files. Parser files have not been modified but are effectively re-licensed since there's no overriding license information. 3rd party libraries are not changed, but are all already MIT licensed. Change-Id: I895b256325db7c8689756edab34523de4418b0f2
2012-07-19 00:11:26 +00:00
/**
* VisualEditor extension hooks
Removed some whitespace And added a license to some files that didn't have it yet Change-Id: I3a7e60374d1198d369a0475b8f65f7415012a337
2012-07-19 21:25:16 +00:00
*
Changed to use MIT license per agreement with the VisualEditor team This license change is aimed at maximizing the reusability of this code in other projects. VisualEditor is more than just an awesome editor for MediaWiki, it's the new editor for the entire internet. Added license and author files, plus mentions of the license to all VisualEditor PHP, JavaScript and CSS files. Parser files have not been modified but are effectively re-licensed since there's no overriding license information. 3rd party libraries are not changed, but are all already MIT licensed. Change-Id: I895b256325db7c8689756edab34523de4418b0f2
2012-07-19 00:11:26 +00:00
* @file
* @ingroup Extensions
Bump copyright notice year range to -2013 over -2012 199 files touched. Whee! Change-Id: Id82ce4a32f833406db4a1cc585674f2bdb39ba0d
2013-02-19 23:37:34 +00:00
* @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
Changed to use MIT license per agreement with the VisualEditor team This license change is aimed at maximizing the reusability of this code in other projects. VisualEditor is more than just an awesome editor for MediaWiki, it's the new editor for the entire internet. Added license and author files, plus mentions of the license to all VisualEditor PHP, JavaScript and CSS files. Parser files have not been modified but are effectively re-licensed since there's no overriding license information. 3rd party libraries are not changed, but are all already MIT licensed. Change-Id: I895b256325db7c8689756edab34523de4418b0f2
2012-07-19 00:11:26 +00:00
* @license The MIT License (MIT); see LICENSE.txt
*/
Create base integration core module Works on VisualEditor Namespace Created VE api wrapper for parsoid service to roundtrip pages Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
2012-05-25 19:50:48 +00:00
class VisualEditorHooks {
Add ability to log analytic events using EventLogging This change adds a '$wgVisualEditorEnableEventLogging' configuration variable, accessible client-side as 'wgVisualEditorConfig.enableEventLogging'. When true, the 'schema.Edit' ResourceLoader module will be loaded on the page, and calls to ViewPageTarget.logEvent will forward to mw.eventLog#logEvent. When false, the module is not loaded, and ViewPageTarget.logEvent is a no-op. The change also adds a few calls to ViewPageTarget.logEvent to log certain editor actions, documented in https://meta.wikimedia.org/wiki/Schema:Edit. Change-Id: Iccd171d7cde15b0302d1b4c292bcbcc2a4b337ef
2013-06-11 22:14:44 +00:00
public static function onSetup() {
Use internal ve.track to log events This patch rounds off change I29740fa7a by replacing calls to EventLogging's eventLog.logEvent with calls to VisualEditor's ve.track. ve.track publishes events by providing an interface, ve.trackRegisterHandler, which event handlers use to subscribe to VisualEditor events. By making it the responsibility of the web analytics framework to register itself as a handler, VisualEditor can remain decoupled from (and indeed ignorant of) any particular event logging implementation. This allows VisualEditor to be integrated with many different web analytics platforms with nothing more than a bit of glue code for mapping ve's event semantics to those of the target platform. The practical difference that this makes is that it frees VisualEditor from having to know about EventLogging or from having to load EventLogging components, which means we can remove quite a lot of gnarly code. My current plan is to migrate the code for registering and loading the 'Edit' schema module to Extension:CoreEvents, which is also where I'll commit the handler for VE events. (CoreEvents exists precisely to provide an organized place for persistent but WMF-particular instrumentation.) Once this patch is merged and deployed, the following two configuration variables may be removed from mediawiki-config: - $wgVisualEditorEnableSplitTest - $wgVisualEditorEnableEventLogging Change-Id: Idfdf692668d2adfbe029e8f0c4ff9e96c60ff741
2013-08-02 23:40:52 +00:00
global $wgResourceModules, $wgVisualEditorResourceTemplate,
$wgVisualEditorTabMessages;
Add ability to log analytic events using EventLogging This change adds a '$wgVisualEditorEnableEventLogging' configuration variable, accessible client-side as 'wgVisualEditorConfig.enableEventLogging'. When true, the 'schema.Edit' ResourceLoader module will be loaded on the page, and calls to ViewPageTarget.logEvent will forward to mw.eventLog#logEvent. When false, the module is not loaded, and ViewPageTarget.logEvent is a no-op. The change also adds a few calls to ViewPageTarget.logEvent to log certain editor actions, documented in https://meta.wikimedia.org/wiki/Schema:Edit. Change-Id: Iccd171d7cde15b0302d1b4c292bcbcc2a4b337ef
2013-06-11 22:14:44 +00:00
Add dependency check for MW1.22/wmf11 And perhaps-overly lengthy explanation as to why this is needed. Bug: 51606 Change-Id: I225bfbe7923434f3c363562de6226ddf618b834b
2013-07-31 01:20:37 +00:00
// This prevents VisualEditor from being run in environments that don't
// have the dependent code in core; this should be updated as a part of
// when additional dependencies are created and pushed into MediaWiki's
// core. The most direct effect of this is to avoid confusing any third
// parties who attempt to install VisualEditor onto non-alpha wikis, as
// this should have no impact on deploying to Wikimedia's wiki cluster.
// Is fine for release tarballs because 1.22wmf11 < 1.22alpha < 1.22.0.
Use mw.util.getUrl instead of mw.util.wikiGetlink (deprecated) Change-Id: I72afbbd909ce2394d54f78d465bd8ad245c1694f
2013-11-07 22:21:08 +00:00
wfUseMW( '1.23wmf2' );
Add dependency check for MW1.22/wmf11 And perhaps-overly lengthy explanation as to why this is needed. Bug: 51606 Change-Id: I225bfbe7923434f3c363562de6226ddf618b834b
2013-07-31 01:20:37 +00:00
Move edit tab generation into PHP and make it more configurable * Generate the edit tabs and the section edit links in PHP, with a fallback in JS for cases where we don't have them yet due to caching. But only change things if VE is enabled, and have the JS correct the state if the wrong cached HTML comes through. * Make the order of the tabs/links and the messages to use as captions configurable * Make the edit tabs and section edit links always be present in the page (regardless of namespace, user prefs, etc.) but be hidden and have JS unhide them (using html.ve-available) if appropriate * Add appendix messages so we can do a superscript "beta" even in places where we can't use HTML in the message VisualEditor.php: * Add new hook registrations * Remove edit link caption messages from the init init module because they're now added dynamically in VisualEditor.hooks.php * Add a noscript CSS module so we can hide some things in JS-less environments * Remove $wgVisualEditorTabLayout and replace it with $wgVisualEditorPosition * Add config vars for link captions, with null causing us to use the default caption * Add config vars for link caption appendices. Too many config vars but we'll clean that up later VisualEditor.hooks.php: * Dynamically add tab messages to the init init module * Remove unused globals in onBeforePageDisplay() * Add noscript CSS module * Add a SkinTemplateNavigation hook that changes and reorders the edit tabs as appropriate * Add a DoEditSectionLink hook that overwrites the edit section links * Export the new config variables to JS VisualEditor.i18n.php: * Add beta appendix message * Add a message for the default VE edit section link ve.init.mw.ViewPageTarget.init.css: * Remove the animation on the edit section links * Darken the color of the brackets and the pipe from #ccc to #555 * Style the beta message to be superscript-like (but not real <sup> to avoid moving the baseline) ve.init.mw.ViewPageTarget.noscript.css: * Hide the VE edit tab, the pipe and the VE edit section link initally unless and until JS unhides ve.init.mw.ViewPageTarget.init.js: * Toggle .ve-not-available / .ve-available * Edit tabs ** Only generate the the edit tabs if they're not already there from PHP ** Rewrite the edit tab generation to mirror what's being done in PHP * Section edit links ** Same as for edit tabs ** Also add mw-visualeditor-expanded to pad the brackets ve.init.mw.ViewPageTarget.js: * #ca-ve-edit is now always the VE tab (and #ca-edit always the edit source tab) so update the .selected behavior accordingly Change-Id: Idcb15faea7fabe5fe7578b1508079969b27d2469
2013-08-01 19:14:41 +00:00
// Add tab messages to the init init module
foreach ( $wgVisualEditorTabMessages as $msg ) {
if ( $msg !== null ) {
$wgResourceModules['ext.visualEditor.viewPageTarget.init']['messages'][] = $msg;
}
}
Add ability to log analytic events using EventLogging This change adds a '$wgVisualEditorEnableEventLogging' configuration variable, accessible client-side as 'wgVisualEditorConfig.enableEventLogging'. When true, the 'schema.Edit' ResourceLoader module will be loaded on the page, and calls to ViewPageTarget.logEvent will forward to mw.eventLog#logEvent. When false, the module is not loaded, and ViewPageTarget.logEvent is a no-op. The change also adds a few calls to ViewPageTarget.logEvent to log certain editor actions, documented in https://meta.wikimedia.org/wiki/Schema:Edit. Change-Id: Iccd171d7cde15b0302d1b4c292bcbcc2a4b337ef
2013-06-11 22:14:44 +00:00
}
Create base integration core module Works on VisualEditor Namespace Created VE api wrapper for parsoid service to roundtrip pages Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
2012-05-25 19:50:48 +00:00
/**
Move edit tab generation into PHP and make it more configurable * Generate the edit tabs and the section edit links in PHP, with a fallback in JS for cases where we don't have them yet due to caching. But only change things if VE is enabled, and have the JS correct the state if the wrong cached HTML comes through. * Make the order of the tabs/links and the messages to use as captions configurable * Make the edit tabs and section edit links always be present in the page (regardless of namespace, user prefs, etc.) but be hidden and have JS unhide them (using html.ve-available) if appropriate * Add appendix messages so we can do a superscript "beta" even in places where we can't use HTML in the message VisualEditor.php: * Add new hook registrations * Remove edit link caption messages from the init init module because they're now added dynamically in VisualEditor.hooks.php * Add a noscript CSS module so we can hide some things in JS-less environments * Remove $wgVisualEditorTabLayout and replace it with $wgVisualEditorPosition * Add config vars for link captions, with null causing us to use the default caption * Add config vars for link caption appendices. Too many config vars but we'll clean that up later VisualEditor.hooks.php: * Dynamically add tab messages to the init init module * Remove unused globals in onBeforePageDisplay() * Add noscript CSS module * Add a SkinTemplateNavigation hook that changes and reorders the edit tabs as appropriate * Add a DoEditSectionLink hook that overwrites the edit section links * Export the new config variables to JS VisualEditor.i18n.php: * Add beta appendix message * Add a message for the default VE edit section link ve.init.mw.ViewPageTarget.init.css: * Remove the animation on the edit section links * Darken the color of the brackets and the pipe from #ccc to #555 * Style the beta message to be superscript-like (but not real <sup> to avoid moving the baseline) ve.init.mw.ViewPageTarget.noscript.css: * Hide the VE edit tab, the pipe and the VE edit section link initally unless and until JS unhides ve.init.mw.ViewPageTarget.init.js: * Toggle .ve-not-available / .ve-available * Edit tabs ** Only generate the the edit tabs if they're not already there from PHP ** Rewrite the edit tab generation to mirror what's being done in PHP * Section edit links ** Same as for edit tabs ** Also add mw-visualeditor-expanded to pad the brackets ve.init.mw.ViewPageTarget.js: * #ca-ve-edit is now always the VE tab (and #ca-edit always the edit source tab) so update the .selected behavior accordingly Change-Id: Idcb15faea7fabe5fe7578b1508079969b27d2469
2013-08-01 19:14:41 +00:00
* Adds VisualEditor JS to the output.
Refactored veCore class into ve.init and ve.init.EditPageTarget Change-Id: I52ef09aee38471ca49f3f4a845daf02e6dcc024c
2012-06-11 06:54:41 +00:00
*
* This is attached to the MediaWiki 'BeforePageDisplay' hook.
Create base integration core module Works on VisualEditor Namespace Created VE api wrapper for parsoid service to roundtrip pages Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
2012-05-25 19:50:48 +00:00
*
* @param $output OutputPage
* @param $skin Skin
*/
Refactored veCore class into ve.init and ve.init.EditPageTarget Change-Id: I52ef09aee38471ca49f3f4a845daf02e6dcc024c
2012-06-11 06:54:41 +00:00
public static function onBeforePageDisplay( &$output, &$skin ) {
mw.ViewPageTarget.init: Move conditionals client-side Load the module always and have the conditionals on the client-side so that we can change these without running into problems with the new conditions not being rolled-out quickly for anonymous users because the load queue is in the HTML and cached for 30+ days. This also allows us to fix above problem retroactively in wmf production by just adding a mw.loader.load for this module in something like MediaWiki:Common.js or something else that is already in the cached load queue (temporarily, until the cache has rolled over). Removed unreachable code for loading ext.visualEditor.splitTest. Change-Id: I21114960a88d224747447f2dc83d17d160f5f066
2013-07-19 02:44:22 +00:00
$output->addModules( array( 'ext.visualEditor.viewPageTarget.init' ) );
Move edit tab generation into PHP and make it more configurable * Generate the edit tabs and the section edit links in PHP, with a fallback in JS for cases where we don't have them yet due to caching. But only change things if VE is enabled, and have the JS correct the state if the wrong cached HTML comes through. * Make the order of the tabs/links and the messages to use as captions configurable * Make the edit tabs and section edit links always be present in the page (regardless of namespace, user prefs, etc.) but be hidden and have JS unhide them (using html.ve-available) if appropriate * Add appendix messages so we can do a superscript "beta" even in places where we can't use HTML in the message VisualEditor.php: * Add new hook registrations * Remove edit link caption messages from the init init module because they're now added dynamically in VisualEditor.hooks.php * Add a noscript CSS module so we can hide some things in JS-less environments * Remove $wgVisualEditorTabLayout and replace it with $wgVisualEditorPosition * Add config vars for link captions, with null causing us to use the default caption * Add config vars for link caption appendices. Too many config vars but we'll clean that up later VisualEditor.hooks.php: * Dynamically add tab messages to the init init module * Remove unused globals in onBeforePageDisplay() * Add noscript CSS module * Add a SkinTemplateNavigation hook that changes and reorders the edit tabs as appropriate * Add a DoEditSectionLink hook that overwrites the edit section links * Export the new config variables to JS VisualEditor.i18n.php: * Add beta appendix message * Add a message for the default VE edit section link ve.init.mw.ViewPageTarget.init.css: * Remove the animation on the edit section links * Darken the color of the brackets and the pipe from #ccc to #555 * Style the beta message to be superscript-like (but not real <sup> to avoid moving the baseline) ve.init.mw.ViewPageTarget.noscript.css: * Hide the VE edit tab, the pipe and the VE edit section link initally unless and until JS unhides ve.init.mw.ViewPageTarget.init.js: * Toggle .ve-not-available / .ve-available * Edit tabs ** Only generate the the edit tabs if they're not already there from PHP ** Rewrite the edit tab generation to mirror what's being done in PHP * Section edit links ** Same as for edit tabs ** Also add mw-visualeditor-expanded to pad the brackets ve.init.mw.ViewPageTarget.js: * #ca-ve-edit is now always the VE tab (and #ca-edit always the edit source tab) so update the .selected behavior accordingly Change-Id: Idcb15faea7fabe5fe7578b1508079969b27d2469
2013-08-01 19:14:41 +00:00
$output->addModuleStyles( array( 'ext.visualEditor.viewPageTarget.noscript' ) );
return true;
}
/**
* Changes the Edit tab and adds the VisualEditor tab.
*
* This is attached to the MediaWiki 'SkinTemplateNavigation' hook.
*
* @param SkinTemplate $skin
* @param array $links Navigation links
* @return boolean
*/
public static function onSkinTemplateNavigation( &$skin, &$links ) {
// Only do this if the user has VE enabled
if (
!$skin->getUser()->getOption( 'visualeditor-enable' ) ||
$skin->getUser()->getOption( 'visualeditor-betatempdisable' )
) {
return true;
}
global $wgVisualEditorTabMessages, $wgVisualEditorTabPosition;
if ( !isset( $links['views']['edit'] ) ) {
// There's no edit link, nothing to do
return true;
}
$title = $skin->getRelevantTitle();
// Rebuild the $links['views'] array and inject the VisualEditor tab before or after
// the edit tab as appropriate. We have to rebuild the array because PHP doesn't allow
// us to splice into the middle of an associative array.
$newViews = array();
foreach ( $links['views'] as $action => $data ) {
if ( $action === 'edit' ) {
// Build the VisualEditor tab
$existing = $title->exists() || (
$title->getNamespace() == NS_MEDIAWIKI &&
$title->getDefaultMessageText() !== false
);
$veParams = $skin->editUrlOptions();
unset( $veParams['action'] ); // Remove action=edit
$veParams['veaction'] = 'edit'; // Set veaction=edit
$veTabMessage = $wgVisualEditorTabMessages[$existing ? 'edit' : 'create'];
$veTabText = $veTabMessage === null ? $data['text'] :
wfMessage( $veTabMessage )->setContext( $skin->getContext() )->text();
$veTab = array(
'href' => $title->getLocalURL( $veParams ),
'text' => $veTabText,
'primary' => true,
'class' => '',
);
// Alter the edit tab
$editTab = $data;
$editTabMessage = $wgVisualEditorTabMessages[$existing ? 'editsource' : 'createsource'];
if ( $editTabMessage !== null ) {
$editTab['text'] = wfMessage( $editTabMessage )->setContext( $skin->getContext() )->text();
}
// Inject the VE tab before or after the edit tab
if ( $wgVisualEditorTabPosition === 'before' ) {
$newViews['ve-edit'] = $veTab;
$newViews['edit'] = $editTab;
} else {
$newViews['edit'] = $editTab;
$newViews['ve-edit'] = $veTab;
}
} else {
// Just pass through
$newViews[$action] = $data;
}
}
$links['views'] = $newViews;
return true;
}
/**
* Changes the section edit links to add a VE edit link.
*
* This is attached to the MediaWiki 'DoEditSectionLink' hook.
*
* @param $skin Skin
* @param $title Title
* @param $section string
* @param $tooltip string
* @param $result string HTML
* @param $lang Language
* @returns bool true
*/
public static function onDoEditSectionLink( $skin, $title, $section, $tooltip, &$result, $lang ) {
// Only do this if the user has VE enabled
Don't break core's parserTests if VisualEditor is installed VisualEditor's hook changes the edit section link, which changes the output of certain parser tests so that they no longer match the expected text. Use the `ParserTestsGlobal` hook (which cleans up after itself when the parserTests ends) to disable the `onDoEditSectionLink` hook when we're running parserTests to avoid the spurious failures. Change-Id: Ic958d88f443ac37ba304d3256e2bb5ea2fde820d
2013-09-16 21:12:50 +00:00
// (and we're not in parserTests)
Move edit tab generation into PHP and make it more configurable * Generate the edit tabs and the section edit links in PHP, with a fallback in JS for cases where we don't have them yet due to caching. But only change things if VE is enabled, and have the JS correct the state if the wrong cached HTML comes through. * Make the order of the tabs/links and the messages to use as captions configurable * Make the edit tabs and section edit links always be present in the page (regardless of namespace, user prefs, etc.) but be hidden and have JS unhide them (using html.ve-available) if appropriate * Add appendix messages so we can do a superscript "beta" even in places where we can't use HTML in the message VisualEditor.php: * Add new hook registrations * Remove edit link caption messages from the init init module because they're now added dynamically in VisualEditor.hooks.php * Add a noscript CSS module so we can hide some things in JS-less environments * Remove $wgVisualEditorTabLayout and replace it with $wgVisualEditorPosition * Add config vars for link captions, with null causing us to use the default caption * Add config vars for link caption appendices. Too many config vars but we'll clean that up later VisualEditor.hooks.php: * Dynamically add tab messages to the init init module * Remove unused globals in onBeforePageDisplay() * Add noscript CSS module * Add a SkinTemplateNavigation hook that changes and reorders the edit tabs as appropriate * Add a DoEditSectionLink hook that overwrites the edit section links * Export the new config variables to JS VisualEditor.i18n.php: * Add beta appendix message * Add a message for the default VE edit section link ve.init.mw.ViewPageTarget.init.css: * Remove the animation on the edit section links * Darken the color of the brackets and the pipe from #ccc to #555 * Style the beta message to be superscript-like (but not real <sup> to avoid moving the baseline) ve.init.mw.ViewPageTarget.noscript.css: * Hide the VE edit tab, the pipe and the VE edit section link initally unless and until JS unhides ve.init.mw.ViewPageTarget.init.js: * Toggle .ve-not-available / .ve-available * Edit tabs ** Only generate the the edit tabs if they're not already there from PHP ** Rewrite the edit tab generation to mirror what's being done in PHP * Section edit links ** Same as for edit tabs ** Also add mw-visualeditor-expanded to pad the brackets ve.init.mw.ViewPageTarget.js: * #ca-ve-edit is now always the VE tab (and #ca-edit always the edit source tab) so update the .selected behavior accordingly Change-Id: Idcb15faea7fabe5fe7578b1508079969b27d2469
2013-08-01 19:14:41 +00:00
if (
Don't break core's parserTests if VisualEditor is installed VisualEditor's hook changes the edit section link, which changes the output of certain parser tests so that they no longer match the expected text. Use the `ParserTestsGlobal` hook (which cleans up after itself when the parserTests ends) to disable the `onDoEditSectionLink` hook when we're running parserTests to avoid the spurious failures. Change-Id: Ic958d88f443ac37ba304d3256e2bb5ea2fde820d
2013-09-16 21:12:50 +00:00
isset( $GLOBALS[ 'wgVisualEditorInParserTests' ] ) ||
Move edit tab generation into PHP and make it more configurable * Generate the edit tabs and the section edit links in PHP, with a fallback in JS for cases where we don't have them yet due to caching. But only change things if VE is enabled, and have the JS correct the state if the wrong cached HTML comes through. * Make the order of the tabs/links and the messages to use as captions configurable * Make the edit tabs and section edit links always be present in the page (regardless of namespace, user prefs, etc.) but be hidden and have JS unhide them (using html.ve-available) if appropriate * Add appendix messages so we can do a superscript "beta" even in places where we can't use HTML in the message VisualEditor.php: * Add new hook registrations * Remove edit link caption messages from the init init module because they're now added dynamically in VisualEditor.hooks.php * Add a noscript CSS module so we can hide some things in JS-less environments * Remove $wgVisualEditorTabLayout and replace it with $wgVisualEditorPosition * Add config vars for link captions, with null causing us to use the default caption * Add config vars for link caption appendices. Too many config vars but we'll clean that up later VisualEditor.hooks.php: * Dynamically add tab messages to the init init module * Remove unused globals in onBeforePageDisplay() * Add noscript CSS module * Add a SkinTemplateNavigation hook that changes and reorders the edit tabs as appropriate * Add a DoEditSectionLink hook that overwrites the edit section links * Export the new config variables to JS VisualEditor.i18n.php: * Add beta appendix message * Add a message for the default VE edit section link ve.init.mw.ViewPageTarget.init.css: * Remove the animation on the edit section links * Darken the color of the brackets and the pipe from #ccc to #555 * Style the beta message to be superscript-like (but not real <sup> to avoid moving the baseline) ve.init.mw.ViewPageTarget.noscript.css: * Hide the VE edit tab, the pipe and the VE edit section link initally unless and until JS unhides ve.init.mw.ViewPageTarget.init.js: * Toggle .ve-not-available / .ve-available * Edit tabs ** Only generate the the edit tabs if they're not already there from PHP ** Rewrite the edit tab generation to mirror what's being done in PHP * Section edit links ** Same as for edit tabs ** Also add mw-visualeditor-expanded to pad the brackets ve.init.mw.ViewPageTarget.js: * #ca-ve-edit is now always the VE tab (and #ca-edit always the edit source tab) so update the .selected behavior accordingly Change-Id: Idcb15faea7fabe5fe7578b1508079969b27d2469
2013-08-01 19:14:41 +00:00
!$skin->getUser()->getOption( 'visualeditor-enable' ) ||
$skin->getUser()->getOption( 'visualeditor-betatempdisable' )
) {
return;
}
global $wgVisualEditorTabMessages, $wgVisualEditorTabPosition;
$veEditSection = $wgVisualEditorTabMessages['editsection'] !== null ?
$wgVisualEditorTabMessages['editsection'] : 'editsection';
$sourceEditSection = $wgVisualEditorTabMessages['editsectionsource'] !== null ?
$wgVisualEditorTabMessages['editsectionsource'] : 'editsection';
// Code mostly duplicated from Skin::doEditSectionLink() :(
$attribs = array();
if ( !is_null( $tooltip ) ) {
# Bug 25462: undo double-escaping.
$tooltip = Sanitizer::decodeCharReferences( $tooltip );
$attribs['title'] = wfMessage( 'editsectionhint' )->rawParams( $tooltip )
->inLanguage( $lang )->text();
}
$veLink = Linker::link( $title, wfMessage( $veEditSection )->inLanguage( $lang )->text(),
$attribs + array( 'class' => 'mw-editsection-visualeditor' ),
array( 'veaction' => 'edit', 'section' => $section ),
array( 'noclasses', 'known' )
);
$sourceLink = Linker::link( $title, wfMessage( $sourceEditSection )->inLanguage( $lang )->text(),
$attribs,
array( 'action' => 'edit', 'section' => $section ),
array( 'noclasses', 'known' )
);
$veFirst = $wgVisualEditorTabPosition === 'before';
$result = '<span class="mw-editsection">'
. '<span class="mw-editsection-bracket">[</span>'
. ( $veFirst ? $veLink : $sourceLink )
. '<span class="mw-editsection-divider">'
. wfMessage( 'pipe-separator' )->inLanguage( $lang )->text()
. '</span>'
. ( $veFirst ? $sourceLink : $veLink )
. '<span class="mw-editsection-bracket">]</span>'
. '</span>';
(Re-)Add ability to work even if preference is hidden We want to mark the preference as hidden as we then subsequently remove it. However, if a preference is hidden and we don't set ignoreHidden=true, then it will always fail to trigger VisualEditor, which is sad. Consequently, add this awful hack until deployment of VisualEditor is true for all wikis. (We may want to refactor this enablement code a bit - it's a tad ugly. I've added some more spacing just so you can see what's what, but…) Change-Id: Ia43c9241b53dddb3dcb8b3edfb3b5163e19e18b1
2013-06-26 17:23:56 +00:00
Create base integration core module Works on VisualEditor Namespace Created VE api wrapper for parsoid service to roundtrip pages Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
2012-05-25 19:50:48 +00:00
return true;
}
Integration revamp for December release * Remove VisualEditor namespace, and restrictions on it ** For MW.org these will be moved to mediawiki-config * Add $wgVisualEditorNamespaces * Add visualeditor-enable preference and respect it * Use $skin->getTitle() rather than $wgTitle * Remove "Sandbox" from i18n message * Remove duplicate enforcement of VE namespace from JS Change-Id: I956f68c2dde55e4063530fcc7c90eda048e0d78b
2012-11-05 20:46:14 +00:00
public static function onGetPreferences( $user, &$preferences ) {
Enable VisualEditor using Beta Features Change-Id: I76ba788751dacc24cdbc667b4d24f1656f0ade44
2013-09-30 16:18:46 +00:00
if ( !array_key_exists( 'visualeditor-enable', $preferences ) ) {
$preferences['visualeditor-enable'] = array(
'type' => 'toggle',
'label-message' => 'visualeditor-preference-enable',
'section' => 'editing/beta'
);
}
Create temporary preference to disable VisualEditor during beta This preference will allow users to opt-out of VisualEditor during the beta if they so choose. We do not re-use the alpha enablement flag because (a) this would lead to a confusing preference description, and (b) because opting in and then out of the alpha is not the same user choice as opting out of the beta period. Change-Id: I0f0a1b5eb21703ad422d007cab65c75ac1aa6fd8
2013-07-24 01:11:56 +00:00
$preferences['visualeditor-betatempdisable'] = array(
'type' => 'toggle',
'label-message' => 'visualeditor-preference-betatempdisable',
'section' => 'editing/beta'
);
Integration revamp for December release * Remove VisualEditor namespace, and restrictions on it ** For MW.org these will be moved to mediawiki-config * Add $wgVisualEditorNamespaces * Add visualeditor-enable preference and respect it * Use $skin->getTitle() rather than $wgTitle * Remove "Sandbox" from i18n message * Remove duplicate enforcement of VE namespace from JS Change-Id: I956f68c2dde55e4063530fcc7c90eda048e0d78b
2012-11-05 20:46:14 +00:00
return true;
}
Integrate with BetaPreferences Look at logo Michael. Bug: 52686 Change-Id: I3cfada2ea264184698de5f322c1fe5041b37b8c8
2013-08-12 05:50:04 +00:00
public static function onGetBetaPreferences( $user, &$preferences ) {
Add requirements to BetaFeatures hook Change-Id: Ifc809f49e1cf03015dbb295b6b092b4181edc38b
2013-10-10 12:33:49 +00:00
global $wgExtensionAssetsPath, $wgVisualEditorSupportedSkins, $wgVisualEditorBrowserBlacklist;
Integrate with BetaPreferences Look at logo Michael. Bug: 52686 Change-Id: I3cfada2ea264184698de5f322c1fe5041b37b8c8
2013-08-12 05:50:04 +00:00
Adapt beta features icons for RTL Split the current icons to rtl and ltr versions. Rename all the current mentions of beta icons to ltr and rtl, even those that don't yet exist or are commented out. Change-Id: I96be20515cc9d84d2d71ac7e65d97d72d96636b0
2013-11-08 16:33:53 +00:00
$dir = RequestContext::getMain()->getLanguage()->getDir();
Enable VisualEditor using Beta Features Change-Id: I76ba788751dacc24cdbc667b4d24f1656f0ade44
2013-09-30 16:18:46 +00:00
$preferences['visualeditor-enable'] = array(
'version' => '1.0',
'label-message' => 'visualeditor-preference-core-label',
'desc-message' => 'visualeditor-preference-core-description',
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
'screenshot' => $wgExtensionAssetsPath .
Adapt beta features icons for RTL Split the current icons to rtl and ltr versions. Rename all the current mentions of beta icons to ltr and rtl, even those that don't yet exist or are commented out. Change-Id: I96be20515cc9d84d2d71ac7e65d97d72d96636b0
2013-11-08 16:33:53 +00:00
"/VisualEditor/betafeatures-icon-VisualEditor-$dir.svg",
Use new BetaFetaures message fields Depends on Iccf52b789682d in the BetaFeatures repo. Change-Id: I45ac87e9c715a3bcb1663c83329e1581bcef7907
2013-10-30 20:57:05 +00:00
'info-message' => 'visualeditor-preference-core-info-link',
'discussion-message' => 'visualeditor-preference-core-discussion-link',
Add requirements to BetaFeatures hook Change-Id: Ifc809f49e1cf03015dbb295b6b092b4181edc38b
2013-10-10 12:33:49 +00:00
'requirements' => array(
'javascript' => true,
'blacklist' => $wgVisualEditorBrowserBlacklist,
'skins' => $wgVisualEditorSupportedSkins,
)
Enable VisualEditor using Beta Features Change-Id: I76ba788751dacc24cdbc667b4d24f1656f0ade44
2013-09-30 16:18:46 +00:00
);
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
/* Disabling Beta Features option for language for now
$preferences['visualeditor-enable-language'] = array(
Integrate with BetaPreferences Look at logo Michael. Bug: 52686 Change-Id: I3cfada2ea264184698de5f322c1fe5041b37b8c8
2013-08-12 05:50:04 +00:00
'version' => '1.0',
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
'label-message' => 'visualeditor-preference-language-label',
'desc-message' => 'visualeditor-preference-language-description',
'screenshot' => $wgExtensionAssetsPath .
Adapt beta features icons for RTL Split the current icons to rtl and ltr versions. Rename all the current mentions of beta icons to ltr and rtl, even those that don't yet exist or are commented out. Change-Id: I96be20515cc9d84d2d71ac7e65d97d72d96636b0
2013-11-08 16:33:53 +00:00
"/VisualEditor/betafeatures-icon-VisualEditor-language-$dir.svg",
Use new BetaFetaures message fields Depends on Iccf52b789682d in the BetaFeatures repo. Change-Id: I45ac87e9c715a3bcb1663c83329e1581bcef7907
2013-10-30 20:57:05 +00:00
'info-message' => 'visualeditor-preference-experimental-info-link',
'discussion-message' => 'visualeditor-preference-experimental-discussion-link',
Add requirements to BetaFeatures hook Change-Id: Ifc809f49e1cf03015dbb295b6b092b4181edc38b
2013-10-10 12:33:49 +00:00
'requirements' => array(
'betafeatures' => array(
'visualeditor-enable',
),
),
Integrate with BetaPreferences Look at logo Michael. Bug: 52686 Change-Id: I3cfada2ea264184698de5f322c1fe5041b37b8c8
2013-08-12 05:50:04 +00:00
);
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
*/
/* Disabling Beta Features option for generic content for now
$preferences['visualeditor-enable-mwalienextension'] = array(
'version' => '1.0',
'label-message' => 'visualeditor-preference-mwalienextension-label',
'desc-message' => 'visualeditor-preference-mwalienextension-description',
'screenshot' => $wgExtensionAssetsPath .
Adapt beta features icons for RTL Split the current icons to rtl and ltr versions. Rename all the current mentions of beta icons to ltr and rtl, even those that don't yet exist or are commented out. Change-Id: I96be20515cc9d84d2d71ac7e65d97d72d96636b0
2013-11-08 16:33:53 +00:00
"/VisualEditor/betafeatures-icon-VisualEditor-alien-$dir.svg",
Use new BetaFetaures message fields Depends on Iccf52b789682d in the BetaFeatures repo. Change-Id: I45ac87e9c715a3bcb1663c83329e1581bcef7907
2013-10-30 20:57:05 +00:00
'info-message' => 'visualeditor-preference-mwalienextension-info-link',
'discussion-message' => 'visualeditor-preference-mwalienextension-discussion-link',
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
'requirements' => array(
'betafeatures' => array(
'visualeditor-enable',
),
),
);
*/
$preferences['visualeditor-enable-mwmath'] = array(
'version' => '1.0',
'label-message' => 'visualeditor-preference-mwmath-label',
'desc-message' => 'visualeditor-preference-mwmath-description',
'screenshot' => $wgExtensionAssetsPath .
Adapt beta features icons for RTL Split the current icons to rtl and ltr versions. Rename all the current mentions of beta icons to ltr and rtl, even those that don't yet exist or are commented out. Change-Id: I96be20515cc9d84d2d71ac7e65d97d72d96636b0
2013-11-08 16:33:53 +00:00
"/VisualEditor/betafeatures-icon-VisualEditor-formulae-$dir.svg",
Use new BetaFetaures message fields Depends on Iccf52b789682d in the BetaFeatures repo. Change-Id: I45ac87e9c715a3bcb1663c83329e1581bcef7907
2013-10-30 20:57:05 +00:00
'info-message' => 'visualeditor-preference-mwmath-info-link',
'discussion-message' => 'visualeditor-preference-mwmath-discussion-link',
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
'requirements' => array(
'betafeatures' => array(
'visualeditor-enable',
),
),
);
/* Disabling Beta Features option for hieroglyphics for now
$preferences['visualeditor-enable-mwhiero'] = array(
'version' => '1.0',
'label-message' => 'visualeditor-preference-mwhiero-label',
'desc-message' => 'visualeditor-preference-mwhiero-description',
'screenshot' => $wgExtensionAssetsPath .
Adapt beta features icons for RTL Split the current icons to rtl and ltr versions. Rename all the current mentions of beta icons to ltr and rtl, even those that don't yet exist or are commented out. Change-Id: I96be20515cc9d84d2d71ac7e65d97d72d96636b0
2013-11-08 16:33:53 +00:00
"/VisualEditor/betafeatures-icon-VisualEditor-hieroglyphics-$dir.svg",
Use new BetaFetaures message fields Depends on Iccf52b789682d in the BetaFeatures repo. Change-Id: I45ac87e9c715a3bcb1663c83329e1581bcef7907
2013-10-30 20:57:05 +00:00
'info-message' => 'visualeditor-preference-mwhiero-info-link',
'discussion-message' => 'visualeditor-preference-mwhiero-discussion-link',
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
'requirements' => array(
'betafeatures' => array(
'visualeditor-enable',
),
),
);
*/
/* Disabling Beta Features option for syntax highlighting for now
$preferences['visualeditor-enable-mwsyntaxHighlight'] = array(
'version' => '1.0',
'label-message' => 'visualeditor-preference-mwsyntaxHighlight-label',
'desc-message' => 'visualeditor-preference-mwsyntaxHighlight-description',
'screenshot' => $wgExtensionAssetsPath .
Adapt beta features icons for RTL Split the current icons to rtl and ltr versions. Rename all the current mentions of beta icons to ltr and rtl, even those that don't yet exist or are commented out. Change-Id: I96be20515cc9d84d2d71ac7e65d97d72d96636b0
2013-11-08 16:33:53 +00:00
"/VisualEditor/betafeatures-icon-VisualEditor-syntaxHighlight-$dir.svg",
Use new BetaFetaures message fields Depends on Iccf52b789682d in the BetaFeatures repo. Change-Id: I45ac87e9c715a3bcb1663c83329e1581bcef7907
2013-10-30 20:57:05 +00:00
'info-message' => 'visualeditor-preference-mwsyntaxHighlight-info-link',
'discussion-message' => 'visualeditor-preference-mwsyntaxHighlight-discussion-link',
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
'requirements' => array(
'betafeatures' => array(
'visualeditor-enable',
),
),
);
*/
Integrate with BetaPreferences Look at logo Michael. Bug: 52686 Change-Id: I3cfada2ea264184698de5f322c1fe5041b37b8c8
2013-08-12 05:50:04 +00:00
}
(bug 42172) Tag edits made by VE Uses MW's built-in change tagging. Made this configurable so it can be turned off if it looks like we're blowing up the tags system with the volume of VE edits. Change-Id: I63052d90772906e34021035de496a65fea7945f7
2012-11-22 02:26:29 +00:00
public static function onListDefinedTags( &$tags ) {
$tags[] = 'visualeditor';
mw.ViewPageTarget: Add sanity check for DOM roundtrip The sanity check converts the linear model back to DOM, then compares this DOM to the original DOM and rejects the deferred if they are not equal. The DOM creation has to be done synchronously (before we unlock the surface), but the actual comparsion can be (and is) done asynchronously. To make the UI flow of the save dialog easier we just keep the save button on the toolbar itself disabled until the sanity check is done. Though this should finish before the user starts editing the document (let alone start saving), we do add a class to the button to indicate a progress cursor. To simulate a slow sanity check, set the setTimeout in startSanityCheck to 5000, load VE, make a change, hover the button, and see it change from disabled + progress-cursor to enabled after 5 seconds. To simulate the sanity check failing, change !== to === in the first "if" in startSanityCheck. Bug: 47521 Bug: 50067 Change-Id: I04f71fe8e00c6257fbc953cc9de3323e24709b0f
2013-06-23 23:09:47 +00:00
$tags[] = 'visualeditor-needcheck';
(bug 42172) Tag edits made by VE Uses MW's built-in change tagging. Made this configurable so it can be turned off if it looks like we're blowing up the tags system with the volume of VE edits. Change-Id: I63052d90772906e34021035de496a65fea7945f7
2012-11-22 02:26:29 +00:00
return true;
}
Create base integration core module Works on VisualEditor Namespace Created VE api wrapper for parsoid service to roundtrip pages Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
2012-05-25 19:50:48 +00:00
/**
Refactored veCore class into ve.init and ve.init.EditPageTarget Change-Id: I52ef09aee38471ca49f3f4a845daf02e6dcc024c
2012-06-11 06:54:41 +00:00
* Adds extra variables to the page config.
Create base integration core module Works on VisualEditor Namespace Created VE api wrapper for parsoid service to roundtrip pages Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
2012-05-25 19:50:48 +00:00
*/
(bug 42136) Use user prefs to set initial state of "Watch this". * Don't show at all if user isn't logged in * Use "watch pages I create" and "watch pages I create" prefs * If the user is already watching it, use that Also updated relevant onMakeGlobalVariablesScript hook, it was using old globals still, the hook has context as of MediaWiki 1.19. Change-Id: Ic3daf32505a745b3cccd0663a03bbf7f3885be84
2012-12-06 05:57:53 +00:00
public static function onMakeGlobalVariablesScript( array &$vars, OutputPage $out ) {
Slight refactoring of global VE language variables Grouping multiple $out->getTitle()->getPageLanguage() calls and updating its use instead of the global $wgContLang Change-Id: I1bc0e83cbd31a95b1716665314e082d5ed9113ea
2013-11-08 16:19:15 +00:00
global $wgStylePath;
$pageLanguage = $out->getTitle()->getPageLanguage();
Refactored veCore class into ve.init and ve.init.EditPageTarget Change-Id: I52ef09aee38471ca49f3f4a845daf02e6dcc024c
2012-06-11 06:54:41 +00:00
$vars['wgVisualEditor'] = array(
Disabled VisualEditor section edit link overrides by default Server config: $wgVisualEditorEnableSectionEditLinks Client config: mw.config.get( 'wgVisualEditor' ).enableSectionEditLinks Change-Id: I859546475a32a686e318aa7108396606b5a0a78d
2012-12-12 23:35:33 +00:00
'isPageWatched' => $out->getUser()->isWatched( $out->getTitle() ),
Now we've got PHPCS switched on, kill long lines Lest PHPCS throws wobblies over unrelated changes in PHP files with underlying issues in their code style. Change-Id: Ifc4aec328d726e9ca62db34af55ea9592c08d9f3
2013-05-30 11:00:36 +00:00
// Same as in Linker.php
'magnifyClipIconURL' => $wgStylePath .
'/common/images/magnify-clip' .
Slight refactoring of global VE language variables Grouping multiple $out->getTitle()->getPageLanguage() calls and updating its use instead of the global $wgContLang Change-Id: I1bc0e83cbd31a95b1716665314e082d5ed9113ea
2013-11-08 16:19:15 +00:00
( $pageLanguage->isRTL() ? '-rtl' : '' ) . '.png',
'pageLanguageCode' => $pageLanguage->getHtmlCode(),
'pageLanguageDir' => $pageLanguage->getDir()
Move config vars that are global in nature to the startup module If they're in the per-page config, we'll have to deal with caching nightmares when changing them. Change-Id: Ic8866500b1f20aee36c436dcc3d132c8fde0a8fc
2013-04-17 16:48:09 +00:00
);
return true;
}
/**
* Adds extra variables to the global config
*/
public static function onResourceLoaderGetConfigVars( array &$vars ) {
ve.init.mw.ViewPageTarget.init: Pass default values Though this is already handled by Ie50b63ba5064e85d26 for the server-side, and that should automatically reflect to the client-side. Since we're dealing with cache conditions in wmf-production where the user.options manifest does not yet contain an entry for these relatively new preferences, lets transfer the default value here as well. This does not affect logged-in users (since their user options are always up-to-date and embedded in the page). Also made ve.support.es5 be casted to boolean. Previously it would be a reference to JSON.stringify (if supported), or the bottom value of whichever feature the browser didn't support. Doesn't change any behaviour but should make things slightly more performant when this value is evaluated. Change-Id: I9ca430051ae6f4e603c2d89982e540e455055255
2013-07-26 20:20:10 +00:00
global $wgDefaultUserOptions,
$wgVisualEditorDisableForAnons,
VisualEditor.hooks: Sort keys Change-Id: I68f9258f739532ca30d2fdc91e62d6a2f87a5180
2013-07-31 00:31:12 +00:00
$wgVisualEditorEnableExperimentalCode,
$wgVisualEditorNamespaces,
$wgVisualEditorPluginModules,
Move edit tab generation into PHP and make it more configurable * Generate the edit tabs and the section edit links in PHP, with a fallback in JS for cases where we don't have them yet due to caching. But only change things if VE is enabled, and have the JS correct the state if the wrong cached HTML comes through. * Make the order of the tabs/links and the messages to use as captions configurable * Make the edit tabs and section edit links always be present in the page (regardless of namespace, user prefs, etc.) but be hidden and have JS unhide them (using html.ve-available) if appropriate * Add appendix messages so we can do a superscript "beta" even in places where we can't use HTML in the message VisualEditor.php: * Add new hook registrations * Remove edit link caption messages from the init init module because they're now added dynamically in VisualEditor.hooks.php * Add a noscript CSS module so we can hide some things in JS-less environments * Remove $wgVisualEditorTabLayout and replace it with $wgVisualEditorPosition * Add config vars for link captions, with null causing us to use the default caption * Add config vars for link caption appendices. Too many config vars but we'll clean that up later VisualEditor.hooks.php: * Dynamically add tab messages to the init init module * Remove unused globals in onBeforePageDisplay() * Add noscript CSS module * Add a SkinTemplateNavigation hook that changes and reorders the edit tabs as appropriate * Add a DoEditSectionLink hook that overwrites the edit section links * Export the new config variables to JS VisualEditor.i18n.php: * Add beta appendix message * Add a message for the default VE edit section link ve.init.mw.ViewPageTarget.init.css: * Remove the animation on the edit section links * Darken the color of the brackets and the pipe from #ccc to #555 * Style the beta message to be superscript-like (but not real <sup> to avoid moving the baseline) ve.init.mw.ViewPageTarget.noscript.css: * Hide the VE edit tab, the pipe and the VE edit section link initally unless and until JS unhides ve.init.mw.ViewPageTarget.init.js: * Toggle .ve-not-available / .ve-available * Edit tabs ** Only generate the the edit tabs if they're not already there from PHP ** Rewrite the edit tab generation to mirror what's being done in PHP * Section edit links ** Same as for edit tabs ** Also add mw-visualeditor-expanded to pad the brackets ve.init.mw.ViewPageTarget.js: * #ca-ve-edit is now always the VE tab (and #ca-edit always the edit source tab) so update the .selected behavior accordingly Change-Id: Idcb15faea7fabe5fe7578b1508079969b27d2469
2013-08-01 19:14:41 +00:00
$wgVisualEditorTabPosition,
Beta welcome dialog For configured wikis, show a dialog that welcomes the user to the amazing and fantabulous world of VisualEditing, which is not only full of wonderment and joy but also may lead to increased popularity and love. The dialog only shows up once (uses a cookie). Change-Id: I8e7c4dc2c63b36594378a543b9d66291395eebcf
2013-08-01 20:18:33 +00:00
$wgVisualEditorTabMessages,
Add requirements to BetaFeatures hook Change-Id: Ifc809f49e1cf03015dbb295b6b092b4181edc38b
2013-10-10 12:33:49 +00:00
$wgVisualEditorBrowserBlacklist,
Move skin support into $wgVisualEditorSupportedSkins $supportedSkins is mostly an artefact of the currently-unrefactored init code that will have a sub-class for each skin (so skin's maintainers can add VisualEditor support without hacking around inside VisualEditor itself), but until then let's split it out into a global configuration variable at least, so that they have a hope. Change-Id: I0742cea6469678c5599768340dfb1f6d2f4debf4
2013-10-07 22:55:22 +00:00
$wgVisualEditorSupportedSkins,
Beta welcome dialog For configured wikis, show a dialog that welcomes the user to the amazing and fantabulous world of VisualEditing, which is not only full of wonderment and joy but also may lead to increased popularity and love. The dialog only shows up once (uses a cookie). Change-Id: I8e7c4dc2c63b36594378a543b9d66291395eebcf
2013-08-01 20:18:33 +00:00
$wgVisualEditorShowBetaWelcome;
mw.ViewPageTarget: Make tabLayout configurable server-side Bug: 46871 Change-Id: I3fcb0c2903ae62d61ff789b5504e0ea23932121b
2013-06-03 22:23:45 +00:00
Move config vars that are global in nature to the startup module If they're in the per-page config, we'll have to deal with caching nightmares when changing them. Change-Id: Ic8866500b1f20aee36c436dcc3d132c8fde0a8fc
2013-04-17 16:48:09 +00:00
$vars['wgVisualEditorConfig'] = array(
mw.ViewPageTarget.init: Move conditionals client-side Load the module always and have the conditionals on the client-side so that we can change these without running into problems with the new conditions not being rolled-out quickly for anonymous users because the load queue is in the HTML and cached for 30+ days. This also allows us to fix above problem retroactively in wmf production by just adding a mw.loader.load for this module in something like MediaWiki:Common.js or something else that is already in the cached load queue (temporarily, until the cache has rolled over). Removed unreachable code for loading ext.visualEditor.splitTest. Change-Id: I21114960a88d224747447f2dc83d17d160f5f066
2013-07-19 02:44:22 +00:00
'disableForAnons' => $wgVisualEditorDisableForAnons,
VisualEditor.hooks: Sort keys Change-Id: I68f9258f739532ca30d2fdc91e62d6a2f87a5180
2013-07-31 00:31:12 +00:00
'enableExperimentalCode' => $wgVisualEditorEnableExperimentalCode,
mw.ViewPageTarget.init: Move conditionals client-side Load the module always and have the conditionals on the client-side so that we can change these without running into problems with the new conditions not being rolled-out quickly for anonymous users because the load queue is in the HTML and cached for 30+ days. This also allows us to fix above problem retroactively in wmf production by just adding a mw.loader.load for this module in something like MediaWiki:Common.js or something else that is already in the cached load queue (temporarily, until the cache has rolled over). Removed unreachable code for loading ext.visualEditor.splitTest. Change-Id: I21114960a88d224747447f2dc83d17d160f5f066
2013-07-19 02:44:22 +00:00
'namespaces' => $wgVisualEditorNamespaces,
Infrastructure for loading plugins in the MW integration Server-side, plugins can register themselves by adding to $wgVisualEditorPluginModules. This is the recommended way for MW extensions to extend VE. Client-side, plugins can register themselves through mw.libs.ve.addPlugin(), which takes a string (RL module name) or a callback. When VisualEditor loads, we load the registered plugin modules in parallel with ext.visualEditor.core. Note that they're loaded in parallel, not after, and so the plugins should explicitly depend on ext.visualEditor.core if they use or extend classes in VE core. Once the modules finish loading and user and site scripts have run, we execute the registered plugin callbacks. These callbacks can optionally return a promise. We gather these promises and wait for all of them to be resolved, then initialize the editor. This allows Gadgets to extend VE by top-loading a small module that depends on ext.visualEditor.viewPageTarget.init and calls mw.libs.ve.addPlugin( 'ext.gadget.bottomHalfGadget' ); , the bottom half being a hidden Gadget that depends on ext.visualEditor.core and contains the actual code. The addPlugin() call needs to be in a top-loading module because otherwise there's no guarantee that the plugin will be registered before the user clicks edit and VE loads. User and site scripts can extend VE by simply calling addPlugin() directly, as mw.libs.ve is already present when user scripts run (since it's top-loaded) and VE waits for 'user' and 'site' to run before executing plugins. If user/site scripts need to load additional JS files, they can load these with $.getScript() and return the corresponding promise: mw.libs.ve.addPlugin( function() { return $.getScript( 'URL' ); } ); For a diagram of all this, see https://www.mediawiki.org/wiki/File:VE-plugin-infrastructure.jpg :) VisualEditor.php: * Add $wgVisualEditorPluginModules VisualEditor.hooks.php: * Expose $wgVisualEditorPluginModules in JS ve.init.mw.ViewPageTarget.init.js: * Add mw.libs.ve.addPlugin function that just stores the registered values in an array and passes them into the mw.Target when it's being initialized ve.init.mw.Target.js: * Add $wgVisualEditorPluginModules to the set of modules to load when initializing VE * Add a Deferred (this.modulesReady) to track module loading * Add addPlugin() and addPlugins() methods that add to either this.modules or this.pluginCallbacks * In load(), instead of mw.loader.load()ing this.modules, use using() to load this.modules plus user and site, and fire onModulesReady() when they're loaded * In onModulesReady(), execute the registered callbacks, gather the returned promises, wait for all of them to be resolved, then resolve this.modulesReady * Fire onReady based on this.modulesReady being resolved, rather than using a second using() call Bug: 50514 Change-Id: Ib7d87a17eaac6ecdb8b0803b13840d7ee58902df
2013-07-22 20:34:28 +00:00
'pluginModules' => $wgVisualEditorPluginModules,
ve.init.mw.ViewPageTarget.init: Pass default values Though this is already handled by Ie50b63ba5064e85d26 for the server-side, and that should automatically reflect to the client-side. Since we're dealing with cache conditions in wmf-production where the user.options manifest does not yet contain an entry for these relatively new preferences, lets transfer the default value here as well. This does not affect logged-in users (since their user options are always up-to-date and embedded in the page). Also made ve.support.es5 be casted to boolean. Previously it would be a reference to JSON.stringify (if supported), or the bottom value of whichever feature the browser didn't support. Doesn't change any behaviour but should make things slightly more performant when this value is evaluated. Change-Id: I9ca430051ae6f4e603c2d89982e540e455055255
2013-07-26 20:20:10 +00:00
'defaultUserOptions' => array(
'betatempdisable' => $wgDefaultUserOptions['visualeditor-betatempdisable'],
Integrate with BetaPreferences Look at logo Michael. Bug: 52686 Change-Id: I3cfada2ea264184698de5f322c1fe5041b37b8c8
2013-08-12 05:50:04 +00:00
'enable' => $wgDefaultUserOptions['visualeditor-enable'],
Generalise the way extra modules are loaded Change-Id: Icd453421b022a6450d1358edbe2132e49ca0b3bf
2013-10-11 13:04:11 +00:00
'enable-experimental' => $wgDefaultUserOptions['visualeditor-enable-experimental'],
Convert the mass Beta Feature into feature-level ones, enabling formulæ Make every module that was formerly part of the experimental module its own Beta Feature. For now, all of them are commented out except for formulæ editing (mwmath). The "experimental" Beta Feature bucket is no more, but the preference remains so that it can be set to both true and hidden on MediaWiki.org to let all the different experimental flags. The feature icons, previous mis-named "logo" and mis-identified as "screenshots" are now renamed. One for the mwmath Beta Feature has been added (the rest need creating before those can be enabled). The i18n descriptions now each identify that the feature is an experimental one, and that caution is needed. Change-Id: I28862f3e62f5c78aca33f11265aced1db67f4725
2013-10-21 23:06:10 +00:00
// 'enable-language' => $wgDefaultUserOptions['visualeditor-enable-language'],
// 'enable-mwalienextension' => $wgDefaultUserOptions['visualeditor-enable-mwalienextension'],
'enable-mwmath' => $wgDefaultUserOptions['visualeditor-enable-mwmath'],
// 'enable-mwhiero' => $wgDefaultUserOptions['visualeditor-enable-mwhiero'],
// 'enable-mwsyntaxHighlight' => $wgDefaultUserOptions['visualeditor-enable-mwsyntaxHighlight'],
ve.init.mw.ViewPageTarget.init: Pass default values Though this is already handled by Ie50b63ba5064e85d26 for the server-side, and that should automatically reflect to the client-side. Since we're dealing with cache conditions in wmf-production where the user.options manifest does not yet contain an entry for these relatively new preferences, lets transfer the default value here as well. This does not affect logged-in users (since their user options are always up-to-date and embedded in the page). Also made ve.support.es5 be casted to boolean. Previously it would be a reference to JSON.stringify (if supported), or the bottom value of whichever feature the browser didn't support. Doesn't change any behaviour but should make things slightly more performant when this value is evaluated. Change-Id: I9ca430051ae6f4e603c2d89982e540e455055255
2013-07-26 20:20:10 +00:00
),
Add requirements to BetaFeatures hook Change-Id: Ifc809f49e1cf03015dbb295b6b092b4181edc38b
2013-10-10 12:33:49 +00:00
'blacklist' => $wgVisualEditorBrowserBlacklist,
Move skin support into $wgVisualEditorSupportedSkins $supportedSkins is mostly an artefact of the currently-unrefactored init code that will have a sub-class for each skin (so skin's maintainers can add VisualEditor support without hacking around inside VisualEditor itself), but until then let's split it out into a global configuration variable at least, so that they have a hope. Change-Id: I0742cea6469678c5599768340dfb1f6d2f4debf4
2013-10-07 22:55:22 +00:00
'skins' => $wgVisualEditorSupportedSkins,
Move edit tab generation into PHP and make it more configurable * Generate the edit tabs and the section edit links in PHP, with a fallback in JS for cases where we don't have them yet due to caching. But only change things if VE is enabled, and have the JS correct the state if the wrong cached HTML comes through. * Make the order of the tabs/links and the messages to use as captions configurable * Make the edit tabs and section edit links always be present in the page (regardless of namespace, user prefs, etc.) but be hidden and have JS unhide them (using html.ve-available) if appropriate * Add appendix messages so we can do a superscript "beta" even in places where we can't use HTML in the message VisualEditor.php: * Add new hook registrations * Remove edit link caption messages from the init init module because they're now added dynamically in VisualEditor.hooks.php * Add a noscript CSS module so we can hide some things in JS-less environments * Remove $wgVisualEditorTabLayout and replace it with $wgVisualEditorPosition * Add config vars for link captions, with null causing us to use the default caption * Add config vars for link caption appendices. Too many config vars but we'll clean that up later VisualEditor.hooks.php: * Dynamically add tab messages to the init init module * Remove unused globals in onBeforePageDisplay() * Add noscript CSS module * Add a SkinTemplateNavigation hook that changes and reorders the edit tabs as appropriate * Add a DoEditSectionLink hook that overwrites the edit section links * Export the new config variables to JS VisualEditor.i18n.php: * Add beta appendix message * Add a message for the default VE edit section link ve.init.mw.ViewPageTarget.init.css: * Remove the animation on the edit section links * Darken the color of the brackets and the pipe from #ccc to #555 * Style the beta message to be superscript-like (but not real <sup> to avoid moving the baseline) ve.init.mw.ViewPageTarget.noscript.css: * Hide the VE edit tab, the pipe and the VE edit section link initally unless and until JS unhides ve.init.mw.ViewPageTarget.init.js: * Toggle .ve-not-available / .ve-available * Edit tabs ** Only generate the the edit tabs if they're not already there from PHP ** Rewrite the edit tab generation to mirror what's being done in PHP * Section edit links ** Same as for edit tabs ** Also add mw-visualeditor-expanded to pad the brackets ve.init.mw.ViewPageTarget.js: * #ca-ve-edit is now always the VE tab (and #ca-edit always the edit source tab) so update the .selected behavior accordingly Change-Id: Idcb15faea7fabe5fe7578b1508079969b27d2469
2013-08-01 19:14:41 +00:00
'tabPosition' => $wgVisualEditorTabPosition,
'tabMessages' => $wgVisualEditorTabMessages,
Beta welcome dialog For configured wikis, show a dialog that welcomes the user to the amazing and fantabulous world of VisualEditing, which is not only full of wonderment and joy but also may lead to increased popularity and love. The dialog only shows up once (uses a cookie). Change-Id: I8e7c4dc2c63b36594378a543b9d66291395eebcf
2013-08-01 20:18:33 +00:00
'showBetaWelcome' => $wgVisualEditorShowBetaWelcome,
Refactored veCore class into ve.init and ve.init.EditPageTarget Change-Id: I52ef09aee38471ca49f3f4a845daf02e6dcc024c
2012-06-11 06:54:41 +00:00
);
(bug 42136) Use user prefs to set initial state of "Watch this". * Don't show at all if user isn't logged in * Use "watch pages I create" and "watch pages I create" prefs * If the user is already watching it, use that Also updated relevant onMakeGlobalVariablesScript hook, it was using old globals still, the hook has context as of MediaWiki 1.19. Change-Id: Ic3daf32505a745b3cccd0663a03bbf7f3885be84
2012-12-06 05:57:53 +00:00
Add MakeGlobalVariablesScript hook to add new global, vePageWatched. This allows us to check the watchlist checkbox on save dialog. Added watchlist toggling to ve save api. Added some i18n messages to core integration. Change-Id: Ibed8edb2c59ad49e1738c937c3bea518238d0845
2012-06-01 23:26:03 +00:00
return true;
}
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
Conditionally register oojs and oojs-ui Only register them if they aren't already registered, so we're compatible with versions of MW core with and without oojs. Change-Id: I5dbb480e8330ceaf0531c194b8ef6cc6c65f537e
2013-12-05 02:28:59 +00:00
/**
* Conditionally register the oojs and oojs-ui modules, in case they've already been registered
* by a more recent version of MediaWiki core.
Use proper conditional registration for jquery.uls Previously worked by checking for the UniversalLanguageSelector extension, now actually checks for the modules themselves. Change-Id: I99b1bfabb1953579d3aaa661ab0a4d824a7fe656
2013-12-05 22:45:44 +00:00
*
Add jquery.i18n files and RL module Imported 09f7c9e40fc3bd502 from https://github.com/wikimedia/jquery.i18n/tree/09f7c9e40fc3bd502 Change-Id: I9bc4759202a0475bcf52230e0c57a877cc848773
2013-12-05 22:08:29 +00:00
* Also conditionally register the jquery.uls and jquery.i18n modules, in case they've already
* been registered by the UniversalLanguageSelector extension.
Use proper conditional registration for jquery.uls Previously worked by checking for the UniversalLanguageSelector extension, now actually checks for the modules themselves. Change-Id: I99b1bfabb1953579d3aaa661ab0a4d824a7fe656
2013-12-05 22:45:44 +00:00
*
Conditionally register oojs and oojs-ui Only register them if they aren't already registered, so we're compatible with versions of MW core with and without oojs. Change-Id: I5dbb480e8330ceaf0531c194b8ef6cc6c65f537e
2013-12-05 02:28:59 +00:00
* @param ResourceLoader $resourceLoader
* @returns boolean true
*/
public static function onResourceLoaderRegisterModules( ResourceLoader &$resourceLoader ) {
global $wgResourceModules, $wgVisualEditorResourceTemplate;
if ( !isset( $wgResourceModules['oojs'] ) && !$resourceLoader->getModule( 'oojs' ) ) {
$resourceLoader->register( 'oojs', $wgVisualEditorResourceTemplate + array(
'scripts' => array(
'oojs/oojs.js',
),
'targets' => array( 'desktop', 'mobile' ),
) );
}
if ( !isset( $wgResourceModules['oojs-ui'] ) && !$resourceLoader->getModule( 'oojs-ui' ) ) {
$resourceLoader->register( 'oojs-ui', $wgVisualEditorResourceTemplate + array(
'scripts' => array(
'oojs-ui/oojs-ui.js',
),
'styles' => array(
'oojs-ui/oojs-ui.svg.css',
),
'messages' => array(
'ooui-dialog-action-close',
'ooui-outline-control-move-down',
'ooui-outline-control-move-up',
'ooui-toggle-on',
'ooui-toggle-off',
'ooui-toolbar-more',
),
'dependencies' => array(
'oojs'
),
'targets' => array( 'desktop', 'mobile' ),
) );
}
Use proper conditional registration for jquery.uls Previously worked by checking for the UniversalLanguageSelector extension, now actually checks for the modules themselves. Change-Id: I99b1bfabb1953579d3aaa661ab0a4d824a7fe656
2013-12-05 22:45:44 +00:00
if ( !isset( $wgResourceModules['jquery.uls'] ) && !$resourceLoader->getModule( 'jquery.uls' ) ) {
$resourceLoader->register( 'jquery.uls', $wgVisualEditorResourceTemplate + array(
'scripts' => array(
'jquery.uls/src/jquery.uls.core.js',
'jquery.uls/src/jquery.uls.lcd.js',
'jquery.uls/src/jquery.uls.languagefilter.js',
'jquery.uls/src/jquery.uls.regionfilter.js',
),
'styles' => array(
'jquery.uls/css/jquery.uls.css',
'jquery.uls/css/jquery.uls.lcd.css',
),
'dependencies' => array(
'jquery.uls.grid',
'jquery.uls.data',
'jquery.uls.compact',
),
) );
}
if (
!isset( $wgResourceModules['jquery.uls.data'] ) &&
!$resourceLoader->getModule( 'jquery.uls.data' )
) {
$resourceLoader->register( 'jquery.uls.data', $wgVisualEditorResourceTemplate + array(
'scripts' => array(
'jquery.uls/src/jquery.uls.data.js',
'jquery.uls/src/jquery.uls.data.utils.js',
),
'position' => 'top',
) );
}
if (
!isset( $wgResourceModules['jquery.uls.grid'] ) &&
!$resourceLoader->getModule( 'jquery.uls.grid' )
) {
$resourceLoader->register( 'jquery.uls.grid', $wgVisualEditorResourceTemplate + array(
'styles' => 'jquery.uls/css/jquery.uls.grid.css',
'position' => 'top',
) );
}
if (
!isset( $wgResourceModules['jquery.uls.compact'] ) &&
!$resourceLoader->getModule( 'jquery.uls.compact' )
) {
$resourceLoader->register( 'jquery.uls.compact', $wgVisualEditorResourceTemplate + array(
'styles' => 'jquery.uls/css/jquery.uls.compact.css',
'position' => 'top',
) );
}
Add jquery.i18n files and RL module Imported 09f7c9e40fc3bd502 from https://github.com/wikimedia/jquery.i18n/tree/09f7c9e40fc3bd502 Change-Id: I9bc4759202a0475bcf52230e0c57a877cc848773
2013-12-05 22:08:29 +00:00
if (
!isset( $wgResourceModules['jquery.i18n'] ) &&
!$resourceLoader->getModule( 'jquery.i18n' )
) {
$resourceLoader->register( 'jquery.i18n', $wgVisualEditorResourceTemplate + array(
'scripts' => array(
'jquery.i18n/src/jquery.i18n.js',
'jquery.i18n/src/jquery.i18n.messages.js',
'jquery.i18n/src/jquery.i18n.parser.js',
'jquery.i18n/src/jquery.i18n.emitter.js',
'jquery.i18n/src/jquery.i18n.language.js',
),
'dependencies' => 'mediawiki.libs.pluralruleparser',
'languageScripts' => array(
'bs' => 'jquery.i18n/src/languages/bs.js',
'dsb' => 'jquery.i18n/src/languages/dsb.js',
'fi' => 'jquery.i18n/src/languages/fi.js',
'ga' => 'jquery.i18n/src/languages/ga.js',
'he' => 'jquery.i18n/src/languages/he.js',
'hsb' => 'jquery.i18n/src/languages/hsb.js',
'hu' => 'jquery.i18n/src/languages/hu.js',
'hy' => 'jquery.i18n/src/languages/hy.js',
'la' => 'jquery.i18n/src/languages/la.js',
'ml' => 'jquery.i18n/src/languages/ml.js',
'os' => 'jquery.i18n/src/languages/os.js',
'ru' => 'jquery.i18n/src/languages/ru.js',
'sl' => 'jquery.i18n/src/languages/sl.js',
'uk' => 'jquery.i18n/src/languages/uk.js',
),
) );
}
Conditionally register oojs and oojs-ui Only register them if they aren't already registered, so we're compatible with versions of MW core with and without oojs. Change-Id: I5dbb480e8330ceaf0531c194b8ef6cc6c65f537e
2013-12-05 02:28:59 +00:00
return true;
}
Now we've got PHPCS switched on, kill long lines Lest PHPCS throws wobblies over unrelated changes in PHP files with underlying issues in their code style. Change-Id: Ifc4aec328d726e9ca62db34af55ea9592c08d9f3
2013-05-30 11:00:36 +00:00
public static function onResourceLoaderTestModules(
array &$testModules,
ResourceLoader &$resourceLoader
) {
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
$testModules['qunit']['ext.visualEditor.test'] = array(
Use jsdifflib for QUnit diff Because QUnit's inline diff is terrible for large diffs, especially when there are block whitespaces changes. Change-Id: I786fb981b02777ede38c4bee261f9e32f8f908ed
2013-09-30 12:11:49 +00:00
'styles' => array(
// jsdifflib
'jsdifflib/diffview.css',
),
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
'scripts' => array(
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
// MW config preload
've-mw/test/mw-preload.js',
Use jsdifflib for QUnit diff Because QUnit's inline diff is terrible for large diffs, especially when there are block whitespaces changes. Change-Id: I786fb981b02777ede38c4bee261f9e32f8f908ed
2013-09-30 12:11:49 +00:00
// jsdifflib
'jsdifflib/diffview.js',
'jsdifflib/difflib.js',
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
// QUnit plugin
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/ve.qunit.js',
Run UnicodeJS tests from Special:JavaScriptTest/qunit Previously they were only run from the dedicated standalone test which meant they weren't being run from Jenkins. Change-Id: If22456f0031c68b0c1e7621b35b1e79c0664da15
2013-07-16 22:45:11 +00:00
// UnicodeJS Tests
'unicodejs/test/unicodejs.test.js',
'unicodejs/test/unicodejs.graphemebreak.test.js',
'unicodejs/test/unicodejs.wordbreak.test.js',
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
// VisualEditor Tests
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/ve.test.utils.js',
've/test/ve.test.js',
've/test/ve.Document.test.js',
've/test/ve.Node.test.js',
've/test/ve.BranchNode.test.js',
've/test/ve.LeafNode.test.js',
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
// VisualEditor DataModel Tests
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/dm/ve.dm.example.js',
've/test/dm/ve.dm.AnnotationSet.test.js',
've/test/dm/ve.dm.NodeFactory.test.js',
've/test/dm/ve.dm.Node.test.js',
've/test/dm/ve.dm.Converter.test.js',
've/test/dm/ve.dm.BranchNode.test.js',
've/test/dm/ve.dm.LeafNode.test.js',
've/test/dm/ve.dm.LinearData.test.js',
've/test/dm/nodes/ve.dm.TextNode.test.js',
've-mw/test/dm/nodes/ve.dm.MWTransclusionNode.test.js',
've/test/dm/ve.dm.Document.test.js',
've/test/dm/ve.dm.DocumentSynchronizer.test.js',
've/test/dm/ve.dm.IndexValueStore.test.js',
've/test/dm/ve.dm.InternalList.test.js',
Actually run all the tests Some of the ones that were moved to ve-mw disappeared from index.php (the MW-only test runner) and/or VisualEditor.hooks.php (the runner for Special:JavaScriptTest that's also used by Jenkins). Add the missing tests, and rename the SurfaceFragment test. We can't add the ViewPageTarget test to the index.php file in ve-mw because it only works when running inside an actual MediaWiki instance. Change-Id: Iec34f2029f5f9c34855b4d79ef70db5751461a96
2013-07-11 02:36:55 +00:00
've-mw/test/dm/ve.dm.InternalList.test.js',
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/dm/ve.dm.Transaction.test.js',
Introduce newFromDocumentReplace() transaction builder Replaces newFromNodeReplacement(). newFromNodeReplacement was very simplistic and didn't support metadata or internal list items, so if you had comments or references inside of the data you were editing (reference contents or an image caption), they'd get mangled. With this, you can do: newDoc = doc.getDocumentSlice( node ); // Edit newDoc tx = ve.dm.Transaction.newFromDocumentReplace( doc, node, newDoc ); surface.change( newDoc ); and that takes care of metadata, internal list items, and things like references that reference internal list items. ve.dm.Document.js: * In getDocumentSlice(), store a reference to the original document and the number of items in its InternalList at the time of slicing in the created slice. This is used for reconciliation when the modified slice is injected back into the parent document with newFromDocumentReplace(). ve.dm.InternalList.js: * Add a method for merging in another InternalList. This provides a mapping from old to new InternalList indexes so the linear model data being injected by newFromDocumentReplace() can have its InternalList indexes remapped. ve.dm.Transaction.js: * Replace newFromNodeReplacement() with newFromDocumentReplace() ve.ui.MWMediaEditDialog.js, ve.ui.MWReferenceDialog.js: * Use getDocumentSlice/newFromDocumentReplace for editing captions/refs * Change insertion code path to insert an empty internalItem/caption, then newFromDocumentReplace into that * Add empty internalList to new mini-documents ve/test/dm/ve.dm.Transaction.test.js: * Replace newFromNodeReplacement tests with newFromDocumentReplace tests ve-mw/test/dm/ve.dm.Transaction.test.js (new): * Add tests for newFromDocumentReplace with mwReference nodes ve.dm.mwExample.js: * Add data for newFromDocumentReplace with mwReference tests VisualEditor.hooks.php: * Add new test file Bug: 52102 Change-Id: I4aa980780114b391924f04df588e81c990c32983
2013-09-05 01:05:07 +00:00
've-mw/test/dm/ve.dm.Transaction.test.js',
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/dm/ve.dm.TransactionProcessor.test.js',
've/test/dm/ve.dm.Surface.test.js',
've/test/dm/ve.dm.SurfaceFragment.test.js',
Actually run all the tests Some of the ones that were moved to ve-mw disappeared from index.php (the MW-only test runner) and/or VisualEditor.hooks.php (the runner for Special:JavaScriptTest that's also used by Jenkins). Add the missing tests, and rename the SurfaceFragment test. We can't add the ViewPageTarget test to the index.php file in ve-mw because it only works when running inside an actual MediaWiki instance. Change-Id: Iec34f2029f5f9c34855b4d79ef70db5751461a96
2013-07-11 02:36:55 +00:00
've-mw/test/dm/ve.dm.SurfaceFragment.test.js',
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/dm/ve.dm.ModelRegistry.test.js',
've/test/dm/ve.dm.MetaList.test.js',
've/test/dm/ve.dm.Model.test.js',
Organise Flat/ElementLinearData methods and tests Move containsElementData to FlatLinearData next to isElementData. Move tests for both methods to FlatLinearData.test.js. Change-Id: I07a192f5925da7cc763efe5e41427f1f47d85850
2013-12-10 17:39:57 +00:00
've/test/dm/lineardata/ve.dm.FlatLinearData.test.js',
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/dm/lineardata/ve.dm.ElementLinearData.test.js',
've/test/dm/lineardata/ve.dm.MetaLinearData.test.js',
've-mw/test/dm/ve.dm.mwExample.js',
've-mw/test/dm/ve.dm.MWConverter.test.js',
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
// VisualEditor ContentEditable Tests
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/ce/ve.ce.test.js',
've/test/ce/ve.ce.Document.test.js',
Tests for handleDelete in ve.ce.Surface Trigger fake delete/backspace events and assert changes to the DM. Change-Id: I69659a3e49b6520376cac3c795e8a96e7fbda9ae
2013-09-23 16:40:58 +00:00
've/test/ce/ve.ce.Surface.test.js',
Actually run all the tests Some of the ones that were moved to ve-mw disappeared from index.php (the MW-only test runner) and/or VisualEditor.hooks.php (the runner for Special:JavaScriptTest that's also used by Jenkins). Add the missing tests, and rename the SurfaceFragment test. We can't add the ViewPageTarget test to the index.php file in ve-mw because it only works when running inside an actual MediaWiki instance. Change-Id: Iec34f2029f5f9c34855b4d79ef70db5751461a96
2013-07-11 02:36:55 +00:00
've-mw/test/ce/ve.ce.Document.test.js',
Prevent deletion of FocusableNodes from a collapsed selection Instead select the node and require the user to press delete again if they really meant to delete the node. Also test cases! Bug: 55336 Change-Id: I66520e18740e78ce6313f9b31bb575d06b91bea8
2013-10-05 10:27:39 +00:00
've-mw/test/ce/ve.ce.Surface.test.js',
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/ce/ve.ce.NodeFactory.test.js',
've/test/ce/ve.ce.Node.test.js',
've/test/ce/ve.ce.BranchNode.test.js',
've/test/ce/ve.ce.ContentBranchNode.test.js',
Actually run all the tests Some of the ones that were moved to ve-mw disappeared from index.php (the MW-only test runner) and/or VisualEditor.hooks.php (the runner for Special:JavaScriptTest that's also used by Jenkins). Add the missing tests, and rename the SurfaceFragment test. We can't add the ViewPageTarget test to the index.php file in ve-mw because it only works when running inside an actual MediaWiki instance. Change-Id: Iec34f2029f5f9c34855b4d79ef70db5751461a96
2013-07-11 02:36:55 +00:00
've-mw/test/ce/ve.ce.ContentBranchNode.test.js',
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/ce/ve.ce.LeafNode.test.js',
've/test/ce/nodes/ve.ce.TextNode.test.js',
ve.Editor Objectives: * Split ve.Surface into ve.Editor and ve.ui.Surface * Move actions, triggers and commands to ve.ui * Move toolbar wrapping, floating, shadow and actions functionality to configurable options of ve.ui.Toolbar * Make ve.ce.Surface and ve.ui.Surface inherit ve.Element and use this.$$ for iframe friendliness * Make the toolbar separately initialized so it's possible to have a surface without one, as well as control where the toolbar is Some change notes: VisualEditor.php * Added standalone module for mediawiki integrated unit testing ve.ce.Surface.js * Remove requirement to pass in an attached container to construct object * Inherit ve.Element and use this.$$ instead of $ * Make getSelectionRect iframe friendly * Move most of the initialize stuff to a new initialize method to be called after the surface is attached to the DOM ve.init.mw.ViewPageTarget.js * Merge toolbar functions into setup/teardown methods * Add toolbar manually (since it's not added by the surface anymore) ve.init.sa.Target.js * Update new init procedure for editor, surface and toolbar separately * Move toolbar floating stuff to ve.Toolbar Change-Id: If91a9d6e76a8be8d1b5a2566394765a37d29a8a7
2013-05-14 23:45:42 +00:00
// VisualEditor Actions Tests
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/ui/actions/ve.ui.FormatAction.test.js',
Actually run all the tests Some of the ones that were moved to ve-mw disappeared from index.php (the MW-only test runner) and/or VisualEditor.hooks.php (the runner for Special:JavaScriptTest that's also used by Jenkins). Add the missing tests, and rename the SurfaceFragment test. We can't add the ViewPageTarget test to the index.php file in ve-mw because it only works when running inside an actual MediaWiki instance. Change-Id: Iec34f2029f5f9c34855b4d79ef70db5751461a96
2013-07-11 02:36:55 +00:00
've-mw/test/ui/actions/ve.ui.FormatAction.test.js',
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/ui/actions/ve.ui.IndentationAction.test.js',
've/test/ui/actions/ve.ui.ListAction.test.js',
init.Platform: Refactor parsed messages. Rewrite VisualEditorMessagesModule: * Replace copy-paste dump of user-css module with stuff for VisualEditor (class commend and module::$origin). * Remove duplication between getMessages and getScript. * Actually implement getModifiedTime so that the comment in getMessages() about cache invalidation is actually true Fixes bug 42670: ext.visualEditor.specialMessages cache broken ve.init: * Implement addParsedMessages and getParsedMessage so that we don't mix up plain messages with raw html messages (minoredit was previously overloaded in mw.msg storage with a parsed html message and retrieved though ve.msg, which is documented as retuning plain text, not raw html). This is now separated into a different method. * Improved documentation of the other msg methods to emphasise their differences * Removed redundant code in attachSaveDialog() that was (partially) already done in setupSaveDialog() and moved the remaining bits into it as well. Checked all callers of these and they are both only called from ViewPageTarget.prototype.onLoad * Also implement them in the standalone platform implementation, with the html escaper based on mw.html.escape * Update init.platform.getMessage to use undefined instead of discouraged 'if-in' statement. * Add test suite. demos/test: * Re-run makeStaticLoader.php on test to add ve.init.Platform.test * Re-run makeStaticLoader.php on demos and update i18n caller to use ve.init.platform.addParsedMessages (also moved out of the auto-generated block for easier updating) Change-Id: I7f26b47e9467e850c08b9c217c4f1098590de109
2012-12-04 06:56:41 +00:00
// VisualEditor initialization Tests
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
've/test/init/ve.init.Platform.test.js',
've-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js',
Event Logger: collect IME functionality info ve/ce/SurfaceObserver.js * Do not setTimeout if frequency === null demos/ve/eventLogger.html * Standalone event logging script ve/test/ce/imetests/*.js * JSON event logs for various tests/browsers/IMEs ve/test/ce/ve.ce.test.js * Add an IME test VisualEditor.hooks.php * Add test files Change-Id: I50e89d5a289f3fcb4fe2a6835a2ec96fb497242c
2013-09-06 19:25:21 +00:00
// IME tests
've/test/ce/ve.ce.TestRunner.js',
've/test/ce/ve.ce.imetests.test.js',
've/test/ce/imetests/backspace-chromium-ubuntu-none.js',
've/test/ce/imetests/backspace-firefox-ubuntu-none.js',
've/test/ce/imetests/backspace-ie-win-none.js',
've/test/ce/imetests/input-chrome-win-chinese-traditional-handwriting.js',
've/test/ce/imetests/input-chrome-win-greek.js',
've/test/ce/imetests/input-chrome-win-welsh.js',
've/test/ce/imetests/input-chromium-ubuntu-ibus-chinese-cantonese.js',
've/test/ce/imetests/input-chromium-ubuntu-ibus-japanese-anthy--hiraganaonly.js',
've/test/ce/imetests/input-chromium-ubuntu-ibus-korean-korean.js',
've/test/ce/imetests/input-chromium-ubuntu-ibus-malayalam-swanalekha.js',
've/test/ce/imetests/input-firefox-ubuntu-ibus-chinese-cantonese.js',
've/test/ce/imetests/input-firefox-ubuntu-ibus-japanese-anthy--hiraganaonly.js',
've/test/ce/imetests/input-firefox-ubuntu-ibus-korean-korean.js',
've/test/ce/imetests/input-firefox-ubuntu-ibus-malayalam.swanalekha.js',
've/test/ce/imetests/input-firefox-win-chinese-traditional-handwriting.js',
've/test/ce/imetests/input-firefox-win-greek.js',
've/test/ce/imetests/input-firefox-win-welsh.js',
've/test/ce/imetests/input-ie-win-chinese-traditional-handwriting.js',
've/test/ce/imetests/input-ie-win-greek.js',
've/test/ce/imetests/input-ie-win-korean.js',
've/test/ce/imetests/input-ie-win-welsh.js',
've/test/ce/imetests/leftarrow-chromium-ubuntu-none.js',
've/test/ce/imetests/leftarrow-firefox-ubuntu-none.js',
've/test/ce/imetests/leftarrow-ie-win-none.js',
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
),
'dependencies' => array(
Run UnicodeJS tests from Special:JavaScriptTest/qunit Previously they were only run from the dedicated standalone test which meant they weren't being run from Jenkins. Change-Id: If22456f0031c68b0c1e7621b35b1e79c0664da15
2013-07-16 22:45:11 +00:00
'unicodejs.wordbreak',
ve.Editor Objectives: * Split ve.Surface into ve.Editor and ve.ui.Surface * Move actions, triggers and commands to ve.ui * Move toolbar wrapping, floating, shadow and actions functionality to configurable options of ve.ui.Toolbar * Make ve.ce.Surface and ve.ui.Surface inherit ve.Element and use this.$$ for iframe friendliness * Make the toolbar separately initialized so it's possible to have a surface without one, as well as control where the toolbar is Some change notes: VisualEditor.php * Added standalone module for mediawiki integrated unit testing ve.ce.Surface.js * Remove requirement to pass in an attached container to construct object * Inherit ve.Element and use this.$$ instead of $ * Make getSelectionRect iframe friendly * Move most of the initialize stuff to a new initialize method to be called after the surface is attached to the DOM ve.init.mw.ViewPageTarget.js * Merge toolbar functions into setup/teardown methods * Add toolbar manually (since it's not added by the surface anymore) ve.init.sa.Target.js * Update new init procedure for editor, surface and toolbar separately * Move toolbar floating stuff to ve.Toolbar Change-Id: If91a9d6e76a8be8d1b5a2566394765a37d29a8a7
2013-05-14 23:45:42 +00:00
'ext.visualEditor.standalone',
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
'ext.visualEditor.core',
Separate experimental features out into a new module Currently some issues, probably with loading nodes after factories. Toggled by global $wgVisualEditorEnableExperimentalCode. Change-Id: Idab3dd68572c037289c6742d03fd327285110f67
2013-04-16 17:31:17 +00:00
'ext.visualEditor.experimental',
Split off setup from the rest of mw.ViewPageTarget Initialisation initialisation? It's time to rename ve.init to ve.platform and ve.init.Platform to ve.platform.Environment, but that'll come later. * Moved support detection and skin set up to separate class-less file. * Swapped usage of ve.msg for mw.msg. * Callback of edit tab now does an mw.loader call to fetch the actual VisualEditor libraries. Though mw.loader won't load the same thing twice, we would bind a callback each time. To avoid instantiating ViewPageTarget more than once we use a Deferred. Bug: 50542 Bug: 50608 Bug: 50612 Change-Id: Ic8b0004ab5288fa91bb29d496485b93ffd8d977e
2013-07-03 22:14:52 +00:00
'ext.visualEditor.viewPageTarget.init',
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
'ext.visualEditor.viewPageTarget',
),
Use __DIR__ instead of dirname( __FILE__ ) Change-Id: I7ea4cb82ec7b3c6077a7485b0fb618d4c1dd00f9
2013-11-20 09:33:52 +00:00
'localBasePath' => __DIR__ . '/modules',
The great directory split of 2013 Move all MW-specific files into the ve-mw directory, in preparation for moving them out into a separate repo. All MW-specific files were moved into a parallel directory structure in modules/ve-mw . Files with both generic and MW-specific things were split up. Files in ve/init/mw/ were moved to ve-mw/init/ rather than ve-mw/init/mw ; they're still named ve.init.mw.* but we should change that. Some of the test files for core classes had MW-specific test cases, so those were split up and the test runner was duplicated; we should refactor our tests to use data providers so we can add cases more easily. Split files: * ve.ce.Node.css * ve.ce.ContentBranchNode.test.js (MWEntityNode) * ve.ce.Document.test.js (some core test cases genericized) * ve.dm.InternalList.test.js (uses mwReference test document) * ve.dm.SurfaceFragment.test.js, ve.ui.FormatAction.test.js ** Made core tests use heading instead of mwHeading ** Updated core tests because normal headings don't break out of lists ** Moved test runners into ve.test.utils.js * ve.ui.Icons-*.css * ve.ui.Dialog.css (MW parts into ve.ui.MWDialog.css) * ve.ui.Tool.css * ve.ui.Widget.css (move ve-ui-rtl and ve-ui-ltr to ve.ui.css) ve.dm.Converter.test.js: Moved runner functions into ve.test.utils.js ve.dm.example.js: * Refactored createExampleDocument so mwExample can use it * Removed wgExtensionAssetsPath detection, moved into mw-preload.js * Genericized withMeta example document (original version copied to mwExample) * Moved references example document to mwExample ve.dm.mwExample.js: * Move withMeta and references example documents from ve.dm.example.js * Add createExampleDocument function ve-mw/test/index.php: Runner for MW-specific tests only ve-mw/test/mw-preload.js: Sets VE_TESTDIR for Special:JavaScriptTest only ve.ui.Window.js: * Remove magic path interpolation in addLocalStyleSheets() * Pass full(er) paths to addLocalStyleSheets(), here and in subclasses ve.ui.MWDialog.js: Subclass of Dialog that adds MW versions of stylesheets ve.ui.MW*Dialog.js: * Subclass MWDialog rather than Dialog * Load both core and MW versions of stylesheets that have both ve.ui.PagedDialog.js: Converted to a mixin rather than an abstract base class * Don't inherit ve.ui.Dialog * Rather than overriding initialize(), provide initializePages() which the host class is supposed to call from its initialize() * Rename onOutlineSelect to onPageOutlineSelect ve.ui.MWMetaDialog.js, ve.ui.MWTransclusionDialog.js: * Use PagedDialog as a mixin rather than a base class, inherit MWDialog bullet-icon.png: Unused, deleted Stuff we should do later: * Refactor tests to use data providers * Write utility function for SVG compat check * Separate omnibus CSS files such as ve.ui.Widget.css * Separate omnibus RL modules * Use icon classes in ViewPageTarget Change-Id: I1b28f8ba7f2d2513e5c634927a854686fb9dd5a5
2013-07-03 01:30:10 +00:00
'remoteExtPath' => 'VisualEditor/modules',
Register QUnit tests suites in MediaWiki to run from Special:JavaScriptTest * Also update test/index.html with latest minimalistic format * Update test suite hardcoded paths to match the definition in VisualEditor.php for ResourceLoader * Issues: - 'jquery/jquery.json.js' should not be loaded directly, using a dependency instead. - Load scripts from the <head> in test/index.html so that code that depends on document being ready is catches instead of silently being ignored. Change-Id: I5ad7390137f4d17c153a1bf69f19c4869c08e323
2012-07-27 23:43:27 +00:00
);
return true;
}
Don't break core's parserTests if VisualEditor is installed VisualEditor's hook changes the edit section link, which changes the output of certain parser tests so that they no longer match the expected text. Use the `ParserTestsGlobal` hook (which cleans up after itself when the parserTests ends) to disable the `onDoEditSectionLink` hook when we're running parserTests to avoid the spurious failures. Change-Id: Ic958d88f443ac37ba304d3256e2bb5ea2fde820d
2013-09-16 21:12:50 +00:00
/**
* Ensures that we know whether we're running inside a parser test.
*/
public static function onParserTestGlobals( array &$settings ) {
$settings['wgVisualEditorInParserTests'] = true;
}
Create base integration core module Works on VisualEditor Namespace Created VE api wrapper for parsoid service to roundtrip pages Change-Id: I3f2967730c1a3ece31b7262a46bef31ea8b38613
2012-05-25 19:50:48 +00:00
}
Reference in a new issue Copy permalink