It's shorter, and allows us to take advantage of any future improvements
to setGroupPermissions, such as automatically resetting affected
services.
Change-Id: Ie2d1ea65c0cb334bbde1666d00781474b7ac4dab
The test suite set $wgTitleBlacklistSources with a fixture source of
directories. Unfortunately when running tests from MediaWiki core the
TitleBlacklist has already been set with empty value and thus setting
the global is a noop.
That later causes a test to fail because the blacklist is emtpy.
Add TitleBlacklistTest::destroySingleton() so a test can reset the
singleton when changing $wgTitleBlacklistSources.
Since that is solely for testing, throw an exception unless we had
MW_PHPUNIT_TEST defined.
Bug: T155980
Change-Id: I99c3185811ed7b2225953fa6960096985e97c4d2
I guess this only ever worked before because none of the other tests
depended on these globals. Now that AuthManager is enabled by default,
one does.
Change-Id: If335fcc9b844a518b2c56bfa39153159261ae314
Introduces a new "antispoof" parameter. If set, try to normalize
the title using the AntiSpoof extension.
Bug: 53901
Change-Id: I9b3c5f5f5d9eeda65562fd83e21c9c2ba97e5569
* Name all sources and track them inside the entries. This should be
fully backwards-compatible with previous configuration format,
since numbers may be a legitimate source names as well.
* Introduce $wgTitleBlacklistUsernameSources as a variable which allows
to specify which sources may be used for filtering usernames.
Change-Id: Ia2702370c85f317c763e345c8f92cb38e23e4196
I've fixed four issue with the API of this extension:
1. The extension always assumed the user wants to override the
blacklist, if he's allowed to do so, but that's not the case.
Introduced 'tbnooverride' to prevent that.
2. The API used actions not internally supported by
TitleBlacklistEntry::matches() which made it impossible to check
whether an account name is ok, if the regexp which would prevent
this was set to new account only. Therefore I've introduced the
new action 'new-account'.
3. Same as 2 for the 'upload'
4. The API always returned the 'titleblacklist-forbidden-edit'
message, even if there was a more suitable one. Fixed that.
Example:
https://meta.wikimedia.org/w/api.php?action=titleblacklist&tbtitle=User:Steward&tbaction=create
(this should match the expression .*steward.* <newaccountonly> on
https://meta.wikimedia.org/wiki/Title_blacklist but it doesn't)
Furthermore I've adjusted the unit tests slightly to test whether
tboverride works and whether <newaccountonly> works.
Change-Id: I2d948c84de39c6ee1c1eea7e6cd7b31506d6cb92
