E.g. reducing deep indention and code duplication. Removing comments
that literally repeat what the code says.
The goal is to make the code easier to read and to maintain in the
future. I hope this is the case.
Change-Id: I6f23bc61ffb8b6d42ec697fec91bb6c92152561f
WikiPage::factory() is deprecated since 1.36 and should be replaced
with WikiPageFactory::newFromTitle().
Bug: T297688
Change-Id: Ic3f8745de45916baca68ab3620ca88148fbbc4ba
ContentHandler::getContentText() is deprecated and should be
replaced with Content::getText() for TextContent instances.
Change-Id: If38508a069c668e43686226262acbb8ecce92764
Useful for logging
Replace deprecated Http::get with service (since 1.34)
Have to check for falsy to avoid returning non-string
Change-Id: I6d06698cf1e34d0cb9ab7d808145b80b556cd243
The $messageMemc legacy global, is a BagOStuff intended for
MessageCache service, configured by wgMessageCacheType.
Use that directly as a short-term measure so that we can remove
$messageMemc initialization from Setup.php.
Bug: T189966
Bug: T243175
Change-Id: I04a0e578d76269fa02ee85cffee070dc3e1f4512
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingReturn
Additional changes:
* Also sorted "composer fix" command to run phpcbf last.
Change-Id: I668c40626bbb60ff8c1ddc130ffdf95c6eefbd2e
Replacement with services made available in 1.28 and this extension
requires 1.31. So, the replacement is good.
Change-Id: Ia1452ace85d13eb07f7d55b338e120f24d339069