wikimedia/mediawiki-extensions-TitleBlacklist
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/TitleBlacklist synced 2024-12-18 16:41:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace uses of the deprecated setters of AbstractAuthenticationProvider

Browse source 
Since AbstractAuthenticationProvider ::setLogger, ::setManager,
::setConfig, ::setHookContainer methods had been soft deprecated,
so its usages were removed. AuthenticationProviderTestTrait
::initProvider was used in order to initialize
TitleBlacklistPreAuthenticationProvider in the test.
* Also bump required MW version to 1.37.0

Bug: T281994
Change-Id: I15b811a8596addad7a50b13d978851ebd86da9a5
This commit is contained in:
vladshapik 2021-05-07 15:33:56 +03:00 committed by Vlad.shapik
parent 942ff96c7f
commit 3025d83afc
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extension.json
View file

@ -10,7 +10,7 @@
"license-name": "GPL-2.0-or-later", "license-name": "GPL-2.0-or-later",
"type": "antispam", "type": "antispam",
"requires": { "requires": {
"MediaWiki": ">= 1.35.0" "MediaWiki": ">= 1.37.0"
}, },
"GroupPermissions": { "GroupPermissions": {
"sysop": { "sysop": {

8
tests/phpunit/TitleBlacklistPreAuthenticationProviderTest.php
View file

@ -1,19 +1,21 @@
<?php <?php
use MediaWiki\Auth\AuthManager; use MediaWiki\Auth\AuthManager;
use MediaWiki\MediaWikiServices; use MediaWiki\Tests\Unit\Auth\AuthenticationProviderTestTrait;
/** /**
* @group Database * @group Database
* @covers TitleBlacklistPreAuthenticationProvider * @covers TitleBlacklistPreAuthenticationProvider
*/ */
class TitleBlacklistPreAuthenticationProviderTest extends MediaWikiTestCase { class TitleBlacklistPreAuthenticationProviderTest extends MediaWikiIntegrationTestCase {
use AuthenticationProviderTestTrait;
/** /**
* @dataProvider provideGetAuthenticationRequests * @dataProvider provideGetAuthenticationRequests
*/ */
public function testGetAuthenticationRequests( $action, $username, $expectedReqs ) { public function testGetAuthenticationRequests( $action, $username, $expectedReqs ) {
$provider = new TitleBlacklistPreAuthenticationProvider(); $provider = new TitleBlacklistPreAuthenticationProvider();
$provider->setManager( MediaWikiServices::getInstance()->getAuthManager() ); $this->initProvider( $provider, null, null, $this->getServiceContainer()->getAuthManager() );
$reqs = $provider->getAuthenticationRequests( $action, [ 'username' => $username ] ); $reqs = $provider->getAuthenticationRequests( $action, [ 'username' => $username ] );
$this->assertEquals( $expectedReqs, $reqs ); $this->assertEquals( $expectedReqs, $reqs );
} }