mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Thanks
synced 2024-12-23 19:53:05 +00:00
9a709e61b3
Simplify the code and add additional checks for invalid input. Change-Id: Ic1fe978730af7715c72f58cd7af46ab753e614e8
146 lines
4 KiB
PHP
146 lines
4 KiB
PHP
<?php
|
|
/**
|
|
* API module to send thanks notifications for revisions
|
|
*
|
|
* @ingroup API
|
|
* @ingroup Extensions
|
|
*/
|
|
class ApiRevThank extends ApiThank {
|
|
public function execute() {
|
|
$this->dieIfEchoNotInstalled();
|
|
|
|
$user = $this->getUser();
|
|
$this->dieOnBadUser( $user );
|
|
|
|
$params = $this->extractRequestParams();
|
|
$revision = $this->getRevisionFromParams( $params );
|
|
|
|
if ( $this->userAlreadySentThanksForRevision( $user, $revision ) ) {
|
|
$this->markResultSuccess( $revision->getUserText() );
|
|
} else {
|
|
$recipient = $this->getUserFromRevision( $revision );
|
|
$this->dieOnBadRecipient( $user, $recipient );
|
|
$this->sendThanks(
|
|
$user,
|
|
$revision,
|
|
$recipient,
|
|
$this->getSourceFromParams( $params )
|
|
);
|
|
}
|
|
}
|
|
|
|
protected function userAlreadySentThanksForRevision( User $user, Revision $revision ) {
|
|
return $user->getRequest()->getSessionData( "thanks-thanked-{$revision->getId()}" );
|
|
}
|
|
|
|
private function getRevisionFromParams( $params ) {
|
|
$revision = Revision::newFromId( $params['rev'] );
|
|
|
|
// Revision ID 1 means an invalid argument was passed in.
|
|
if ( !$revision || $revision->getId() === 1 ) {
|
|
$this->dieUsage( 'Revision ID is not valid', 'invalidrevision' );
|
|
} elseif ( $revision->isDeleted( Revision::DELETED_TEXT ) ) {
|
|
$this->dieUsage( 'Revision has been deleted', 'revdeleted' );
|
|
}
|
|
return $revision;
|
|
}
|
|
|
|
private function getTitleFromRevision( Revision $revision ) {
|
|
$title = Title::newFromID( $revision->getPage() );
|
|
if ( !$title instanceof Title ) {
|
|
$this->dieUsage( 'Page title could not be retrieved', 'notitle' );
|
|
}
|
|
return $title;
|
|
}
|
|
|
|
/**
|
|
* Set the source of the thanks, e.g. 'diff' or 'history'
|
|
*/
|
|
private function getSourceFromParams( $params ) {
|
|
if ( $params['source'] ) {
|
|
return trim( $params['source'] );
|
|
} else {
|
|
return 'undefined';
|
|
}
|
|
}
|
|
|
|
private function getUserFromRevision( Revision $revision ) {
|
|
$recipient = $revision->getUser();
|
|
if ( !$recipient ) {
|
|
$this->dieUsage( 'No valid recipient found', 'invalidrecipient' );
|
|
}
|
|
return User::newFromId( $recipient );
|
|
}
|
|
|
|
private function sendThanks( User $user, Revision $revision, User $recipient, $source ) {
|
|
global $wgThanksLogging;
|
|
$title = $this->getTitleFromRevision( $revision );
|
|
|
|
// Create the notification via Echo extension
|
|
EchoEvent::create( array(
|
|
'type' => 'edit-thank',
|
|
'title' => $title,
|
|
'extra' => array(
|
|
'revid' => $revision->getId(),
|
|
'thanked-user-id' => $recipient->getId(),
|
|
'source' => $source,
|
|
),
|
|
'agent' => $user,
|
|
) );
|
|
|
|
// Mark the thank in session to prevent duplicates (Bug 46690)
|
|
$user->getRequest()->setSessionData( "thanks-thanked-{$revision->getId()}", true );
|
|
// Set success message
|
|
$this->markResultSuccess( $recipient->getName() );
|
|
// Log it if we're supposed to log it
|
|
if ( $wgThanksLogging ) {
|
|
$this->logThanks( $user, $recipient );
|
|
}
|
|
}
|
|
|
|
public function getDescription() {
|
|
return array(
|
|
'This API is for sending thank you notifications from one editor to another.',
|
|
);
|
|
}
|
|
|
|
public function getParamDescription() {
|
|
return array(
|
|
'rev' => 'A revision ID for an edit that you want to thank someone for',
|
|
'token' => 'An edit token (to prevent CSRF abuse)',
|
|
'source' => "A short string describing the source of the request, for example, 'diff' or 'history'",
|
|
);
|
|
}
|
|
|
|
public function getAllowedParams() {
|
|
return array(
|
|
'rev' => array(
|
|
ApiBase::PARAM_TYPE => 'integer',
|
|
ApiBase::PARAM_MIN => 1,
|
|
ApiBase::PARAM_REQUIRED => true,
|
|
),
|
|
'token' => array(
|
|
ApiBase::PARAM_TYPE => 'string',
|
|
ApiBase::PARAM_REQUIRED => true,
|
|
),
|
|
'source' => array(
|
|
ApiBase::PARAM_TYPE => 'string',
|
|
ApiBase::PARAM_REQUIRED => false,
|
|
)
|
|
);
|
|
}
|
|
|
|
public function getHelpUrls() {
|
|
return array(
|
|
'https://www.mediawiki.org/wiki/Extension:Thanks#API_Documentation',
|
|
);
|
|
}
|
|
|
|
public function getExamples() {
|
|
return array(
|
|
'api.php?action=thank&revid=123&source=diff&token=xyz456'
|
|
=> 'Send thanks for revision with the ID 123, with the source being a diff page',
|
|
);
|
|
}
|
|
}
|