Commit graph

24 commits

Author SHA1 Message Date
Ed Sanders f18aee5bbc Move var declarations inline
Change-Id: Ib952bd8a8eb9e0fce9541c4f9336169416593f3e
2023-11-30 10:58:04 +00:00
David Lynch 7e05c0f97a Correct attribute for flow thanks
This is a follow up to aaaa5b63da.

Bug: T300831
Change-Id: I984a45c330a3f28dde11d80c520d40aac3b4aacb
2022-02-03 14:06:17 -06:00
Ed Sanders aaaa5b63da JS: Update APIs to make more extensible
* Don't require a jQuery element with a specific attribute
  to record thanks. Instead pass in the thanked ID directly.
* In Flow, don't override the cookieName static property,
  instead pass it in as an argument.
  Change the static property (effectively a global) prevents
  us from having multiple types of thanks on the same page.

Change-Id: Ia569f8636f070f2af69f89d7da66c9a6f9821d24
2022-01-25 22:02:15 +00:00
Ed Sanders c033679cb8 build: Update eslint-config-wikimedia
Change-Id: I3cbcbb1695896ddc1e54c40dc0da50f91944916f
2019-12-12 11:36:24 +00:00
Ed Sanders e453114f55 Remove obsolete aliases from closures
Bug: T208951
Change-Id: Ie84c06e4a69923a5993b173d490bfa97189c285b
2018-11-12 19:22:46 +00:00
James D. Forrester e315e954a6 build: Replace jshint and jscs with eslint; drop csslint
Removing csslint rather than replacing it with stylelint as there
are no CSS or LESS files in this repo.

Also bumping banana and jsonlint to latest.

Change-Id: I9ffce273f63b061e07c3fa90ab4e82b5e551aa92
2017-08-03 17:24:34 -07:00
Fomafix 8dc7cec329 Replace $( document ).ready(...) by $(...)
In jQuery 3 $(document).ready(...) is deprecated.
https://jquery.com/upgrade-guide/3.0/#deprecated-document-ready-handlers-other-than-jquery-function

Change-Id: I71bd8bb06809faf5d0d9f99018ed21d3bb816f79
2017-01-06 14:17:40 +01:00
Prateek Saxena be2ed5f959 Use OO.ui.alert() instead of plain alert
Bug: T128891
Change-Id: Ib5d47bad48e8d42098de19a2c87dd863a38c2a2d
2016-07-15 20:55:21 +05:30
Ricordisamoa c1da017852 Use "csrf" tokens instead of "edit" ones
"edit" type tokens have been deprecated in favour of the
more generic "csrf" type tokens.
This has been causing warnings since: 65077ede90

See also https://www.mediawiki.org/wiki/API:Tokens

Bug: T134532
Change-Id: I3ce3c1e6a40f8a21c931c77314021e2ae94e5fb7
2016-05-26 09:02:17 +02:00
James D. Forrester a23a878953 build: Remove all non-mobile jscs over-rides and make pass
Change-Id: Iecc96b34c2a3bdecdd6d90b4e5d9b76f12604386
2016-04-22 12:47:08 -07:00
Kunal Mehta 88e344de1b Make sure error code is always passed to 'thanks-error-undefined'
Bug: T130880
Change-Id: I3c6d8d7592b867a3457283e321940895e3c08ba5
2016-03-29 15:12:57 -07:00
Stephane Bisson 1888227212 Fix Flow thank of post with descendents
Bug: T125168
Change-Id: Ic9d8c04549a174ad5f6a426e872fd7bc219b755d
2016-01-29 14:28:20 -05:00
Kunal Mehta 514e9d4c7f Call mw.Api() constructor properly
Change-Id: I56b3c6e17a509056a5ed5ceb5b4dcb376cdec0c3
2015-06-15 19:58:07 -07:00
Moriel Schottlender 0a5664ce5e Check the thanked user's gender for Thanks messages
Retrieve gender data for the thanked user for i18n message parsing
with the correct {{GENDER...}} data.

Bug: T96527
Change-Id: I14c831be51482682f2b628a15c79341a4f372c16
2015-05-04 17:16:09 -07:00
Roan Kattouw 805fefd198 Actually pass jscs
Removed exemptions from .jscsrc and fixed the code so jscs still passes.

Kept the exemption for disallowDanglingUnderscores because
of the naming convention for private functions in this repo.

Change-Id: I860f73394a2b92a411fe682abbb2ab0b5e1325f9
2015-05-04 12:13:43 -07:00
Matthias Mullie 8618a95f79 Use postWithToken
Change-Id: I8d8949b66782af2956726b55db64b2dce97d5e4a
2014-09-01 14:27:10 +02:00
Kunal Mehta a53c7b3127 Use POST requests for action=thanks/flowthanks
This is now necessary after the tokens re-write in core.

Bug: 70138
Change-Id: Ide61f7b9e6d58cc53b04cdeef9d17f781ef25039
2014-08-28 13:10:38 -07:00
Erik Bernhardson ccdca0d0d7 Support updated flow frontend
* Flow no-longer allows arbitrary html insertion, so remove
* Update ext.thanks.flowthank.js to work with thank links generated
  directly by flow.

Change-Id: I8ae14352f1b177446f3696ffadd6921a5125238e
2014-07-15 15:07:33 -07:00
wctaiwan 0e0ef33ea3 Bind Flow Thank click detection to .flow-container
Single-topic views do not have a flow-topics wrapper, making Thanks broken
in those views.

Bug: 63205
Change-Id: I19c7d2da2d409f8c0a270600b092d504255d4111
2014-06-05 14:00:00 +08:00
wctaiwan 078875980e Use .on() instead of .click() for Flow Thanks
This makes the Thank button function correctly for posts that are
dynamically loaded with JavaScript (from
http://stackoverflow.com/q/9344306)

Bug: 63205
Change-Id: If51e1801e633573c8f0814832e26d643e1237d53
2014-05-16 00:47:32 +00:00
jenkins-bot 45e38cadf8 Merge "Clone thanked label before inserting" 2014-04-07 19:27:21 +00:00
Benjamin Chen 18bbaf3bdd Clone thanked label before inserting
ThankedLabel is inserted before the Thank link that's being clicked.
The label needs to be cloned on each insertion so it is not removed
on subsequent $.insert().

Bug: 63506
Change-Id: I8327158880cba9a141a4d9977414022173c4c8ac
2014-04-04 03:05:21 +00:00
Benjamin Chen 36b839ead2 Add hover highlight to Thank link in Flow posts
Bug: 62556
Change-Id: I3adb60d5b1c75500f8276cda8b8eaa2646bb1565
2014-03-21 04:04:04 +08:00
wctaiwan 98726b568b Add "Thanks" for comments on Flow boards
bug: 61930
Change-Id: Id37a14e3c75c63419fc34e0b7c2e21f74b3fa875
Co-authored-by: Bencmq <bencmqwiki@gmail.com>
2014-03-14 11:03:11 +00:00