Commit graph

9 commits

Author SHA1 Message Date
Framawiki fe8a3916c2 EchoCoreThanksPresentationModel: Avoid re-implementing getThankType()
Change-Id: I48aa7593cec275ed4e38b22b36a2a998c7202cdc
2018-08-30 02:20:00 +00:00
jenkins-bot fc4893d833 Merge "Use new Special:Log?logid=xxx URL for notification link" 2018-05-04 05:59:47 +00:00
Sam Wilson 862c737aa0 Fix canRender and add greppable messages for dynamic keys
This fixes issues raised in https://gerrit.wikimedia.org/r/#/c/416207/4/includes/EchoCoreThanksPresentationModel.php

Bug: T192711
Change-Id: I5e654f5ae9480aa048326c067129fafd430f0515
2018-04-24 06:38:26 +08:00
Sam Wilson 0fa3196e8b Use new Special:Log?logid=xxx URL for notification link
Avoid redirecting via Special:Redirect/logid/xxx with the new
logid parameter to Special:Log.

Bug: T191608
Depends-On: I5f2e52531cd2ba617a25570e40aa8c5168e284d9
Change-Id: Iffb1b0d9cc44fde69aa53f32d4a066cd3a10c5f4
2018-04-23 12:40:54 +08:00
Kunal Mehta e696cba57f Add phan configuration
Change-Id: I6d0a0823404e5e50819ae0997b7d2c5267a4e144
2018-04-09 00:12:28 -07:00
Max Semenik ed087b044c Reintroduce the API to thank for log entries
Originally introduced in b84eedc74e, it was reverted for security concerns.
New changes:
* Instead of bundling the log summary with notification, load it on display
* If the log event has been suppressed after the thanks for it has been sent,
  silently delete the event to prevent the confusion of linking to something
  zapped.
* Keep the 'already sent' cache key compatible with old format
* Validate the log id in the API
* Change ApiCoreThank::getRevisionFromParams() to ApiCoreThank::getRevisionFromId()

Bug: T186855
Bug: T188791
Depends-On: Ic5e9db0def857d9dcecbd06bf081c8c83712c1ea
Change-Id: I03aea7d9f4dfa0fe49639c53968deabf89999d2d
2018-03-06 13:08:47 +08:00
MaxSem 3b2397fea9 Revert "Add support to the Thanks API for thanking log entries"
This reverts commit b84eedc74e.

Bug: T188791
Change-Id: If55ed6cbb5da34c0034da3cc564c6a8ff82448d2
2018-03-02 22:59:20 +00:00
Sam Wilson b84eedc74e Add support to the Thanks API for thanking log entries
Add a 'log' API parameter (for the log ID to thank), and add
a whitelist config variable for specifying which log types are
thankable.

Bug: T186855
Change-Id: I58ae90c9729c0066f952e90fca2cf99b029d0d9b
2018-03-01 14:57:57 -08:00
Sam Wilson 78831d2b68 Rename files and classes in preparation for adding log-thanks
Bug: T186855
Change-Id: I20f5d200c33e395aca9489b73d0ed9b1d0ad5b8c
2018-02-21 12:49:21 +08:00
Renamed from includes/EchoThanksPresentationModel.php (Browse further)