In detail:
* Use more compact syntax to avoid a bit of code duplication.
* Use createMock() shortcut in tests.
* Avoid hiding code in strings.
* Remove a comment that literally repeats what the code says.
Change-Id: Ibedef380489451268e2e87f0864164e8f9737913
The thanks icon had styling issues as it didn't use the mobile
icon and button fundamental components.
The icon should also be inside the button, the element should not
be both a button and an icon.
Bug: T229440
Change-Id: I0136466fe1452f904961b89ae7677fc1a511adab
When the thanks button is clicked a thanks will be
queued, that the user can cancel by clicking "cancel"
before the action is completed.
This should help the majority of users experiencing
accidental thanks.
Bug: T63737
Change-Id: I807f729c1b1a9e9b5952685bb18f540f81d70f47
Instead use mediawiki.ui and ResourceLoaderImageModule
Other changes:
* Add gender support to thanks-button-thanked
Depends-On: I0745e112d11026ed59d8daca990b313305cd094a
Bug: T198151
Change-Id: I82ae596330aff8387653c65a6bab5ff729641a80
* Explicit return null instead of no return.
* Document right @return type.
* Avoid else paths by using early return.
Change-Id: I24c434ebb57188346ad7cd722f08390ba6da2c34
Removing csslint rather than replacing it with stylelint as there
are no CSS or LESS files in this repo.
Also bumping banana and jsonlint to latest.
Change-Id: I9ffce273f63b061e07c3fa90ab4e82b5e551aa92
Rather than using mobile.startup, switch
to using mediawiki.notification which is more
lightweight and does same thing.
Bug: T155801
Change-Id: I23d75272602766e24e8b01410f4a88609eda6dee
"edit" type tokens have been deprecated in favour of the
more generic "csrf" type tokens.
This has been causing warnings since: 65077ede90
See also https://www.mediawiki.org/wiki/API:Tokens
Bug: T134532
Change-Id: I3ce3c1e6a40f8a21c931c77314021e2ae94e5fb7
Retrieve gender data for the thanked user for i18n message parsing
with the correct {{GENDER...}} data.
Bug: T96527
Change-Id: I14c831be51482682f2b628a15c79341a4f372c16
Removed exemptions from .jscsrc and fixed the code so jscs still passes.
Kept the exemption for disallowDanglingUnderscores because
of the naming convention for private functions in this repo.
Change-Id: I860f73394a2b92a411fe682abbb2ab0b5e1325f9
Also adding a helpful comment.
Leaving existing mw-mf-action-button class for now since this
provides the float left. Eventually we should migrate the styles
in MobileFrontend to use mw-ui-button as well and reduce the
redundant styles that are set. See also:
Change I59e8441f4c4e1d33bff33afcab6c6670d7b99634
Bug: 61490
Change-Id: I7e14b8eb522d8d7443fa917d97cb91773c6410f0
If the user has already been thanked, make the button greyed out
and display the text "Thanked" instead of "Thank".
Dependency: Ife9f456a7a9cf74b1b54fdc6128feb230fd6f671
Bug: 59828
Change-Id: Ifab78fe62910c9c3f2a927a6a4bbe28fb953b160
Also making thank button for mobile capitalized.
Also update for new clickTracking code.
Also promoting to stable.
Dependency: I56e2c5bc69f85e83ab3dfd9b9e617dbb98661870
Change-Id: Ifaf44fe8994a8085c30522292bba8b768da533db
