Every time the setup function runs, it chooses a random page name with
random content. If it chooses a page name + content combination that was
used to set up a different test in the same run, the edit it makes will
be a null edit, the revid will be null, and the test will crash.
There are 100 possible page names and 100 possible page texts, so 10k
possibilities total, and the setup function appears to be called 10 times,
so the probability of a collision would have been
(10 choose 2)/10000 = 0.0045 = 0.45%, or one in every 222 times.
Bug: T151878
Change-Id: I800ee8512c2ad171ba793bea343f456653f9a16d
Originally introduced in b84eedc74e, it was reverted for security concerns.
New changes:
* Instead of bundling the log summary with notification, load it on display
* If the log event has been suppressed after the thanks for it has been sent,
silently delete the event to prevent the confusion of linking to something
zapped.
* Keep the 'already sent' cache key compatible with old format
* Validate the log id in the API
* Change ApiCoreThank::getRevisionFromParams() to ApiCoreThank::getRevisionFromId()
Bug: T186855
Bug: T188791
Depends-On: Ic5e9db0def857d9dcecbd06bf081c8c83712c1ea
Change-Id: I03aea7d9f4dfa0fe49639c53968deabf89999d2d
Add a 'log' API parameter (for the log ID to thank), and add
a whitelist config variable for specifying which log types are
thankable.
Bug: T186855
Change-Id: I58ae90c9729c0066f952e90fca2cf99b029d0d9b
Removing csslint rather than replacing it with stylelint as there
are no CSS or LESS files in this repo.
Also bumping banana and jsonlint to latest.
Change-Id: I9ffce273f63b061e07c3fa90ab4e82b5e551aa92
See Iae0e2ce3. Since Thanks master requires core master, this just
depends on the master patch instead of trying to maintain BC.
Depends-On: Iae0e2ce3bd42dd4776a9779664086119ac188412
Change-Id: Ib6e66f7e94c41b7a27fe867f079626ac0ade4f1b
The target-page entry allows locating those notifications
when the topic is moderated.
Bug: T93673
Change-Id: Ibe6bfda424b3ba2199efd712a5be194da4d5e6f2
This is a prerequisite for I17ef1f519, since the tests break otherwise. The
change is backward-compatible since it checks for the presence of the
getTestUser method introduced by that change.
Change-Id: I8bbc9ebf32a89157fa9c60fd33151a10e7598af8
Pimple throws an exception when overriding something that was
already fetched from container.
This is currently causing some extensions trouble.
To prevent shared state between tests the flow container
needs to be reset in the setUp() routine of all tests
accesing the container.
Bug: T91967
Change-Id: Ic80b137e6ca2f8ba6ad34ce0bdbb1319b81c0a6e
MediaWiki core change I04b1a384 added support for i18n of API module
help. This takes advantage of that while still maintaining backwards
compatibility with earlier versions of MediaWiki.
Once support for MediaWiki before 1.25 is dropped, the methods marked
deprecated in this patch may be removed.
Change-Id: I67395aff48185f3e09da31b51a08aa2541fe6a17
Since we've recently introduced a topic namespace, the notification looked like:
"Username thanked you for your comment in "Topic title" on Topic:UUID"
We want the board name instead of the link to the topic page, like:
"Username thanked you for your comment in "Topic title" on Talk:Boardname"
Change-Id: If45c01be3b0a9d67572932253a0103a2480fc823
Relying on UUID::__toString() now triggers a notice, causing
unrelated patches to fail. This patch addresses the issue.
Change-Id: Ia94826a0e600adf8afd5908af75772b596ab8d0a
The test suite sets up various mocks for Flow classes and inserts
them into Flow\Container, so the API module retrieves the correct
mock classes instead.
Change-Id: I9c5e910e288f3dd72c66e68ca558265b8ca8ce5e
If the user has JavaScript disabled, clicking
on "thank" will send the user to Special:Thanks
with the revision id already filled in. When
submitted, the form calls the API internally
and then shows the user an error or confirmation
message.
Special:Thanks is not a listed special page
since it's mainly intended as a fallback.
The API was modified to return the user name of the
editor who is being thanked if a new notification
was created.
Bug: 49161
Change-Id: I7ba4664b92bb0da425784350487ed0e7ca352b4e
If the user attempts to thank an anonymous
user, a bot (when $wgThanksSendToBots is not true),
or him/herself, return an error. This is consistent
with the restrictions imposed in insertThankLink().
Bug: 56954
Change-Id: I9e8ae030a8ff1cc312bf98671e593c7367ca0ea2
