Commit graph

9 commits

Author SHA1 Message Date
Benjamin Chen fbaed178a5 Add integration test for flowthank API
The test suite sets up various mocks for Flow classes and inserts
them into Flow\Container, so the API module retrieves the correct
mock classes instead.

Change-Id: I9c5e910e288f3dd72c66e68ca558265b8ca8ce5e
2014-03-14 19:16:11 +08:00
wctaiwan 98726b568b Add "Thanks" for comments on Flow boards
bug: 61930
Change-Id: Id37a14e3c75c63419fc34e0b7c2e21f74b3fa875
Co-authored-by: Bencmq <bencmqwiki@gmail.com>
2014-03-14 11:03:11 +00:00
addshore 4cdfa4e1f8 Add basic unit test for dieOnBadUser api method
Change-Id: Ic9fd4e63b0a7e3508c600f34decb8ce18abc1597
2014-01-24 13:13:25 -08:00
jenkins-bot 31437cf89d Merge "Add Special:Thanks as a non-JS fallback" 2013-12-19 05:43:11 +00:00
jenkins-bot 3573062156 Merge "Thanks is not using namespaces" 2013-12-06 08:00:55 +00:00
Kunal Mehta 06360b6d0d Add Special:Thanks as a non-JS fallback
If the user has JavaScript disabled, clicking
on "thank" will send the user to Special:Thanks
with the revision id already filled in. When
submitted, the form calls the API internally
and then shows the user an error or confirmation
message.

Special:Thanks is not a listed special page
since it's mainly intended as a fallback.

The API was modified to return the user name of the
editor who is being thanked if a new notification
was created.

Bug: 49161
Change-Id: I7ba4664b92bb0da425784350487ed0e7ca352b4e
2013-12-05 23:23:21 -08:00
theopolisme 72c0bf5d52 Perform checks before thanking via API
If the user attempts to thank an anonymous
user, a bot (when $wgThanksSendToBots is not true),
or him/herself, return an error. This is consistent
with the restrictions imposed in insertThankLink().

Bug: 56954
Change-Id: I9e8ae030a8ff1cc312bf98671e593c7367ca0ea2
2013-11-24 17:41:21 -06:00
Kunal Mehta 6240343103 Thanks is not using namespaces
Added in 422f0f6062

Change-Id: I8809348d30fdd8b569affd00cc061de22b38e6dc
2013-11-22 23:25:25 -08:00
addshore 422f0f6062 Add really basic API tests
This also includes the unit test hooks

Jenkings job will be added with I6ec2edf62b9

Change-Id: Id085db7096db420416e9fba72a65586d021f1c76
2013-11-04 16:38:23 +00:00